johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(test): ignore mtime-only changes in repo beads guard

Browse Source 
The test guard was flagging false positives when SQLite shm/wal files
had their mtime updated from read-only operations (config loading, etc.)
without any actual content modification.

Now only reports when file size changes, which indicates actual content
modification rather than just file access.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
dennis
2026-01-13 00:20:48 -08:00
committed by gastown/crew/dennis
parent 82a824ed92
commit c9cc1308d5
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.beads/issues.jsonl
View File

@@ -1565,6 +1565,7 @@
{"id":"bd-l4b6","title":"Add tests for bd init --team wizard","description":"Write integration tests for the team wizard:\n- Test branch detection\n- Test sync branch creation\n- Test protected branch workflow\n- Test auto-sync configuration","status":"closed","priority":2,"issue_type":"task","created_at":"2025-11-05T18:58:18.192425-08:00","updated_at":"2025-11-06T20:06:49.22056-08:00","closed_at":"2025-11-06T19:55:39.687439-08:00"}
{"id":"bd-l5esz","title":"Session ended: gt-beads-refinery","status":"closed","priority":2,"issue_type":"event","owner":"steve.yegge@gmail.com","created_at":"2026-01-12T02:49:41.269396-08:00","created_by":"beads/refinery","updated_at":"2026-01-12T02:49:41.335288-08:00","closed_at":"2026-01-12T02:49:41.335288-08:00","close_reason":"auto-closed session cost wisp","ephemeral":true}
{"id":"bd-l5gq","title":"Optimize test suite performance - cut runtime by 50%+","description":"## Problem\nTest suite takes ~20.8 seconds, with 95% of time spent in just 2 tests:\n- TestHashIDs_MultiCloneConverge: 11.08s (53%)\n- TestHashIDs_IdenticalContentDedup: 8.78s (42%)\n\nBoth tests in beads_hash_multiclone_test.go perform extensive Git operations (bare repos, multiple clones, sync rounds).\n\n## Goal\nCut total test time by at least 50% (to ~10 seconds or less).\n\n## Analysis\nTests already have some optimizations:\n- --shared --depth=1 --no-tags for fast cloning\n- Disabled hooks, gc, fsync\n- Support -short flag\n\n## Impact\n- Faster development feedback loop\n- Reduced CI costs and time\n- Better developer experience","status":"closed","priority":2,"issue_type":"epic","created_at":"2025-11-04T01:23:14.410648-08:00","updated_at":"2025-11-04T11:23:13.683213-08:00","closed_at":"2025-11-04T11:23:13.683213-08:00"}
{"id":"bd-l5iqg","title":"Session ended: gt-beads-crew-dave","status":"closed","priority":2,"issue_type":"event","owner":"steve.yegge@gmail.com","created_at":"2026-01-13T00:18:40.59742-08:00","created_by":"beads/crew/dave","updated_at":"2026-01-13T00:18:40.663631-08:00","closed_at":"2026-01-13T00:18:40.663631-08:00","close_reason":"auto-closed session cost wisp","ephemeral":true}
{"id":"bd-l5jpu","title":"Session ended: gt-beads-crew-wolf","status":"closed","priority":2,"issue_type":"event","created_at":"2026-01-10T00:38:11.508998-08:00","created_by":"beads/crew/wolf","updated_at":"2026-01-10T00:38:11.545391-08:00","closed_at":"2026-01-10T00:38:11.545391-08:00","close_reason":"auto-closed session cost wisp","ephemeral":true}
{"id":"bd-l6veq","title":"Session ended: gt-beads-crew-emma","status":"closed","priority":2,"issue_type":"event","created_at":"2026-01-10T13:37:03.899972-08:00","created_by":"beads/crew/emma","updated_at":"2026-01-10T13:37:03.942079-08:00","closed_at":"2026-01-10T13:37:03.942079-08:00","close_reason":"auto-closed session cost wisp","ephemeral":true}
{"id":"bd-l6yk","title":"bd mol burn should work on mols, not just wisps","description":"Currently `bd mol burn` only works on wisps (Ephemeral=true):\n\n```\n$ bd mol burn bd-mol-p7i\nError: molecule bd-mol-p7i is not a wisp (Ephemeral=false)\nHint: mol burn only works with wisp molecules\n Use 'bd delete' to remove non-wisp issues\n```\n\nThe name 'burn' implies destruction - it should work on any molecule, not just wisps. When called on a regular mol, it should convert to `bd delete --cascade`.\n\n**Proposed behavior:**\n- If wisp: current behavior (delete without tombstones)\n- If mol: `bd delete \u003cid\u003e --cascade` (delete with tombstones)\n\nThis makes the metaphor consistent: burn = destroy a molecule, regardless of phase.","status":"closed","priority":3,"issue_type":"feature","created_at":"2025-12-29T17:05:08.115592-08:00","created_by":"beads/crew/emma","updated_at":"2025-12-29T17:10:19.034979-08:00","closed_at":"2025-12-29T17:10:19.034979-08:00","close_reason":"Implemented: mol burn now works on both wisps and mols"}

13
cmd/bd/test_repo_beads_guard_test.go
View File

@@ -120,14 +120,11 @@ func diffSnapshots(before, after map[string]fileSnap) string {
if !b.exists {
continue
}
if b.size != a.size || b.modUnix != a.modUnix {
out += fmt.Sprintf("- %s: size %d → %d, mtime %s → %s\n",
name,
b.size,
a.size,
time.Unix(0, b.modUnix).UTC().Format(time.RFC3339Nano),
time.Unix(0, a.modUnix).UTC().Format(time.RFC3339Nano),
)
// Only report size changes (actual content modification).
// Ignore mtime-only changes - SQLite shm/wal files can have mtime updated
// from read-only operations (config loading, etc.) which is not pollution.
if b.size != a.size {
out += fmt.Sprintf("- %s: size %d → %d\n", name, b.size, a.size)
}
}
return out