johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(staleness): use RFC3339Nano precision for last_import_time (#399)

Browse Source 
The staleness check compares last_import_time against JSONL file mtime.
File mtime has nanosecond precision, but last_import_time was stored with
only second precision (RFC3339). This caused a race condition where the
stored time could be slightly earlier than the file mtime, triggering
false "Database out of sync" errors - particularly in git worktrees.

Changed all 6 locations that set last_import_time to use RFC3339Nano.
The CheckStaleness parser already handles both formats, so this is
backward compatible.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-11-27 00:11:01 -08:00
parent e8ffac63ba
commit cdc156428c
5 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/bd/autoflush.go
View File

@@ -231,7 +231,8 @@ func autoImportIfNewer() {
}
// Store import timestamp (bd-159: for staleness detection)
importTime := time.Now().Format(time.RFC3339)
// Use RFC3339Nano for nanosecond precision to avoid race with file mtime (fixes #399)
importTime := time.Now().Format(time.RFC3339Nano)
if err := store.SetMetadata(ctx, "last_import_time", importTime); err != nil {
fmt.Fprintf(os.Stderr, "Warning: failed to update last_import_time after import: %v\n", err)
}

3
cmd/bd/daemon_sync.go
View File

@@ -295,7 +295,8 @@ func updateExportMetadata(ctx context.Context, store storage.Storage, jsonlPath
log.log("Next export may require running 'bd import' first")
}
exportTime := time.Now().Format(time.RFC3339)
// Use RFC3339Nano for nanosecond precision to avoid race with file mtime (fixes #399)
exportTime := time.Now().Format(time.RFC3339Nano)
if err := store.SetMetadata(ctx, timeKey, exportTime); err != nil {
log.log("Warning: failed to update %s: %v", timeKey, err)
}

3
cmd/bd/import.go
View File

@@ -357,7 +357,8 @@ NOTE: Import requires direct database access and does not work with daemon mode.
// is unavailable. This ensures import operations always succeed even if metadata storage fails.
debug.Logf("Warning: failed to update last_import_hash: %v", err)
}
importTime := time.Now().Format(time.RFC3339)
// Use RFC3339Nano for nanosecond precision to avoid race with file mtime (fixes #399)
importTime := time.Now().Format(time.RFC3339Nano)
if err := store.SetMetadata(ctx, "last_import_time", importTime); err != nil {
// Non-fatal warning (see above comment about graceful degradation)
debug.Logf("Warning: failed to update last_import_time: %v", err)

3
cmd/bd/sync.go
View File

@@ -945,7 +945,8 @@ func exportToJSONL(ctx context.Context, jsonlPath string) error {
// is unavailable. This ensures export operations always succeed even if metadata storage fails.
fmt.Fprintf(os.Stderr, "Warning: failed to update last_import_hash: %v\n", err)
}
exportTime := time.Now().Format(time.RFC3339)
// Use RFC3339Nano for nanosecond precision to avoid race with file mtime (fixes #399)
exportTime := time.Now().Format(time.RFC3339Nano)
if err := store.SetMetadata(ctx, "last_import_time", exportTime); err != nil {
// Non-fatal warning (see above comment about graceful degradation)
fmt.Fprintf(os.Stderr, "Warning: failed to update last_import_time: %v\n", err)

6
internal/autoimport/autoimport.go
View File

@@ -93,7 +93,8 @@ func AutoImportIfNewer(ctx context.Context, store storage.Storage, dbPath string
notify.Debugf("auto-import skipped, JSONL unchanged (hash match)")
// Update last_import_time to prevent repeated staleness warnings
// This handles the case where mtime changed but content didn't (e.g., git pull, touch)
importTime := time.Now().Format(time.RFC3339)
// Use RFC3339Nano for nanosecond precision to avoid race with file mtime (fixes #399)
importTime := time.Now().Format(time.RFC3339Nano)
if err := store.SetMetadata(ctx, "last_import_time", importTime); err != nil {
notify.Warnf("failed to update last_import_time: %v", err)
}
@@ -133,7 +134,8 @@ func AutoImportIfNewer(ctx context.Context, store storage.Storage, dbPath string
notify.Warnf("This may cause auto-import to retry the same import on next operation.")
}
importTime := time.Now().Format(time.RFC3339)
// Use RFC3339Nano for nanosecond precision to avoid race with file mtime (fixes #399)
importTime := time.Now().Format(time.RFC3339Nano)
if err := store.SetMetadata(ctx, "last_import_time", importTime); err != nil {
notify.Warnf("failed to update last_import_time after import: %v", err)
}