Commit Graph

1157 Commits

Author SHA1 Message Date
Steve Yegge
ef5128fe24 Export SortPolicy type and constants
Export SortPolicy from beads package so external tools (like VC)
can use the sort policy constants without importing internal packages.

Added:
- SortPolicy type alias
- SortPolicyHybrid, SortPolicyPriority, SortPolicyOldest constants

This completes the sort policy feature for external consumers.
2025-10-25 20:20:12 -07:00
Steve Yegge
0709fd85dc Make Homebrew verification step mandatory and more prominent 2025-10-25 19:00:03 -07:00
Steve Yegge
5b963e3379 chore: Bump version to 0.17.2 2025-10-25 18:57:47 -07:00
Steve Yegge
fdf7188ba4 Add 0.17.2 release notes 2025-10-25 18:57:07 -07:00
Steve Yegge
8660cb631b Close bd-146 (duplicate) and bd-147 (sort policy implemented) 2025-10-25 18:54:24 -07:00
Steve Yegge
09c11a26e6 Add configurable sort policy for GetReadyWork (bd-147)
- Add SortPolicy type with hybrid, priority, oldest constants
- Add SortPolicy field to WorkFilter
- Implement buildOrderByClause() for SQL generation
- Add --sort flag to bd ready command
- Add comprehensive tests for all 3 sort policies
- Update RPC protocol to support sort policy
- Update documentation with sort policy examples

Enables autonomous systems like VC to use strict priority ordering
while preserving hybrid behavior for interactive use.

Amp-Thread-ID: https://ampcode.com/threads/T-9d7ea9db-8d6d-4498-9daa-48a7e104ce1f
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 18:54:00 -07:00
Steve Yegge
b855c444d4 Enable errcheck linter and fix all production code warnings
- Enabled errcheck linter (previously disabled)
- Set tests: false in .golangci.yml to focus on production code
- Fixed 27 errcheck warnings using Go best practices:
  * Database resources: defer func() { _ = rows.Close() }()
  * Transaction rollbacks: defer func() { _ = tx.Rollback() }()
  * Best-effort closers: _ = store.Close(), _ = client.Close()
  * File writes: proper error checking on Close()
  * Interactive input: handle EOF gracefully
  * File ops: ignore ENOENT on os.Remove()
- All tests pass
- Closes bd-58

Amp-Thread-ID: https://ampcode.com/threads/T-57c9afd3-9adf-40c2-8be7-3e493d200361
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 18:44:38 -07:00
Steve Yegge
bb33007036 Fix revive style issues (bd-56)
- Fix 14 unused-parameter warnings (rename to _)
- Fix 2 redefines-builtin-id (max→maxCount, min→minInt)
- Fix 3 indent-error-flow issues with gofmt
- Merged duplicate bd-126 into bd-116
2025-10-25 18:13:49 -07:00
Steve Yegge
14e14f647e Fix goconst linter issues (bd-116)
- Use windowsOS constant in reinit_test.go
- Use testIssueBD1 constant in compact_test.go and counter_sync_test.go
- Merged duplicate bd-126 into bd-116
2025-10-25 18:04:05 -07:00
Steve Yegge
37e5dcf4f8 Close bd-78: flaky test already fixed 2025-10-25 18:00:41 -07:00
Steve Yegge
0caf423021 Re-land TestDatabaseReinitialization with CI fixes
Fixes bd-130

Fixed all CI failures that caused the original revert:
- Windows: Use filepath.ToSlash() for git paths (git always uses forward slashes)
- Nix: Skip test when git not available (NIX_BUILD_TOP env check)
- JSON parsing: Increased scanner buffer to 64MB for large issue descriptions
- Cross-platform: Added normalizeGitPath() helper for path comparisons

Also restored beads.jsonl > issues.jsonl precedence in checkGitForIssues().

All tests pass locally.

Amp-Thread-ID: https://ampcode.com/threads/T-a560d9a0-29b9-4c46-aa90-813758d2553c
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 17:49:17 -07:00
Steve Yegge
ec43028dc9 Sync beads issues 2025-10-25 17:40:09 -07:00
Steve Yegge
744563e87f Add health checks and reconnection logic for stale daemon sockets (bd-137)
- Add ping() and health() methods to BdDaemonClient for connection verification
- Implement _health_check_client() to verify cached client connections
- Add _reconnect_client() with exponential backoff (0.1s, 0.2s, 0.4s, max 3 retries)
- Update _get_client() to health-check before returning cached clients
- Automatically detect and remove stale connections from pool
- Add comprehensive test suite with 14 tests covering all scenarios
- Handle daemon restarts, upgrades, and long-idle connections gracefully

Amp-Thread-ID: https://ampcode.com/threads/T-2366ef1b-389c-4293-8145-7613037c9dfa
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 17:39:21 -07:00
Steve Yegge
a91467d2fb Add full release automation script
Amp-Thread-ID: https://ampcode.com/threads/T-789d9ba6-2aea-4ee9-b4dc-ce73e8f496f4
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 16:57:15 -07:00
Steve Yegge
d31e9e7156 Add Homebrew formula update automation script
Amp-Thread-ID: https://ampcode.com/threads/T-789d9ba6-2aea-4ee9-b4dc-ce73e8f496f4
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 16:54:15 -07:00
Steve Yegge
36490a1648 Fix RELEASING.md: clarify rebuild requirement and Homebrew timing
Issues fixed:
- Added explicit rebuild step after version bump (source changes but binary doesn't)
- Clarified Homebrew formula update must happen AFTER tag push
- Added git pull step for /tmp/homebrew-beads to avoid stale repo
- Made it clear users won't get new version until Homebrew formula is updated
- Removed redundant git config steps (already configured in cloned repo)
2025-10-25 16:48:28 -07:00
Steve Yegge
d301ac68ed chore: Bump version to 0.17.1
Updated all component versions:
- bd CLI: 0.17.0 → 0.17.1
- Plugin: 0.17.0 → 0.17.1
- MCP server: 0.17.0 → 0.17.1
- Documentation: 0.17.0 → 0.17.1

Generated by scripts/bump-version.sh
2025-10-25 16:45:16 -07:00
Steve Yegge
15790ea664 Auto-sync beads database 2025-10-25 16:44:32 -07:00
Steve Yegge
c2056152e6 Add bd info command to show database path and daemon status
Implements bd-145. Users can now easily determine which database file bd is using
and check daemon connection status.

Features:
- Shows absolute database path
- Displays daemon status (connected/mode/health/version)
- Shows issue count
- Supports --json output for programmatic use
- Works in both daemon and direct modes

Example output:
  bd info                    # Human-readable
  bd info --json             # JSON for agents
  bd info --no-daemon        # Force direct mode

Updated documentation in README.md and AGENTS.md.

Amp-Thread-ID: https://ampcode.com/threads/T-a33c0762-f800-4fea-9510-6a803d8aece8
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 16:43:44 -07:00
Steve Yegge
aada5d9ac6 Fix bd-144: Update main .db file timestamp after import (WAL mode)
- Added CheckpointWAL method to SQLite storage
- Import now checkpoints WAL after completion
- Updates main .db file modification time for staleness detection
- PRAGMA wal_checkpoint(FULL) flushes WAL to main database
2025-10-25 16:37:54 -07:00
Steve Yegge
de03466da9 Fix bd-143: Prevent daemon auto-sync from wiping out issues.jsonl with empty database
- Added safety check to exportToJSONLWithStore (daemon path)
- Refuses to export 0 issues over non-empty JSONL file
- Added --force flag to override safety check when intentional
- Added test coverage for empty database export protection
- Prevents data loss when daemon has wrong/empty database

Amp-Thread-ID: https://ampcode.com/threads/T-de18e0ad-bd17-46ec-994b-0581e257dcde
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 16:36:18 -07:00
Steve Yegge
3241b7fbfc updated bd-135 epic 2025-10-25 14:29:33 -07:00
Steve Yegge
9a370b5b3c Fix gosec security warnings (bd-57)
- Changed file permissions from 0644 → 0600 for JSONL exports and config files
- Changed directory permissions from 0755 → 0750 in all test code
- Updated .golangci.yml with proper exclusions for false positives
- Reduced gosec warnings from 102 to 22 (all remaining are acceptable)

Closes bd-57

Amp-Thread-ID: https://ampcode.com/threads/T-f754d957-9e42-4e74-861e-57235c7e6436
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 13:50:32 -07:00
Steve Yegge
47c915ef10 Fix goconst linter warnings by converting repeated strings to constants
- Added testUserAlice constant for 'alice' in test files
- Added windowsOS constant for 'windows' in test files
- Added testIssueBD1/testIssueBD2 constants for 'bd-1'/'bd-2' in test files
- Added testVersion100 constant for '1.0.0' in version tests
- Added testIssueCustom1 constant for 'custom-1' in lazy init tests

Closes bd-54

Amp-Thread-ID: https://ampcode.com/threads/T-0a4e5d44-2d95-4948-8f4a-d8facf8657c7
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 13:33:51 -07:00
Steve Yegge
94fb9fa531 Refactor high-complexity test functions (gocyclo)
Extracted helper structs for 5 complex test functions, reducing cyclomatic complexity from 31-35 to <10:

- TestLibraryIntegration: integrationTestHelper with create/assert methods
- TestExportImport: exportImportHelper with JSONL encoding/validation
- TestListCommand: listTestHelper with search and assertions
- TestGetEpicsEligibleForClosure: epicTestHelper with epic-specific queries
- TestCreateIssues: createIssuesTestHelper with batch creation helpers

All tests pass. Closes bd-55.

Amp-Thread-ID: https://ampcode.com/threads/T-39807355-8790-4646-a98d-d40472e1bd2c
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 13:20:16 -07:00
Steve Yegge
f6e37bd25d Refactor DeleteIssues to reduce complexity (37 → <10)
Extracted 10 helper functions:
- buildIDSet: ID deduplication
- resolveDeleteSet: Mode routing (cascade/force/validate)
- expandWithDependents: Recursive dependent collection
- validateNoDependents: Dependency validation
- checkSingleIssueValidation: Per-issue dependent check
- trackOrphanedIssues: Force-mode orphan tracking
- collectOrphansForID: Per-issue orphan collection
- buildSQLInClause: SQL placeholder generation
- populateDeleteStats: Dry-run statistics
- executeDelete: Actual deletion

Code review fix:
- Added rows.Err() check to catch iterator errors

Ref: bd-55
2025-10-25 12:51:29 -07:00
Steve Yegge
5b99e56941 Refactor tryAutoStartDaemon to reduce complexity (34 → <10)
Extracted 7 helper functions:
- debugLog: Centralized debug logging
- isDaemonHealthy: Fast-path health check
- acquireStartLock: Lock acquisition with wait/retry
- handleStaleLock: Stale lock detection
- handleExistingSocket: Socket cleanup/validation
- determineSocketMode: Global vs local daemon logic
- startDaemonProcess: Process spawning and readiness
- setupDaemonIO: I/O redirection

Ref: bd-55
2025-10-25 12:35:32 -07:00
Steve Yegge
36c1c648fc Refactor TestLabelCommands and TestReopenCommand to reduce complexity
- TestLabelCommands: 67 → <10 using labelTestHelper
- TestReopenCommand: 37 → <10 using reopenTestHelper
- All tests pass
- Progress on bd-55

Amp-Thread-ID: https://ampcode.com/threads/T-0a5a623d-42f0-4b36-96ed-809285a748cb
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 11:27:24 -07:00
Steve Yegge
d85549d16c Refactor issueDataChanged to reduce cyclomatic complexity (bd-55)
- Extract field comparison logic into fieldComparator struct
- Reduce complexity from 39 to 11
- Improve code organization and testability
- All tests passing

Amp-Thread-ID: https://ampcode.com/threads/T-4d8cdee6-84e8-4348-ad30-9e59fb3e30cf
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 10:44:35 -07:00
Steve Yegge
d2084dc3af Fix nil pointer crash in bd reopen command (bd-133)
- Add daemon RPC support to reopen command
- Check daemonClient != nil first, use RPC if available
- Fall back to direct store access with nil check
- Reopened bd-55 for remaining cyclomatic complexity work

Amp-Thread-ID: https://ampcode.com/threads/T-2ea7e226-4672-4a49-96b4-81ab5cf953cd
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 10:39:45 -07:00
Steve Yegge
fe30e0c527 Refactor importIssuesCore to reduce complexity (bd-55)
Reduced cyclomatic complexity from 71 to ~10 by extracting 7 phase functions:
- getOrCreateStore: Store initialization
- handlePrefixMismatch: Prefix validation/renaming
- handleCollisions: Collision detection/resolution
- upsertIssues: Issue creation/updates
- importDependencies: Dependency imports (optimized with set-based deduplication)
- importLabels: Label imports
- importComments: Comment imports (fixed idempotency bug)

Additional improvements:
- Fixed comment deduplication to use author+text only (not timestamp)
- Optimized dependency imports to fetch once per issue (not per dependency)
- Improved error messages to reference CLI flags
- Renamed importIssues -> upsertIssues for clarity

Main function reduced from 317 lines to 50 lines. All tests pass.

Amp-Thread-ID: https://ampcode.com/threads/T-aa67a4e5-b35d-4ba6-a954-5d9ff86c15bf
Co-authored-by: Amp <amp@ampcode.com>
2025-10-25 10:26:56 -07:00
Steve Yegge
b0b9c37f6b Fix PyPI publish workflow to run independently of GoReleaser
- Add 'if: always()' to publish-pypi job so it runs even if goreleaser fails
- Remove 'go test' from .goreleaser.yml since CI already runs tests
- This ensures MCP server gets published even if binary release has issues
2025-10-24 22:38:42 -07:00
Steve Yegge
79a182bfc1 Add 0.16.0 and 0.17.0 release notes 2025-10-24 22:38:04 -07:00
Steve Yegge
667d41e9d4 chore: Bump version to 0.17.0
Updated all component versions:
- bd CLI: 0.16.0 → 0.17.0
- Plugin: 0.16.0 → 0.17.0
- MCP server: 0.16.0 → 0.17.0
- Documentation: 0.16.0 → 0.17.0

Generated by scripts/bump-version.sh
2025-10-24 22:36:06 -07:00
Steve Yegge
c9c4f19a56 Add bd-132: GH#146 terminal color issue
Amp-Thread-ID: https://ampcode.com/threads/T-2939ba4d-023a-4a31-bdca-f36f48c211ee
Co-authored-by: Amp <amp@ampcode.com>
2025-10-24 22:35:13 -07:00
Steve Yegge
afe6fad6e4 Add automatic git hooks installation prompt to bd init
- Prompts user to install hooks on first init if in git repo
- Auto-installs with Y/n prompt (defaults to yes)
- Skips prompt if hooks already installed
- Detects bd hooks by signature comment in files
2025-10-24 22:22:28 -07:00
Steve Yegge
0344e1f08b Fix bd-51: Add git hooks to eliminate auto-flush race condition
- Added --flush-only flag to bd sync command
- Created pre-commit hook to flush pending changes before commit
- Created post-merge hook to import changes after pull/merge
- Added install script for easy setup
- Updated AGENTS.md with git hooks workflow
- Resolves race condition where daemon auto-flush fires after commit

Amp-Thread-ID: https://ampcode.com/threads/T-00b80d3a-4194-4c75-a60e-25a318cf9f91
Co-authored-by: Amp <amp@ampcode.com>
2025-10-24 22:17:06 -07:00
Steve Yegge
c87f9007a5 bd sync: close bd-65 and bd-67 2025-10-24 22:10:29 -07:00
Steve Yegge
98da376f7b Fix golangci-lint CI: add config version and upgrade action to v8 2025-10-24 21:59:33 -07:00
Steve Yegge
3f80d850c9 bd sync: 2025-10-24 21:52:11 2025-10-24 21:52:11 -07:00
Steve Yegge
b405eefbe0 Fix daemon auto-start reliability
- Run initial sync in background so daemon becomes responsive immediately
- Skip daemon-running check for forked child process (BD_DAEMON_FOREGROUND=1)
- Fix PID file conflict between acquireDaemonLock and runDaemonLoop
- Daemon now starts reliably even with slow/failing git pulls

Fixes issue where daemon would timeout during auto-start because it was
blocked on git pull in the initial sync cycle. Now the RPC server starts
immediately and sync runs asynchronously.

Amp-Thread-ID: https://ampcode.com/threads/T-57f3c00a-02b4-4878-adba-c7d1649759b4
Co-authored-by: Amp <amp@ampcode.com>
2025-10-24 21:51:30 -07:00
Steve Yegge
b0259fe36f Add bd-137: Fix dependency timestamp churn during auto-import 2025-10-24 21:40:05 -07:00
Steve Yegge
0f49d30535 Fix lint: mark unused test parameter with underscore 2025-10-24 21:34:56 -07:00
Steve Yegge
1a9258ce4f Remove deprecated bd repos command
Amp-Thread-ID: https://ampcode.com/threads/T-3fe46a3f-979f-48dd-9bb3-ee0b9fde46c2
Co-authored-by: Amp <amp@ampcode.com>
2025-10-24 19:49:16 -07:00
Steve Yegge
94212a5922 Improve test coverage for bd-136
Added tests for internal/rpc and internal/storage/sqlite:

RPC tests (+5.8% coverage: 58.0% → 63.8%):
- TestCloseIssue: Cover handleClose (was 0%)
- TestReposStats: Cover handleReposStats (was 0%)
- TestReposClearCache: Cover handleReposClearCache (was 0%)
- TestEpicStatus: Cover handleEpicStatus (was 0%)

Storage tests (+2.6% coverage: 62.2% → 64.8%):
- Created epics_test.go with TestGetEpicsEligibleForClosure
- TestUpdateIssueValidation: validateIssueType, validateEstimatedMinutes
- TestGetAllConfig, TestDeleteConfig, TestIsClosed

Overall coverage: 48.7% → 50.7% (+2.0%)

Progress on bd-136: Achieve 75% test coverage across codebase

Amp-Thread-ID: https://ampcode.com/threads/T-16b56923-6fbc-45db-b68b-315567849ec6
Co-authored-by: Amp <amp@ampcode.com>
2025-10-24 19:45:47 -07:00
Steve Yegge
d0f6524c90 Add test coverage improvements (+2.7% overall)
- cmd/bd: 20.4% → 21.1% (+0.7%)
  - Added tests for helper functions: isBoundary, isNumeric,
    extractPrefix, getPrefixList, parseLabelArgs, replaceBoundaryAware
  - New files: helpers_test.go, simple_helpers_test.go

- internal/rpc: 46.6% → 58.0% (+11.4%)
  - Added tests for 11 RPC client methods: SetTimeout, Show, Ready,
    Stats, AddDependency, RemoveDependency, AddLabel, RemoveLabel,
    Batch, ReposList, ReposReady
  - New file: coverage_test.go

Overall coverage: 46.0% → 48.7%
Target: 75% (bd-136)

Amp-Thread-ID: https://ampcode.com/threads/T-a7ce061d-5a77-4654-a931-0a4f24aee192
Co-authored-by: Amp <amp@ampcode.com>
2025-10-24 17:06:22 -07:00
Steve Yegge
9111d1e573 Add test coverage for compact, ready, and dep commands
- Add comprehensive tests for cmd/bd/compact.go
  - Test dry run, validation, stats, progress bar, uptime formatting
  - Test compaction eligibility checks

- Add comprehensive tests for cmd/bd/ready.go
  - Test ready work filtering by priority, assignee, limit
  - Test blocking dependencies exclusion
  - Test in-progress issues inclusion

- Add comprehensive tests for cmd/bd/dep.go
  - Test dependency add/remove operations
  - Test all dependency types (blocks, related, parent-child, discovered-from)
  - Test cycle detection and prevention

Coverage improved from 45.6% to 46.0% overall
cmd/bd coverage improved from 20.0% to 20.4%

Amp-Thread-ID: https://ampcode.com/threads/T-0707eb82-f56e-4b2d-b64a-f18cc5bc7421
Co-authored-by: Amp <amp@ampcode.com>
2025-10-24 16:35:40 -07:00
Steve Yegge
0b154afe89 fix: let golangci-lint-action choose compatible version 2025-10-24 16:22:39 -07:00
Steve Yegge
841ff3df9c fix: use golangci-lint-action@v6 for v1.x compatibility 2025-10-24 16:17:24 -07:00
Steve Yegge
913c661d05 fix: downgrade golangci-lint to v1.63.4 for config compatibility 2025-10-24 15:38:34 -07:00