Commit Graph

483 Commits

Author SHA1 Message Date
Steve Yegge
e3ff12448f Fix: RemapCollisions deletes existing issue dependencies (GH #120, bd-56)
Bug: updateDependencyReferences() was incorrectly updating ALL dependencies
in the database during collision resolution with --resolve-collisions,
including dependencies belonging to existing issues.

Root cause: The function checked if dep.IssueID was in idMapping keys
(old imported IDs like 'bd-1'), but those are also the IDs of existing
database issues. This caused existing dependencies to be incorrectly
modified or deleted.

Fix: Changed logic to only update dependencies where IssueID is in
idMapping VALUES (new remapped IDs like 'bd-295'). This ensures only
dependencies from remapped issues are updated, not existing ones.

During normal import flow, this is effectively a no-op since imported
dependencies haven't been added to the database yet when RemapCollisions
runs (they're added later in Phase 5 of import_shared.go).

Changes:
- Updated updateDependencyReferences() in collision.go to build a set
  of new remapped IDs and only update dependencies with those IDs
- Added comprehensive documentation explaining the correct semantics
- Added regression tests: TestRemapCollisionsRemapsImportedNotExisting
  and TestRemapCollisionsDoesNotUpdateNonexistentDependencies
- Skipped 3 tests that expected the old buggy behavior with clear
  notes about why they need to be rewritten

Real-world impact: In one case, 125 dependencies were incorrectly
deleted from 157 existing issues during collision resolution.

Fixes https://github.com/steveyegge/beads/issues/120
Fixes bd-56
2025-10-23 10:25:13 -07:00
Steve Yegge
e4b0820449 Fix: Preserve timestamps during import (GH-121)
- Change validateBatchIssues() to only set timestamps if IsZero()
- Preserves historical timestamps from external systems (Jira, GitHub)
- Fixes dirty git repo after importing unchanged JSONL
- New issues still get current timestamps as before
- Add daemon.lock to .gitignore

Closes bd-55
Fixes #121

Amp-Thread-ID: https://ampcode.com/threads/T-e53c4a96-38dd-440a-9b8d-824992d33a40
Co-authored-by: Amp <amp@ampcode.com>
2025-10-23 09:40:08 -07:00
spm1001
bdaf82026a Enhance Claude Code skill with real-world usage patterns (#116)
* Update skill installation path and document new features

Installation path changes:
- Update from ~/.claude/skills/bd to bd-issue-tracking
- Matches internal skill name for consistency with other skills

Documentation additions:
- Add 3 new reference files to documentation list
- Document compaction survival patterns (critical for Claude Code)
- Mention self-check checklists and quality guidelines

This prepares the README for upcoming skill content improvements.

* Add new reference files for enhanced skill guidance

New reference documentation:

1. ISSUE_CREATION.md - When to ask vs create issues
   - Decision criteria for knowledge work vs technical work
   - Issue quality guidelines and best practices
   - Design vs acceptance criteria guidance
   - Self-check questions for well-scoped issues

2. RESUMABILITY.md - Making issues resumable across sessions
   - Patterns for complex technical work with APIs
   - Working code examples and API response samples
   - When enhanced documentation matters vs simple descriptions
   - Critical for multi-session work and crash recovery

3. STATIC_DATA.md - Using bd for reference databases
   - Alternative use case beyond work tracking
   - Glossaries and terminology management
   - Dual format patterns (database + markdown)
   - When bd helps vs when simpler formats suffice

These additions emerged from real-world usage patterns and enable
Claude to make better decisions about issue structure and resumability.

* Enhance existing skill files with real-world usage patterns

SKILL.md major enhancements (~194 net lines added):
- Add "Test Yourself" decision framework with self-check questions
- Document compaction survival patterns (critical for Claude Code)
- Add Notes Quality Self-Check (future-me test, stranger test)
- Session Start Checklist with copy-paste templates
- Field Usage Reference table (when to use each bd field)
- Progress Checkpointing triggers and patterns
- Issue Creation Checklist with quality self-checks
- Enhanced session handoff protocols

WORKFLOWS.md enhancements (~114 lines added):
- Session handoff workflow with detailed checklists
- Collaborative handoff between Claude and user
- Compaction survival workflow
- Notes format guidelines (current state, not cumulative)
- Session start checklist expansion

BOUNDARIES.md updates (~49 lines removed):
- Streamlined content (moved detailed workflows to WORKFLOWS.md)
- Retained core decision criteria
- Improved examples and integration patterns

CLI_REFERENCE.md minor updates:
- Additional command examples
- Clarified flag usage

These improvements emerged from extensive real-world usage, particularly
around crash recovery, compaction events, and multi-session workflows.
The additions make the skill more practical for autonomous agent use.
2025-10-23 09:26:30 -07:00
Steve Yegge
5bc298a175 Add bd-74: Investigate jujutsu integration 2025-10-23 09:24:17 -07:00
Steve Yegge
2807697e9b Upgrade database to v0.14.0 2025-10-23 09:21:32 -07:00
Steve Yegge
603367676c docs: Update CHANGELOG for v0.14.0 release 2025-10-22 23:16:20 -07:00
Steve Yegge
09a9865087 chore: Bump version to 0.14.0
Updated all component versions:
- bd CLI: 0.12.0 → 0.14.0
- Plugin: 0.12.0 → 0.14.0
- MCP server: 0.12.0 → 0.14.0
- Documentation: 0.12.0 → 0.14.0

Generated by scripts/bump-version.sh
2025-10-22 23:15:18 -07:00
Steve Yegge
5a6177b4bc Fix bd-73: Add git worktree detection and warnings
- Implement robust worktree detection using git-dir vs git-common-dir comparison
- Add prominent warning when daemon mode is active in a worktree
- Warn in 3 places: initial connection, auto-start, and daemon start command
- Show shared database path and clarify BEADS_AUTO_START_DAEMON behavior
- Document limitations and solutions in README.md and AGENTS.md
- Add comprehensive tests for detection and path truncation

Fixes #55

Amp-Thread-ID: https://ampcode.com/threads/T-254eb9e3-1a42-42d7-afdf-b7ca2d2dcb8b
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 23:05:00 -07:00
Steve Yegge
3fae41cb35 Add UnderlyingConn(ctx) for safer scoped DB access
- Add UnderlyingConn method to Storage interface
- Implement in SQLiteStorage for scoped connection access
- Useful for migrations and DDL operations
- Add comprehensive tests for basic access, DDL, context cancellation, and concurrent connections
- Closes bd-66, bd-22, bd-24, bd-38, bd-39, bd-56

Amp-Thread-ID: https://ampcode.com/threads/T-e47963af-4ace-4914-a0ae-4737f77be6ff
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 22:05:58 -07:00
Steve Yegge
fb64a33b99 Close completed and irrelevant issues (bd-23, bd-25, bd-60-62) 2025-10-22 21:38:32 -07:00
Steve Yegge
3601496aee fix: Remove daemon.lock from git tracking and add to .gitignore
Amp-Thread-ID: https://ampcode.com/threads/T-9f74f16c-82b7-4778-af41-2689e17a51ca
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 21:24:59 -07:00
Steve Yegge
23c150f718 Merge PR #110: Fix regression in Nix Flake
Fixes missing ./default.nix path in flake.nix and adds smoke test to prevent future regressions.

Co-authored-by: zgagnon <zgagnon@users.noreply.github.com>
2025-10-22 21:12:16 -07:00
Steve Yegge
a7d6ffcb2d Add lifecycle safety docs and tracking for UnderlyingDB() (bd-64)
- Added comprehensive documentation with 5 safety rules and best practices
- Added atomic.Bool closed field for lifecycle tracking
- Added IsClosed() method to check storage state
- All existing tests pass with -race flag

Amp-Thread-ID: https://ampcode.com/threads/T-e10b5206-4acd-4b9c-915d-423f958e350b
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 20:29:31 -07:00
Steve Yegge
f7a92667fd Close completed issues: bd-57, bd-19, bd-69
- bd-57: VC successfully ported to use beads as Go library
- bd-19: Compact command now works through daemon RPC interface
- bd-69: MCP tests fixed - bd_client.py handles array responses
- bd-56: Downgraded to P3 (atomic merge transactions)

All major P1 blockers resolved except bd-64 (lifecycle safety docs/tests)

Amp-Thread-ID: https://ampcode.com/threads/T-c2c18266-ccf2-4615-a2f1-be134e8f1c0d
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 20:06:20 -07:00
Steve Yegge
bfd6aa4336 Update EXTENDING.md with UnderlyingDB() documentation
- Add recommended UnderlyingDB() usage pattern with examples
- Document safety warnings (never close, no pool changes, keep txns short)
- Add when to use UnderlyingDB() vs sql.Open() guidance
- Update VC example to show embedding pattern with UnderlyingDB()
- Cross-reference bd-64 safety requirements

Closes bd-65

Amp-Thread-ID: https://ampcode.com/threads/T-c2c18266-ccf2-4615-a2f1-be134e8f1c0d
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 19:43:54 -07:00
Zoe Gagnon
474f62c6f2 Fix regression in Nix Flake
In PR #105, a regression was introduced into the nix flake
which disabled consumers from access the package.

This pr fixes that regression.

Additionally adds a nix smoke test for a backstop against this in the future
2025-10-22 22:24:23 -04:00
Steve Yegge
73bacf4e95 Update issues: close bd-71 (GH #107 already fixed)
Amp-Thread-ID: https://ampcode.com/threads/T-b76d6a2f-1114-4a6a-9c92-29de46a8c195
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 19:23:36 -07:00
Steve Yegge
c4a794f88b docs: Update RELEASING.md with complete release checklist
- Add daemon kill step before build/test
- Add local Go install update step
- Add TMPDIR=/tmp to all go commands
- Update Homebrew install instructions with --build-from-source
- Add git config setup for homebrew-beads repo
2025-10-22 18:31:43 -07:00
Steve Yegge
d0bd0a7e0d chore: Bump version to 0.12.0
Updated all component versions:
- bd CLI: 0.11.0 → 0.12.0
- Plugin: 0.11.0 → 0.12.0
- MCP server: 0.11.0 → 0.12.0
- Documentation: 0.11.0 → 0.12.0

Generated by scripts/bump-version.sh
2025-10-22 18:24:27 -07:00
Steve Yegge
e62ea7f9d7 Add --title flag to bd create command
Agents often try to use --title flag instead of positional argument.
Now accepts both:
- --title alone
- positional argument alone
- both if they match (fails if different)

Amp-Thread-ID: https://ampcode.com/threads/T-43a84f3d-8342-425b-885d-bcd5aefd951a
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 18:06:55 -07:00
Steve Yegge
ee52316f90 Fix GH #103: Add --rename-on-import flag to bd sync command
- bd sync now accepts --rename-on-import flag
- Flag is passed through to import command
- Fixes error where prefix mismatch suggested non-existent flag
- Closes bd-70

Amp-Thread-ID: https://ampcode.com/threads/T-b76d6a2f-1114-4a6a-9c92-29de46a8c195
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 17:59:06 -07:00
Steve Yegge
935470a3d8 Fix MCP close method signature bug (GH #107, bd-67)
- Fix BdDaemonClient.close() to accept issue_id and reason parameters
- Remove uv.lock from repo

Amp-Thread-ID: https://ampcode.com/threads/T-0017f48d-605c-410f-9a77-db62153c9357
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 17:53:28 -07:00
Steve Yegge
42762188ed Fix MCP close tool method signature error (GH #107)
Renamed BdDaemonClient.close() cleanup method to cleanup() to eliminate
method name collision with async close(params) method for closing issues.

Root cause: Python method resolution meant the non-async close(self)
cleanup method was shadowing the async close(self, params) method that
closes issues, causing 'takes 1 positional argument but 2 were given'.

Changes:
- bd_daemon_client.py: Renamed close() -> cleanup()
- server.py: Updated cleanup code to call cleanup() instead of close()
- test_lifecycle.py: Updated tests to use cleanup()

All close-related tests pass. Fixes GitHub issue #107.
Tracked in bd-67 (closed).
2025-10-22 17:43:11 -07:00
Steve Yegge
a777e97287 bd sync: 2025-10-22 17:37:45 2025-10-22 17:37:45 -07:00
Steve Yegge
da521d3471 Update issue tracker: add UnderlyingDB safety and docs issues
Filed during code review of UnderlyingDB() implementation:
- bd-64: Add lifecycle safety docs and tests
- bd-65: Update EXTENDING.md with UnderlyingDB() usage
- bd-66: Consider adding UnderlyingConn() for safer scoped access

Also updated bd-57 status to in_progress.

Amp-Thread-ID: https://ampcode.com/threads/T-a6715beb-fe92-4dee-b931-3c9327124875
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 17:24:15 -07:00
Steve Yegge
6829372c39 Add UnderlyingDB() method for extension database access
Implements database platform layer for extensions like VC to create
their own tables in the same SQLite database.

Changes:
- Add UnderlyingDB() *sql.DB to Storage interface
- Implement in SQLiteStorage to expose underlying connection
- Add comprehensive test suite (5 tests, -race clean)
- Tests cover: basic access, extension tables, concurrency,
  lifecycle safety, and transaction behavior

This allows VC to host its executor_instances and other tables
alongside beads core tables with proper FK enforcement.

Related issues: bd-57, bd-64, bd-65, bd-66

Amp-Thread-ID: https://ampcode.com/threads/T-a6715beb-fe92-4dee-b931-3c9327124875
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 17:19:57 -07:00
Joshua Park
a689c66f77 Fix nil pointer dereference crash in bd sync command (#108)
The sync command was crashing at sync.go:245 with a nil pointer
dereference when running in direct mode (without daemon). The
exportToJSONL function attempted to use store.SearchIssues()
without first ensuring the store was initialized.

This fix adds a call to ensureStoreActive() before accessing
the store, matching the pattern used by other commands like
export. This ensures the store is properly initialized whether
running with or without the daemon.

Fixes #106

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
2025-10-22 15:50:05 -07:00
Steve Yegge
67cd529f72 Update issue tracker state 2025-10-22 15:49:57 -07:00
Steve Yegge
5e7b3aa43a Add Beads library API for Go integration
Expose full Storage interface and all types through public beads.go API,
enabling external Go projects (like VC) to import Beads directly instead
of spawning CLI processes.

Changes:
- Expanded beads.go with all public types (Issue, Dependency, Comment, etc.)
- Added all constants (Status, IssueType, DependencyType, EventType)
- Created comprehensive integration tests (beads_integration_test.go)
- Added library usage example at examples/library-usage/
- Documented library integration in README.md

Test coverage: 96.4% on public API, 14 integration tests, all passing.

Closes bd-58, bd-59

Amp-Thread-ID: https://ampcode.com/threads/T-f0093c79-7422-45e2-b0ed-0ddfebc9ffea
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 15:49:40 -07:00
Steve Yegge
df36c11fe3 Sync beads database before merge
Amp-Thread-ID: https://ampcode.com/threads/T-dc82df76-5eea-407c-bfdb-86270a028621
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 14:30:04 -07:00
Steve Yegge
f62e640add Add Beads Library Integration epic (bd-58) with 4 phased child tasks
- bd-59: Phase 1 - Add Beads Dependency (Non-Breaking)
- bd-60: Phase 2 - Implement VCStorage Wrapper
- bd-61: Phase 3 - Migration Path & Database Schema Alignment
- bd-62: Phase 4 - Gradual Cutover & Production Rollout

This epic addresses the ~3000 lines of duplicated SQLite code and establishes
a clean architecture where VC extends Beads via wrapper without modifying the
Beads library. Estimated effort: 3-4 sprints, Priority: P2
2025-10-22 14:14:28 -07:00
Steve Yegge
e291f464ee Fix bd-54: Prevent multiple daemon instances via file locking
- Implemented daemon.lock using flock (Unix) and LockFileEx (Windows)
- Lock acquired before PID file, held for daemon lifetime
- Eliminates race conditions in concurrent daemon starts
- Backward compatible: falls back to PID check for old daemons
- Updated isDaemonRunning() to check lock availability
- All tests pass including new lock and backward compatibility tests

Amp-Thread-ID: https://ampcode.com/threads/T-0e2627f4-03f9-4024-bb4b-21d23d296300
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 13:59:58 -07:00
Steve Yegge
d1d3fcdf02 Rename issues.jsonl → beads.jsonl (fresh start after test pollution)
Amp-Thread-ID: https://ampcode.com/threads/T-b160879b-cb6f-4e4c-9348-abcc69ee5048
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 12:40:14 -07:00
Steve Yegge
1363ac74c8 Re-add .beads/issues.jsonl with clean state 2025-10-22 12:32:26 -07:00
Steve Yegge
edb6016949 Stop tracking .beads/issues.jsonl - reset due to test pollution 2025-10-22 12:30:34 -07:00
Steve Yegge
d9e1ee9dd6 Make merge command idempotent for safe retry after partial failures (bd-26)
- Added mergeResult struct to track operations (added vs skipped)
- Check if source issues already closed before attempting to close
- Track dependencies migrated vs already existed
- Count text references updated
- Display detailed breakdown of operations in output
- Updated help text to clarify idempotent behavior
- Added comprehensive tests for idempotent retry scenarios
2025-10-22 12:24:08 -07:00
Steve Yegge
bafc1a9ded Close bd-16, merge bd-53 into bd-26, start bd-26
- Close bd-16: transaction support superseded by idempotency approach
- Merge duplicate bd-53 into bd-26
- Start bd-26: Make merge command idempotent

Amp-Thread-ID: https://ampcode.com/threads/T-95a37593-fd67-4e99-bc84-ace580b4776d
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 11:57:16 -07:00
Steve Yegge
4ef995b0e4 Document merge command and AI duplicate detection workflow (bd-29)
- Add comprehensive merge command documentation to README.md
- Add AI agent duplicate detection workflow to AGENTS.md
- Include command syntax, examples, and best practices
- Close bd-29

Amp-Thread-ID: https://ampcode.com/threads/T-95a37593-fd67-4e99-bc84-ace580b4776d
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 11:48:12 -07:00
Steve Yegge
a7ce986555 Update issues: closed bd-18 2025-10-22 11:31:14 -07:00
Zoe Gagnon
fb2881c47b Break out nix package definition into a default.nix (#105)
* Fix autostart test to work in nix sandbox

* Break out a default.nix to make consuming this package easier

The flake is great for local development, but creates overhead and
duplication when pulling it in on another machine. With the default.nix,
the flake continues to work as before, but consumers can callPackage directly
with their own nixpkgs.

* Break out a default.nix to make consuming this package easier

The flake is great for local development, but creates overhead and
duplication when pulling it in on another machine. With the default.nix,
the flake continues to work as before, but consumers can callPackage directly
with their own nixpkgs.
2025-10-22 11:30:57 -07:00
Steve Yegge
7e2acb0237 Fix flaky compactor tests due to timestamp race condition
The createClosedIssue helper was setting ClosedAt to time.Now(), but the
eligibility check uses '<= datetime(now, -0 days)'. This created a race
condition where if nanoseconds elapsed between issue creation and the
query, the issue would fail eligibility checks.

Changed to now.Add(-1*time.Second) to ensure issues are always eligible
when compact_tier1_days is set to 0 for testing.

Fixes bd-18

Amp-Thread-ID: https://ampcode.com/threads/T-bc303dd9-f0e7-4d52-8908-e433d429ac4a
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 10:00:36 -07:00
Steve Yegge
a578e16de3 Remove critical warning banners - issues fixed in 0.11.0 2025-10-22 01:22:59 -07:00
Steve Yegge
2a032ae3ba chore: Bump version to 0.11.0
Updated all component versions:
- bd CLI: 0.10.1 → 0.11.0
- Plugin: 0.10.1 → 0.11.0
- MCP server: 0.10.1 → 0.11.0
- Documentation: 0.10.1 → 0.11.0

Generated by scripts/bump-version.sh
2025-10-22 01:09:25 -07:00
Steve Yegge
37cd5a5330 Update CHANGELOG for 0.11.0 release 2025-10-22 01:09:14 -07:00
Steve Yegge
cbe5daae1f Close completed merge tasks and test pollution issues 2025-10-22 01:08:24 -07:00
Steve Yegge
47b892731a Auto-sync after renumber: remove deleted issues, add comment
Amp-Thread-ID: https://ampcode.com/threads/T-5ad38d33-28ba-4f47-997a-b0d7e0331c26
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 00:56:33 -07:00
Steve Yegge
6571e31063 Renumber issues from bd-1070 to bd-26
Counter now reset to 26. Next issue will be bd-27 instead of bd-1071.

Amp-Thread-ID: https://ampcode.com/threads/T-5ad38d33-28ba-4f47-997a-b0d7e0331c26
Co-authored-by: Amp <amp@ampcode.com>
2025-10-22 00:55:04 -07:00
Steve Yegge
d665882041 Mark bd-19 as open 2025-10-22 00:50:15 -07:00
Steve Yegge
3b782a8e24 Delete test pollution and renumber issues (151→55) 2025-10-22 00:48:46 -07:00
Steve Yegge
75844586ce Update issues: close bd-1 2025-10-22 00:45:08 -07:00