Files
beads/cmd/bd/create_test.go
Peter Chanthamynavong d371baf2ca feat(dates): add --due and --defer timestamp options with natural language parsing (#847)
* feat(dates): add due date schema and --due flag

- Add due_at and defer_until columns to issues table via migration 035
- Implement --due flag on create command with ISO date parsing
- Extend RPC protocol and daemon to pass DueAt from CLI to storage
- Display DueAt and DeferUntil in show command output
- Update Issue type with new date fields

Users can now set due dates when creating issues, enabling deadline-based
task management.

* feat(dates): add compact duration parser (+6h, +1d, +2w)

- Create internal/timeparsing package with layered parser architecture
- Implement parseCompactDuration with regex pattern [+-]?\d+[hdwmy]
- Add comprehensive test suite (22 cases) for duration parsing
- Integrate into create.go with fallback to ISO format

Supports hours (h), days (d), weeks (w), months (m), and years (y).
Negative values allowed for past dates.

* feat(dates): add NLP parsing for natural language dates

Integrate olebedev/when library for natural language time expressions.
The layered parser now handles: compact duration → absolute formats → NLP.

Changes:
- Add olebedev/when dependency for NLP parsing
- Implement ParseNaturalLanguage and ParseRelativeTime functions
- Reorder layers: absolute formats before NLP to avoid misinterpretation
- Simplify create.go to use unified ParseRelativeTime
- Add comprehensive NLP test coverage (22 test cases)

Supports: tomorrow, next monday, in 3 days, 3 days ago

* feat(dates): add --defer flag to create/update/defer commands

Add time-based deferral support alongside existing status-based defer.
Issues can now be hidden from bd ready until a specific time.

Changes:
- Add --defer flag to bd create (sets defer_until on creation)
- Add --due and --defer flags to bd update (modify existing issues)
- Add --until flag to bd defer (combines status=deferred with defer_until)
- Add DueAt/DeferUntil fields to UpdateArgs in protocol.go

Supports: +1h, tomorrow, next monday, 2025-01-15

* feat(dates): add defer_until filtering to ready command

Add time-based deferral support to bd ready:

- Add --include-deferred flag to show issues with future defer_until
- Filter out issues where defer_until > now by default
- Update undefer to clear defer_until alongside status change
- Add IncludeDeferred to WorkFilter and RPC ReadyArgs

Part of GH#820: Relative Date Parsing (Phase 5)

* feat(dates): add polish and tests for relative date parsing

Add user-facing warnings when defer date is in the past to help catch
common mistakes. Expand help text with format examples and document
the olebedev/when September parsing quirk.

Tests:
- TestCreateSuite/WithDueAt, WithDeferUntil, WithBothDueAndDefer
- TestReadyWorkDeferUntil (ExcludesFutureDeferredByDefault, IncludeDeferredShowsAll)

Docs:
- CLAUDE.md quick reference updated with new flags
- Help text examples for --due, --defer on create/update

Closes: Phase 6 of beads-820-relative-dates spec

* feat(list): add time-based query filters for defer/due dates

Add --deferred, --defer-before, --defer-after, --due-before, --due-after,
and --overdue flags to bd list command. All date filters now support
relative time expressions (+6h, tomorrow, next monday) via the
timeparsing package.

Filters:
- --deferred: issues with defer_until set
- --defer-before/after: filter by defer_until date range
- --due-before/after: filter by due_at date range
- --overdue: due_at in past AND status != closed

Existing date filters (--created-after, etc.) now also support relative
time expressions through updated parseTimeFlag().

* build(nix): update vendorHash for olebedev/when dependency

The olebedev/when library was added for natural language date parsing
(GH#820). This changes go.sum, requiring an updated vendorHash in the
Nix flake configuration.
2026-01-01 20:06:13 -08:00

652 lines
16 KiB
Go

package main
import (
"context"
"path/filepath"
"testing"
"time"
"github.com/steveyegge/beads/internal/types"
)
func TestCreateSuite(t *testing.T) {
tmpDir := t.TempDir()
testDB := filepath.Join(tmpDir, ".beads", "beads.db")
s := newTestStore(t, testDB)
ctx := context.Background()
t.Run("BasicIssue", func(t *testing.T) {
issue := &types.Issue{
Title: "Test Issue",
Priority: 1,
IssueType: types.TypeBug,
Status: types.StatusOpen,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
issues, err := s.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
t.Fatalf("failed to search issues: %v", err)
}
if len(issues) == 0 {
t.Fatal("expected at least 1 issue, got 0")
}
// Find our issue
var created *types.Issue
for _, iss := range issues {
if iss.Title == "Test Issue" {
created = iss
break
}
}
if created == nil {
t.Fatal("could not find created issue")
}
if created.Title != "Test Issue" {
t.Errorf("expected title 'Test Issue', got %q", created.Title)
}
if created.Priority != 1 {
t.Errorf("expected priority 1, got %d", created.Priority)
}
if created.IssueType != types.TypeBug {
t.Errorf("expected type bug, got %s", created.IssueType)
}
})
t.Run("WithDescription", func(t *testing.T) {
issue := &types.Issue{
Title: "Issue with desc",
Description: "This is a description",
Priority: 2,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
issues, err := s.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
t.Fatalf("failed to search issues: %v", err)
}
// Find our issue
var created *types.Issue
for _, iss := range issues {
if iss.Title == "Issue with desc" {
created = iss
break
}
}
if created == nil {
t.Fatal("could not find created issue")
}
if created.Description != "This is a description" {
t.Errorf("expected description, got %q", created.Description)
}
})
t.Run("WithDesignAndAcceptance", func(t *testing.T) {
issue := &types.Issue{
Title: "Feature with design",
Design: "Use MVC pattern",
AcceptanceCriteria: "All tests pass",
IssueType: types.TypeFeature,
Priority: 2,
Status: types.StatusOpen,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
issues, err := s.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
t.Fatalf("failed to search issues: %v", err)
}
// Find our issue
var created *types.Issue
for _, iss := range issues {
if iss.Title == "Feature with design" {
created = iss
break
}
}
if created == nil {
t.Fatal("could not find created issue")
}
if created.Design != "Use MVC pattern" {
t.Errorf("expected design, got %q", created.Design)
}
if created.AcceptanceCriteria != "All tests pass" {
t.Errorf("expected acceptance criteria, got %q", created.AcceptanceCriteria)
}
})
t.Run("WithLabels", func(t *testing.T) {
issue := &types.Issue{
Title: "Issue with labels",
Priority: 0,
Status: types.StatusOpen,
IssueType: types.TypeBug,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
// Add labels
if err := s.AddLabel(ctx, issue.ID, "bug", "test"); err != nil {
t.Fatalf("failed to add bug label: %v", err)
}
if err := s.AddLabel(ctx, issue.ID, "critical", "test"); err != nil {
t.Fatalf("failed to add critical label: %v", err)
}
labels, err := s.GetLabels(ctx, issue.ID)
if err != nil {
t.Fatalf("failed to get labels: %v", err)
}
if len(labels) != 2 {
t.Errorf("expected 2 labels, got %d", len(labels))
}
labelMap := make(map[string]bool)
for _, l := range labels {
labelMap[l] = true
}
if !labelMap["bug"] || !labelMap["critical"] {
t.Errorf("expected labels 'bug' and 'critical', got %v", labels)
}
})
t.Run("WithDependencies", func(t *testing.T) {
parent := &types.Issue{
Title: "Parent issue",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, parent, "test"); err != nil {
t.Fatalf("failed to create parent: %v", err)
}
child := &types.Issue{
Title: "Child issue",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, child, "test"); err != nil {
t.Fatalf("failed to create child: %v", err)
}
// Add dependency
dep := &types.Dependency{
IssueID: child.ID,
DependsOnID: parent.ID,
Type: types.DepBlocks,
CreatedAt: time.Now(),
}
if err := s.AddDependency(ctx, dep, "test"); err != nil {
t.Fatalf("failed to add dependency: %v", err)
}
deps, err := s.GetDependencies(ctx, child.ID)
if err != nil {
t.Fatalf("failed to get dependencies: %v", err)
}
if len(deps) == 0 {
t.Fatal("expected at least 1 dependency, got 0")
}
// Find the dependency on parent
found := false
for _, d := range deps {
if d.ID == parent.ID {
found = true
break
}
}
if !found {
t.Errorf("expected dependency on %s, not found", parent.ID)
}
})
t.Run("WithDiscoveredFromDependency", func(t *testing.T) {
parent := &types.Issue{
Title: "Parent work",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, parent, "test"); err != nil {
t.Fatalf("failed to create parent: %v", err)
}
discovered := &types.Issue{
Title: "Found bug",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeBug,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, discovered, "test"); err != nil {
t.Fatalf("failed to create discovered issue: %v", err)
}
// Add discovered-from dependency
dep := &types.Dependency{
IssueID: discovered.ID,
DependsOnID: parent.ID,
Type: types.DepDiscoveredFrom,
CreatedAt: time.Now(),
}
if err := s.AddDependency(ctx, dep, "test"); err != nil {
t.Fatalf("failed to add dependency: %v", err)
}
deps, err := s.GetDependencies(ctx, discovered.ID)
if err != nil {
t.Fatalf("failed to get dependencies: %v", err)
}
if len(deps) == 0 {
t.Fatal("expected at least 1 dependency, got 0")
}
// Find the dependency on parent
found := false
for _, d := range deps {
if d.ID == parent.ID {
found = true
break
}
}
if !found {
t.Errorf("expected dependency on %s, not found", parent.ID)
}
})
t.Run("WithExplicitID", func(t *testing.T) {
issue := &types.Issue{
ID: "test-abc123",
Title: "Custom ID issue",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
issues, err := s.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
t.Fatalf("failed to search issues: %v", err)
}
// Find our issue
found := false
for _, iss := range issues {
if iss.ID == "test-abc123" {
found = true
break
}
}
if !found {
t.Error("expected to find issue with ID 'test-abc123'")
}
})
t.Run("WithAssignee", func(t *testing.T) {
issue := &types.Issue{
Title: "Assigned issue",
Assignee: "alice",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
issues, err := s.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
t.Fatalf("failed to search issues: %v", err)
}
// Find our issue
var created *types.Issue
for _, iss := range issues {
if iss.Title == "Assigned issue" {
created = iss
break
}
}
if created == nil {
t.Fatal("could not find created issue")
}
if created.Assignee != "alice" {
t.Errorf("expected assignee 'alice', got %q", created.Assignee)
}
})
t.Run("AllIssueTypes", func(t *testing.T) {
issueTypes := []types.IssueType{
types.TypeBug,
types.TypeFeature,
types.TypeTask,
types.TypeEpic,
types.TypeChore,
}
createdIDs := make(map[string]bool)
for _, issueType := range issueTypes {
issue := &types.Issue{
Title: "Test " + string(issueType),
IssueType: issueType,
Priority: 2,
Status: types.StatusOpen,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue type %s: %v", issueType, err)
}
createdIDs[issue.ID] = true
}
issues, err := s.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
t.Fatalf("failed to search issues: %v", err)
}
// Verify all 5 types were created
foundCount := 0
for _, iss := range issues {
if createdIDs[iss.ID] {
foundCount++
}
}
if foundCount != 5 {
t.Errorf("expected to find 5 created issues, found %d", foundCount)
}
})
t.Run("MultipleDependencies", func(t *testing.T) {
parent1 := &types.Issue{
Title: "Parent 1",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
parent2 := &types.Issue{
Title: "Parent 2",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
child := &types.Issue{
Title: "Child",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, parent1, "test"); err != nil {
t.Fatalf("failed to create parent1: %v", err)
}
if err := s.CreateIssue(ctx, parent2, "test"); err != nil {
t.Fatalf("failed to create parent2: %v", err)
}
if err := s.CreateIssue(ctx, child, "test"); err != nil {
t.Fatalf("failed to create child: %v", err)
}
// Add multiple dependencies
dep1 := &types.Dependency{
IssueID: child.ID,
DependsOnID: parent1.ID,
Type: types.DepBlocks,
CreatedAt: time.Now(),
}
dep2 := &types.Dependency{
IssueID: child.ID,
DependsOnID: parent2.ID,
Type: types.DepRelated,
CreatedAt: time.Now(),
}
if err := s.AddDependency(ctx, dep1, "test"); err != nil {
t.Fatalf("failed to add dep1: %v", err)
}
if err := s.AddDependency(ctx, dep2, "test"); err != nil {
t.Fatalf("failed to add dep2: %v", err)
}
deps, err := s.GetDependencies(ctx, child.ID)
if err != nil {
t.Fatalf("failed to get dependencies: %v", err)
}
if len(deps) < 2 {
t.Fatalf("expected at least 2 dependencies, got %d", len(deps))
}
// Verify both parents are in dependencies
foundParents := make(map[string]bool)
for _, d := range deps {
if d.ID == parent1.ID || d.ID == parent2.ID {
foundParents[d.ID] = true
}
}
if len(foundParents) != 2 {
t.Errorf("expected to find both parent dependencies, found %d", len(foundParents))
}
})
// GH#820: Tests for DueAt and DeferUntil fields
t.Run("WithDueAt", func(t *testing.T) {
// Create issue with due date
dueTime := time.Now().Add(24 * time.Hour) // Due in 24 hours
issue := &types.Issue{
Title: "Issue with due date",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
DueAt: &dueTime,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue with due date: %v", err)
}
// Retrieve and verify
retrieved, err := s.GetIssue(ctx, issue.ID)
if err != nil {
t.Fatalf("failed to get issue: %v", err)
}
if retrieved.DueAt == nil {
t.Fatal("expected DueAt to be set")
}
// Compare with 1-second tolerance for database round-trip
diff := retrieved.DueAt.Sub(dueTime)
if diff < -time.Second || diff > time.Second {
t.Errorf("DueAt mismatch: got %v, want %v", retrieved.DueAt, dueTime)
}
})
t.Run("WithDeferUntil", func(t *testing.T) {
// Create issue with defer_until
deferTime := time.Now().Add(2 * time.Hour) // Defer for 2 hours
issue := &types.Issue{
Title: "Issue with defer",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
DeferUntil: &deferTime,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue with defer: %v", err)
}
// Retrieve and verify
retrieved, err := s.GetIssue(ctx, issue.ID)
if err != nil {
t.Fatalf("failed to get issue: %v", err)
}
if retrieved.DeferUntil == nil {
t.Fatal("expected DeferUntil to be set")
}
// Compare with 1-second tolerance for database round-trip
diff := retrieved.DeferUntil.Sub(deferTime)
if diff < -time.Second || diff > time.Second {
t.Errorf("DeferUntil mismatch: got %v, want %v", retrieved.DeferUntil, deferTime)
}
})
t.Run("WithBothDueAndDefer", func(t *testing.T) {
// Create issue with both due and defer
dueTime := time.Now().Add(48 * time.Hour) // Due in 48 hours
deferTime := time.Now().Add(24 * time.Hour) // Defer for 24 hours
issue := &types.Issue{
Title: "Issue with both due and defer",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
DueAt: &dueTime,
DeferUntil: &deferTime,
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("failed to create issue: %v", err)
}
// Retrieve and verify both fields
retrieved, err := s.GetIssue(ctx, issue.ID)
if err != nil {
t.Fatalf("failed to get issue: %v", err)
}
if retrieved.DueAt == nil {
t.Fatal("expected DueAt to be set")
}
if retrieved.DeferUntil == nil {
t.Fatal("expected DeferUntil to be set")
}
})
t.Run("DiscoveredFromInheritsSourceRepo", func(t *testing.T) {
// Create a parent issue with a custom source_repo
parent := &types.Issue{
Title: "Parent issue",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeTask,
SourceRepo: "/path/to/custom/repo",
CreatedAt: time.Now(),
}
if err := s.CreateIssue(ctx, parent, "test"); err != nil {
t.Fatalf("failed to create parent: %v", err)
}
// Create a discovered issue with discovered-from dependency
// This should inherit the parent's source_repo
discovered := &types.Issue{
Title: "Discovered bug",
Priority: 1,
Status: types.StatusOpen,
IssueType: types.TypeBug,
CreatedAt: time.Now(),
}
// Simulate what happens in create.go when --deps discovered-from:parent is used
// The source_repo should be inherited from the parent
parentIssue, err := s.GetIssue(ctx, parent.ID)
if err != nil {
t.Fatalf("failed to get parent issue: %v", err)
}
if parentIssue.SourceRepo != "" {
discovered.SourceRepo = parentIssue.SourceRepo
}
if err := s.CreateIssue(ctx, discovered, "test"); err != nil {
t.Fatalf("failed to create discovered issue: %v", err)
}
// Add discovered-from dependency
dep := &types.Dependency{
IssueID: discovered.ID,
DependsOnID: parent.ID,
Type: types.DepDiscoveredFrom,
CreatedAt: time.Now(),
}
if err := s.AddDependency(ctx, dep, "test"); err != nil {
t.Fatalf("failed to add dependency: %v", err)
}
// Verify the discovered issue inherited the source_repo
retrievedIssue, err := s.GetIssue(ctx, discovered.ID)
if err != nil {
t.Fatalf("failed to get discovered issue: %v", err)
}
if retrievedIssue.SourceRepo != parent.SourceRepo {
t.Errorf("expected source_repo %q, got %q", parent.SourceRepo, retrievedIssue.SourceRepo)
}
if retrievedIssue.SourceRepo != "/path/to/custom/repo" {
t.Errorf("expected source_repo '/path/to/custom/repo', got %q", retrievedIssue.SourceRepo)
}
})
}