Files
beads/cmd/bd/migrate_test.go
Steve Yegge defc90deeb fix: bd migrate respects config.json database name and fixes I/O errors
Fixes #204

Multiple critical bugs in bd migrate:

1. **Respects config.json database name**: migrate now loads config.json
   and uses the configured database name instead of hardcoding beads.db.
   Users with custom database names (e.g., beady.db) will no longer
   have their databases renamed.

2. **Fixes disk I/O error (522)**: Clean up orphaned WAL files before
   reopening database to update schema version. This prevents SQLite
   error 522 (disk I/O error) when WAL files exist from previous
   database sessions.

3. **Creates backup before migration**: First migration now creates
   a timestamped backup (*.backup-pre-migrate-*.db) before renaming
   database, consistent with hash-id migration behavior.

4. **Cleans up orphaned WAL files**: Removes .db-wal and .db-shm
   files after migrating old database to prevent stale files.

Changes:
- Load config.json in migrate command to get target database name
- Use cfg.Database instead of hardcoded beads.CanonicalDatabaseName
- Add loadOrCreateConfig() helper function
- Add cleanupWALFiles() to remove orphaned WAL/SHM files
- Create backup before first migration
- Clean up WAL files before version update and after migration
- Add TestMigrateRespectsConfigJSON test

All migration tests passing.

Amp-Thread-ID: https://ampcode.com/threads/T-e5b9ddd0-621b-418b-bc52-ba9462975c39
Co-authored-by: Amp <amp@ampcode.com>
2025-11-02 08:46:20 -08:00

178 lines
5.0 KiB
Go

package main
import (
"context"
"os"
"path/filepath"
"testing"
"github.com/steveyegge/beads/internal/storage/sqlite"
)
func TestMigrateCommand(t *testing.T) {
// Create temporary test directory
tmpDir := t.TempDir()
beadsDir := filepath.Join(tmpDir, ".beads")
if err := os.MkdirAll(beadsDir, 0750); err != nil {
t.Fatalf("Failed to create .beads directory: %v", err)
}
t.Run("no databases", func(t *testing.T) {
databases, err := detectDatabases(beadsDir)
if err != nil {
t.Fatalf("detectDatabases failed: %v", err)
}
if len(databases) != 0 {
t.Errorf("Expected 0 databases, got %d", len(databases))
}
})
t.Run("single old database", func(t *testing.T) {
// Create old database
oldDBPath := filepath.Join(beadsDir, "vc.db")
store, err := sqlite.New(oldDBPath)
if err != nil {
t.Fatalf("Failed to create old database: %v", err)
}
// Set old version
ctx := context.Background()
if err := store.SetMetadata(ctx, "bd_version", "0.16.0"); err != nil {
t.Fatalf("Failed to set old version: %v", err)
}
_ = store.Close()
// Detect databases
databases, err := detectDatabases(beadsDir)
if err != nil {
t.Fatalf("detectDatabases failed: %v", err)
}
if len(databases) != 1 {
t.Fatalf("Expected 1 database, got %d", len(databases))
}
if databases[0].version != "0.16.0" {
t.Errorf("Expected version 0.16.0, got %s", databases[0].version)
}
// Migrate to beads.db
targetPath := filepath.Join(beadsDir, "beads.db")
if err := os.Rename(oldDBPath, targetPath); err != nil {
t.Fatalf("Failed to migrate database: %v", err)
}
// Verify migration
databases, err = detectDatabases(beadsDir)
if err != nil {
t.Fatalf("detectDatabases failed after migration: %v", err)
}
if len(databases) != 1 {
t.Fatalf("Expected 1 database after migration, got %d", len(databases))
}
if filepath.Base(databases[0].path) != "beads.db" {
t.Errorf("Expected beads.db, got %s", filepath.Base(databases[0].path))
}
})
t.Run("version detection", func(t *testing.T) {
// Test getDBVersion with beads.db from previous test
dbPath := filepath.Join(beadsDir, "beads.db")
version := getDBVersion(dbPath)
if version != "0.16.0" {
t.Errorf("Expected version 0.16.0, got %s", version)
}
// Update version
store, err := sqlite.New(dbPath)
if err != nil {
t.Fatalf("Failed to open database: %v", err)
}
ctx := context.Background()
if err := store.SetMetadata(ctx, "bd_version", Version); err != nil {
t.Fatalf("Failed to update version: %v", err)
}
_ = store.Close()
// Verify updated version
version = getDBVersion(dbPath)
if version != Version {
t.Errorf("Expected version %s, got %s", Version, version)
}
})
}
func TestFormatDBList(t *testing.T) {
dbs := []*dbInfo{
{path: "/tmp/.beads/beads.db", version: "0.17.5"},
{path: "/tmp/.beads/old.db", version: "0.16.0"},
}
result := formatDBList(dbs)
if len(result) != 2 {
t.Fatalf("Expected 2 results, got %d", len(result))
}
if result[0]["name"] != "beads.db" {
t.Errorf("Expected name beads.db, got %s", result[0]["name"])
}
if result[0]["version"] != "0.17.5" {
t.Errorf("Expected version 0.17.5, got %s", result[0]["version"])
}
if result[1]["name"] != "old.db" {
t.Errorf("Expected name old.db, got %s", result[1]["name"])
}
if result[1]["version"] != "0.16.0" {
t.Errorf("Expected version 0.16.0, got %s", result[1]["version"])
}
}
func TestMigrateRespectsConfigJSON(t *testing.T) {
// Test that migrate respects custom database name from config.json
tmpDir := t.TempDir()
beadsDir := filepath.Join(tmpDir, ".beads")
if err := os.MkdirAll(beadsDir, 0750); err != nil {
t.Fatalf("Failed to create .beads directory: %v", err)
}
// Create config.json with custom database name
configPath := filepath.Join(beadsDir, "config.json")
configData := `{"database": "beady.db", "version": "0.21.1", "jsonl_export": "beady.jsonl"}`
if err := os.WriteFile(configPath, []byte(configData), 0600); err != nil {
t.Fatalf("Failed to create config.json: %v", err)
}
// Create old database with custom name
oldDBPath := filepath.Join(beadsDir, "beady.db")
store, err := sqlite.New(oldDBPath)
if err != nil {
t.Fatalf("Failed to create database: %v", err)
}
ctx := context.Background()
if err := store.SetMetadata(ctx, "bd_version", "0.21.1"); err != nil {
t.Fatalf("Failed to set version: %v", err)
}
_ = store.Close()
// Load config
cfg, err := loadOrCreateConfig(beadsDir)
if err != nil {
t.Fatalf("Failed to load config: %v", err)
}
// Verify config respects custom database name
if cfg.Database != "beady.db" {
t.Errorf("Expected database name 'beady.db', got %s", cfg.Database)
}
expectedPath := filepath.Join(beadsDir, "beady.db")
actualPath := cfg.DatabasePath(beadsDir)
if actualPath != expectedPath {
t.Errorf("Expected path %s, got %s", expectedPath, actualPath)
}
// Verify database exists at custom path
if _, err := os.Stat(actualPath); os.IsNotExist(err) {
t.Errorf("Database does not exist at custom path: %s", actualPath)
}
}