feat(deacon): add zombie-scan command for tmux-verified process cleanup
Unlike cleanup-orphans (which uses TTY="?" detection), zombie-scan uses tmux verification: it checks if each Claude process is in an active tmux session by comparing against actual pane PIDs. A process is a zombie if: - It's a Claude/codex process - It's NOT the pane PID of any active tmux session - It's NOT a child of any pane PID - It's older than 60 seconds Also refactors: - getChildPIDs() with ps fallback when pgrep unavailable - State file handling with file locking for concurrent access Usage: gt deacon zombie-scan # Find and kill zombies gt deacon zombie-scan --dry-run # Just list zombies Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
committed by
Steve Yegge
parent
48ace2cbf3
commit
0db2bda6e6
@@ -264,6 +264,30 @@ Example:
|
|||||||
RunE: runDeaconCleanupOrphans,
|
RunE: runDeaconCleanupOrphans,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
var deaconZombieScanCmd = &cobra.Command{
|
||||||
|
Use: "zombie-scan",
|
||||||
|
Short: "Find and clean zombie Claude processes not in active tmux sessions",
|
||||||
|
Long: `Find and clean zombie Claude processes not in active tmux sessions.
|
||||||
|
|
||||||
|
Unlike cleanup-orphans (which uses TTY detection), zombie-scan uses tmux
|
||||||
|
verification: it checks if each Claude process is in an active tmux session
|
||||||
|
by comparing against actual pane PIDs.
|
||||||
|
|
||||||
|
A process is a zombie if:
|
||||||
|
- It's a Claude/codex process
|
||||||
|
- It's NOT the pane PID of any active tmux session
|
||||||
|
- It's NOT a child of any pane PID
|
||||||
|
- It's older than 60 seconds
|
||||||
|
|
||||||
|
This catches "ghost" processes that have a TTY (from a dead tmux session)
|
||||||
|
but are no longer part of any active Gas Town session.
|
||||||
|
|
||||||
|
Examples:
|
||||||
|
gt deacon zombie-scan # Find and kill zombies
|
||||||
|
gt deacon zombie-scan --dry-run # Just list zombies, don't kill`,
|
||||||
|
RunE: runDeaconZombieScan,
|
||||||
|
}
|
||||||
|
|
||||||
var (
|
var (
|
||||||
triggerTimeout time.Duration
|
triggerTimeout time.Duration
|
||||||
|
|
||||||
@@ -282,6 +306,9 @@ var (
|
|||||||
|
|
||||||
// Pause flags
|
// Pause flags
|
||||||
pauseReason string
|
pauseReason string
|
||||||
|
|
||||||
|
// Zombie scan flags
|
||||||
|
zombieScanDryRun bool
|
||||||
)
|
)
|
||||||
|
|
||||||
func init() {
|
func init() {
|
||||||
@@ -299,6 +326,7 @@ func init() {
|
|||||||
deaconCmd.AddCommand(deaconPauseCmd)
|
deaconCmd.AddCommand(deaconPauseCmd)
|
||||||
deaconCmd.AddCommand(deaconResumeCmd)
|
deaconCmd.AddCommand(deaconResumeCmd)
|
||||||
deaconCmd.AddCommand(deaconCleanupOrphansCmd)
|
deaconCmd.AddCommand(deaconCleanupOrphansCmd)
|
||||||
|
deaconCmd.AddCommand(deaconZombieScanCmd)
|
||||||
|
|
||||||
// Flags for trigger-pending
|
// Flags for trigger-pending
|
||||||
deaconTriggerPendingCmd.Flags().DurationVar(&triggerTimeout, "timeout", 2*time.Second,
|
deaconTriggerPendingCmd.Flags().DurationVar(&triggerTimeout, "timeout", 2*time.Second,
|
||||||
@@ -328,6 +356,10 @@ func init() {
|
|||||||
deaconPauseCmd.Flags().StringVar(&pauseReason, "reason", "",
|
deaconPauseCmd.Flags().StringVar(&pauseReason, "reason", "",
|
||||||
"Reason for pausing the Deacon")
|
"Reason for pausing the Deacon")
|
||||||
|
|
||||||
|
// Flags for zombie-scan
|
||||||
|
deaconZombieScanCmd.Flags().BoolVar(&zombieScanDryRun, "dry-run", false,
|
||||||
|
"List zombies without killing them")
|
||||||
|
|
||||||
deaconStartCmd.Flags().StringVar(&deaconAgentOverride, "agent", "", "Agent alias to run the Deacon with (overrides town default)")
|
deaconStartCmd.Flags().StringVar(&deaconAgentOverride, "agent", "", "Agent alias to run the Deacon with (overrides town default)")
|
||||||
deaconAttachCmd.Flags().StringVar(&deaconAgentOverride, "agent", "", "Agent alias to run the Deacon with (overrides town default)")
|
deaconAttachCmd.Flags().StringVar(&deaconAgentOverride, "agent", "", "Agent alias to run the Deacon with (overrides town default)")
|
||||||
deaconRestartCmd.Flags().StringVar(&deaconAgentOverride, "agent", "", "Agent alias to run the Deacon with (overrides town default)")
|
deaconRestartCmd.Flags().StringVar(&deaconAgentOverride, "agent", "", "Agent alias to run the Deacon with (overrides town default)")
|
||||||
@@ -1185,3 +1217,68 @@ func runDeaconCleanupOrphans(cmd *cobra.Command, args []string) error {
|
|||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// runDeaconZombieScan finds and cleans zombie Claude processes not in active tmux sessions.
|
||||||
|
func runDeaconZombieScan(cmd *cobra.Command, args []string) error {
|
||||||
|
// Find zombies using tmux verification
|
||||||
|
zombies, err := util.FindZombieClaudeProcesses()
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("finding zombie processes: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
if len(zombies) == 0 {
|
||||||
|
fmt.Printf("%s No zombie claude processes found\n", style.Dim.Render("○"))
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
fmt.Printf("%s Found %d zombie claude process(es)\n", style.Bold.Render("●"), len(zombies))
|
||||||
|
|
||||||
|
// In dry-run mode, just list them
|
||||||
|
if zombieScanDryRun {
|
||||||
|
for _, z := range zombies {
|
||||||
|
ageStr := fmt.Sprintf("%dm", z.Age/60)
|
||||||
|
fmt.Printf(" %s PID %d (%s) TTY=%s age=%s\n",
|
||||||
|
style.Dim.Render("→"), z.PID, z.Cmd, z.TTY, ageStr)
|
||||||
|
}
|
||||||
|
fmt.Printf("%s Dry run - no processes killed\n", style.Dim.Render("○"))
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// Process them with signal escalation
|
||||||
|
results, err := util.CleanupZombieClaudeProcesses()
|
||||||
|
if err != nil {
|
||||||
|
style.PrintWarning("cleanup had errors: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Report results
|
||||||
|
var terminated, escalated, unkillable int
|
||||||
|
for _, r := range results {
|
||||||
|
switch r.Signal {
|
||||||
|
case "SIGTERM":
|
||||||
|
fmt.Printf(" %s Sent SIGTERM to PID %d (%s) TTY=%s\n",
|
||||||
|
style.Bold.Render("→"), r.Process.PID, r.Process.Cmd, r.Process.TTY)
|
||||||
|
terminated++
|
||||||
|
case "SIGKILL":
|
||||||
|
fmt.Printf(" %s Escalated to SIGKILL for PID %d (%s)\n",
|
||||||
|
style.Bold.Render("!"), r.Process.PID, r.Process.Cmd)
|
||||||
|
escalated++
|
||||||
|
case "UNKILLABLE":
|
||||||
|
fmt.Printf(" %s WARNING: PID %d (%s) survived SIGKILL\n",
|
||||||
|
style.Bold.Render("⚠"), r.Process.PID, r.Process.Cmd)
|
||||||
|
unkillable++
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if len(results) > 0 {
|
||||||
|
summary := fmt.Sprintf("Processed %d zombie(s)", len(results))
|
||||||
|
if escalated > 0 {
|
||||||
|
summary += fmt.Sprintf(" (%d escalated to SIGKILL)", escalated)
|
||||||
|
}
|
||||||
|
if unkillable > 0 {
|
||||||
|
summary += fmt.Sprintf(" (%d unkillable)", unkillable)
|
||||||
|
}
|
||||||
|
fmt.Printf("%s %s\n", style.Bold.Render("✓"), summary)
|
||||||
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|||||||
@@ -59,18 +59,53 @@ func getGasTownSessionPIDs() map[int]bool {
|
|||||||
// addChildPIDs adds all descendant PIDs of a process to the set.
|
// addChildPIDs adds all descendant PIDs of a process to the set.
|
||||||
// This catches Claude processes spawned by the shell in a tmux pane.
|
// This catches Claude processes spawned by the shell in a tmux pane.
|
||||||
func addChildPIDs(parentPID int, pids map[int]bool) {
|
func addChildPIDs(parentPID int, pids map[int]bool) {
|
||||||
// Use pgrep to find children (more reliable than parsing ps output)
|
childPIDs := getChildPIDs(parentPID)
|
||||||
out, err := exec.Command("pgrep", "-P", strconv.Itoa(parentPID)).Output()
|
for _, pid := range childPIDs {
|
||||||
if err != nil {
|
pids[pid] = true
|
||||||
return
|
// Recurse to get grandchildren
|
||||||
|
addChildPIDs(pid, pids)
|
||||||
}
|
}
|
||||||
for _, pidStr := range strings.Split(strings.TrimSpace(string(out)), "\n") {
|
}
|
||||||
if pid, err := strconv.Atoi(pidStr); err == nil && pid > 0 {
|
|
||||||
pids[pid] = true
|
// getChildPIDs returns direct child PIDs of a process.
|
||||||
// Recurse to get grandchildren
|
// Tries pgrep first, falls back to parsing ps output.
|
||||||
addChildPIDs(pid, pids)
|
func getChildPIDs(parentPID int) []int {
|
||||||
|
var childPIDs []int
|
||||||
|
|
||||||
|
// Try pgrep first (faster, more reliable when available)
|
||||||
|
out, err := exec.Command("pgrep", "-P", strconv.Itoa(parentPID)).Output()
|
||||||
|
if err == nil {
|
||||||
|
for _, pidStr := range strings.Split(strings.TrimSpace(string(out)), "\n") {
|
||||||
|
if pid, err := strconv.Atoi(pidStr); err == nil && pid > 0 {
|
||||||
|
childPIDs = append(childPIDs, pid)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return childPIDs
|
||||||
|
}
|
||||||
|
|
||||||
|
// Fallback: parse ps output to find children
|
||||||
|
// ps -eo pid,ppid gives us all processes with their parent PIDs
|
||||||
|
out, err = exec.Command("ps", "-eo", "pid,ppid").Output()
|
||||||
|
if err != nil {
|
||||||
|
return childPIDs
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, line := range strings.Split(string(out), "\n") {
|
||||||
|
fields := strings.Fields(line)
|
||||||
|
if len(fields) < 2 {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
pid, err1 := strconv.Atoi(fields[0])
|
||||||
|
ppid, err2 := strconv.Atoi(fields[1])
|
||||||
|
if err1 != nil || err2 != nil {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if ppid == parentPID && pid > 0 {
|
||||||
|
childPIDs = append(childPIDs, pid)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
return childPIDs
|
||||||
}
|
}
|
||||||
|
|
||||||
// sigkillGracePeriod is how long (in seconds) we wait after sending SIGTERM
|
// sigkillGracePeriod is how long (in seconds) we wait after sending SIGTERM
|
||||||
@@ -78,33 +113,40 @@ func addChildPIDs(parentPID int, pids map[int]bool) {
|
|||||||
// around after this period, we use SIGKILL on the next cleanup cycle.
|
// around after this period, we use SIGKILL on the next cleanup cycle.
|
||||||
const sigkillGracePeriod = 60
|
const sigkillGracePeriod = 60
|
||||||
|
|
||||||
// orphanStateFile returns the path to the state file that tracks PIDs we've
|
|
||||||
// sent signals to. Uses $XDG_RUNTIME_DIR if available, otherwise /tmp.
|
|
||||||
func orphanStateFile() string {
|
|
||||||
dir := os.Getenv("XDG_RUNTIME_DIR")
|
|
||||||
if dir == "" {
|
|
||||||
dir = "/tmp"
|
|
||||||
}
|
|
||||||
return filepath.Join(dir, "gastown-orphan-state")
|
|
||||||
}
|
|
||||||
|
|
||||||
// signalState tracks what signal was last sent to a PID and when.
|
// signalState tracks what signal was last sent to a PID and when.
|
||||||
type signalState struct {
|
type signalState struct {
|
||||||
Signal string // "SIGTERM" or "SIGKILL"
|
Signal string // "SIGTERM" or "SIGKILL"
|
||||||
Timestamp time.Time // When the signal was sent
|
Timestamp time.Time // When the signal was sent
|
||||||
}
|
}
|
||||||
|
|
||||||
// loadOrphanState reads the state file and returns the current signal state
|
// stateFileDir returns the directory for state files.
|
||||||
|
func stateFileDir() string {
|
||||||
|
dir := os.Getenv("XDG_RUNTIME_DIR")
|
||||||
|
if dir == "" {
|
||||||
|
dir = "/tmp"
|
||||||
|
}
|
||||||
|
return dir
|
||||||
|
}
|
||||||
|
|
||||||
|
// loadSignalState reads a state file and returns the current signal state
|
||||||
// for each tracked PID. Automatically cleans up entries for dead processes.
|
// for each tracked PID. Automatically cleans up entries for dead processes.
|
||||||
func loadOrphanState() map[int]signalState {
|
// Uses file locking to prevent concurrent access.
|
||||||
|
func loadSignalState(filename string) map[int]signalState {
|
||||||
state := make(map[int]signalState)
|
state := make(map[int]signalState)
|
||||||
|
|
||||||
f, err := os.Open(orphanStateFile())
|
path := filepath.Join(stateFileDir(), filename)
|
||||||
|
f, err := os.Open(path)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return state // File doesn't exist yet, that's fine
|
return state // File doesn't exist yet, that's fine
|
||||||
}
|
}
|
||||||
defer f.Close()
|
defer f.Close()
|
||||||
|
|
||||||
|
// Acquire shared lock for reading
|
||||||
|
if err := syscall.Flock(int(f.Fd()), syscall.LOCK_SH); err != nil {
|
||||||
|
return state
|
||||||
|
}
|
||||||
|
defer syscall.Flock(int(f.Fd()), syscall.LOCK_UN) //nolint:errcheck
|
||||||
|
|
||||||
scanner := bufio.NewScanner(f)
|
scanner := bufio.NewScanner(f)
|
||||||
for scanner.Scan() {
|
for scanner.Scan() {
|
||||||
parts := strings.Fields(scanner.Text())
|
parts := strings.Fields(scanner.Text())
|
||||||
@@ -130,20 +172,41 @@ func loadOrphanState() map[int]signalState {
|
|||||||
return state
|
return state
|
||||||
}
|
}
|
||||||
|
|
||||||
// saveOrphanState writes the current signal state to the state file.
|
// saveSignalState writes the current signal state to a state file.
|
||||||
func saveOrphanState(state map[int]signalState) error {
|
// Uses file locking to prevent concurrent access.
|
||||||
f, err := os.Create(orphanStateFile())
|
func saveSignalState(filename string, state map[int]signalState) error {
|
||||||
|
path := filepath.Join(stateFileDir(), filename)
|
||||||
|
f, err := os.Create(path)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
defer f.Close()
|
defer f.Close()
|
||||||
|
|
||||||
|
// Acquire exclusive lock for writing
|
||||||
|
if err := syscall.Flock(int(f.Fd()), syscall.LOCK_EX); err != nil {
|
||||||
|
return fmt.Errorf("acquiring lock: %w", err)
|
||||||
|
}
|
||||||
|
defer syscall.Flock(int(f.Fd()), syscall.LOCK_UN) //nolint:errcheck
|
||||||
|
|
||||||
for pid, s := range state {
|
for pid, s := range state {
|
||||||
fmt.Fprintf(f, "%d %s %d\n", pid, s.Signal, s.Timestamp.Unix())
|
fmt.Fprintf(f, "%d %s %d\n", pid, s.Signal, s.Timestamp.Unix())
|
||||||
}
|
}
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// orphanStateFile is the filename for orphan process tracking state.
|
||||||
|
const orphanStateFile = "gastown-orphan-state"
|
||||||
|
|
||||||
|
// loadOrphanState reads the orphan state file.
|
||||||
|
func loadOrphanState() map[int]signalState {
|
||||||
|
return loadSignalState(orphanStateFile)
|
||||||
|
}
|
||||||
|
|
||||||
|
// saveOrphanState writes the orphan state file.
|
||||||
|
func saveOrphanState(state map[int]signalState) error {
|
||||||
|
return saveSignalState(orphanStateFile, state)
|
||||||
|
}
|
||||||
|
|
||||||
// processExists checks if a process is still running.
|
// processExists checks if a process is still running.
|
||||||
func processExists(pid int) bool {
|
func processExists(pid int) bool {
|
||||||
err := syscall.Kill(pid, 0)
|
err := syscall.Kill(pid, 0)
|
||||||
@@ -294,6 +357,206 @@ type CleanupResult struct {
|
|||||||
Error error
|
Error error
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ZombieProcess represents a claude process not in any active tmux session.
|
||||||
|
type ZombieProcess struct {
|
||||||
|
PID int
|
||||||
|
Cmd string
|
||||||
|
Age int // Age in seconds
|
||||||
|
TTY string // TTY column from ps (may be "?" or a session like "s024")
|
||||||
|
}
|
||||||
|
|
||||||
|
// FindZombieClaudeProcesses finds Claude processes NOT in any active tmux session.
|
||||||
|
// This catches "zombie" processes that have a TTY but whose tmux session is dead.
|
||||||
|
//
|
||||||
|
// Unlike FindOrphanedClaudeProcesses (which uses TTY="?" detection), this function
|
||||||
|
// uses tmux pane verification: a process is a zombie if it's NOT the pane PID of
|
||||||
|
// any active tmux session AND not a child of any pane PID.
|
||||||
|
//
|
||||||
|
// This is the definitive zombie check because it verifies against tmux reality.
|
||||||
|
func FindZombieClaudeProcesses() ([]ZombieProcess, error) {
|
||||||
|
// Get ALL valid PIDs (panes + their children) from active tmux sessions
|
||||||
|
validPIDs := getGasTownSessionPIDs()
|
||||||
|
|
||||||
|
// SAFETY CHECK: If no valid PIDs found, tmux might be down or no sessions exist.
|
||||||
|
// Returning empty is safer than marking all Claude processes as zombies.
|
||||||
|
if len(validPIDs) == 0 {
|
||||||
|
// Check if tmux is even running
|
||||||
|
if err := exec.Command("tmux", "list-sessions").Run(); err != nil {
|
||||||
|
return nil, fmt.Errorf("tmux not available: %w", err)
|
||||||
|
}
|
||||||
|
// tmux is running but no gt-*/hq-* sessions - that's a valid state,
|
||||||
|
// but we can't safely determine zombies without reference sessions.
|
||||||
|
// Return empty rather than marking everything as zombie.
|
||||||
|
return nil, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// Use ps to get PID, TTY, command, and elapsed time for all claude processes
|
||||||
|
out, err := exec.Command("ps", "-eo", "pid,tty,comm,etime").Output()
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("listing processes: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
var zombies []ZombieProcess
|
||||||
|
for _, line := range strings.Split(string(out), "\n") {
|
||||||
|
fields := strings.Fields(line)
|
||||||
|
if len(fields) < 4 {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
pid, err := strconv.Atoi(fields[0])
|
||||||
|
if err != nil {
|
||||||
|
continue // Header line or invalid PID
|
||||||
|
}
|
||||||
|
|
||||||
|
tty := fields[1]
|
||||||
|
cmd := fields[2]
|
||||||
|
etimeStr := fields[3]
|
||||||
|
|
||||||
|
// Match claude or codex command names
|
||||||
|
cmdLower := strings.ToLower(cmd)
|
||||||
|
if cmdLower != "claude" && cmdLower != "claude-code" && cmdLower != "codex" {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
// Skip processes that belong to valid Gas Town tmux sessions
|
||||||
|
if validPIDs[pid] {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
// Skip processes younger than minOrphanAge seconds
|
||||||
|
age, err := parseEtime(etimeStr)
|
||||||
|
if err != nil {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if age < minOrphanAge {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
// This process is NOT in any active tmux session - it's a zombie
|
||||||
|
zombies = append(zombies, ZombieProcess{
|
||||||
|
PID: pid,
|
||||||
|
Cmd: cmd,
|
||||||
|
Age: age,
|
||||||
|
TTY: tty,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
return zombies, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// zombieStateFile is the filename for zombie process tracking state.
|
||||||
|
const zombieStateFile = "gastown-zombie-state"
|
||||||
|
|
||||||
|
// loadZombieState reads the zombie state file.
|
||||||
|
func loadZombieState() map[int]signalState {
|
||||||
|
return loadSignalState(zombieStateFile)
|
||||||
|
}
|
||||||
|
|
||||||
|
// saveZombieState writes the zombie state file.
|
||||||
|
func saveZombieState(state map[int]signalState) error {
|
||||||
|
return saveSignalState(zombieStateFile, state)
|
||||||
|
}
|
||||||
|
|
||||||
|
// ZombieCleanupResult describes what happened to a zombie process.
|
||||||
|
type ZombieCleanupResult struct {
|
||||||
|
Process ZombieProcess
|
||||||
|
Signal string // "SIGTERM", "SIGKILL", or "UNKILLABLE"
|
||||||
|
Error error
|
||||||
|
}
|
||||||
|
|
||||||
|
// CleanupZombieClaudeProcesses finds and kills zombie Claude processes.
|
||||||
|
// Uses tmux verification to ensure we never kill processes in active sessions.
|
||||||
|
//
|
||||||
|
// Uses the same graceful escalation as orphan cleanup:
|
||||||
|
// 1. First encounter → SIGTERM, record in state file
|
||||||
|
// 2. Next cycle, still alive after grace period → SIGKILL
|
||||||
|
// 3. Next cycle, still alive after SIGKILL → log as unkillable
|
||||||
|
func CleanupZombieClaudeProcesses() ([]ZombieCleanupResult, error) {
|
||||||
|
zombies, err := FindZombieClaudeProcesses()
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
state := loadZombieState()
|
||||||
|
now := time.Now()
|
||||||
|
|
||||||
|
var results []ZombieCleanupResult
|
||||||
|
var lastErr error
|
||||||
|
|
||||||
|
activeZombies := make(map[int]bool)
|
||||||
|
for _, z := range zombies {
|
||||||
|
activeZombies[z.PID] = true
|
||||||
|
}
|
||||||
|
|
||||||
|
// Check state for PIDs that died or need escalation
|
||||||
|
for pid, s := range state {
|
||||||
|
if !activeZombies[pid] {
|
||||||
|
delete(state, pid)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
elapsed := now.Sub(s.Timestamp).Seconds()
|
||||||
|
|
||||||
|
if s.Signal == "SIGKILL" {
|
||||||
|
results = append(results, ZombieCleanupResult{
|
||||||
|
Process: ZombieProcess{PID: pid, Cmd: "claude"},
|
||||||
|
Signal: "UNKILLABLE",
|
||||||
|
Error: fmt.Errorf("process %d survived SIGKILL", pid),
|
||||||
|
})
|
||||||
|
delete(state, pid)
|
||||||
|
delete(activeZombies, pid)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
if s.Signal == "SIGTERM" && elapsed >= float64(sigkillGracePeriod) {
|
||||||
|
if err := syscall.Kill(pid, syscall.SIGKILL); err != nil {
|
||||||
|
if err != syscall.ESRCH {
|
||||||
|
lastErr = fmt.Errorf("SIGKILL PID %d: %w", pid, err)
|
||||||
|
}
|
||||||
|
delete(state, pid)
|
||||||
|
delete(activeZombies, pid)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
state[pid] = signalState{Signal: "SIGKILL", Timestamp: now}
|
||||||
|
results = append(results, ZombieCleanupResult{
|
||||||
|
Process: ZombieProcess{PID: pid, Cmd: "claude"},
|
||||||
|
Signal: "SIGKILL",
|
||||||
|
})
|
||||||
|
delete(activeZombies, pid)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Send SIGTERM to new zombies
|
||||||
|
for _, zombie := range zombies {
|
||||||
|
if !activeZombies[zombie.PID] {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if _, exists := state[zombie.PID]; exists {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
if err := syscall.Kill(zombie.PID, syscall.SIGTERM); err != nil {
|
||||||
|
if err != syscall.ESRCH {
|
||||||
|
lastErr = fmt.Errorf("SIGTERM PID %d: %w", zombie.PID, err)
|
||||||
|
}
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
state[zombie.PID] = signalState{Signal: "SIGTERM", Timestamp: now}
|
||||||
|
results = append(results, ZombieCleanupResult{
|
||||||
|
Process: zombie,
|
||||||
|
Signal: "SIGTERM",
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
if err := saveZombieState(state); err != nil {
|
||||||
|
if lastErr == nil {
|
||||||
|
lastErr = fmt.Errorf("saving zombie state: %w", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return results, lastErr
|
||||||
|
}
|
||||||
|
|
||||||
// CleanupOrphanedClaudeProcesses finds and kills orphaned claude/codex processes.
|
// CleanupOrphanedClaudeProcesses finds and kills orphaned claude/codex processes.
|
||||||
//
|
//
|
||||||
// Uses a state machine to escalate signals:
|
// Uses a state machine to escalate signals:
|
||||||
|
|||||||
Reference in New Issue
Block a user