johno/gastown
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: handle error return from os.RemoveAll in defer

Browse Source
This commit is contained in:
Dustin Smith
2026-01-21 22:45:14 +07:00
committed by John Ogle
parent eb8024c1f9
commit 21cee0c45b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/git/git.go
View File

@@ -127,7 +127,7 @@ func (g *Git) Clone(url, dest string) error {
if err != nil { if err != nil {
return fmt.Errorf("creating temp dir: %w", err) return fmt.Errorf("creating temp dir: %w", err)
} }
defer os.RemoveAll(tmpDir) defer func() { _ = os.RemoveAll(tmpDir) }()
tmpDest := filepath.Join(tmpDir, filepath.Base(dest)) tmpDest := filepath.Join(tmpDir, filepath.Base(dest))
cmd := exec.Command("git", "clone", url, tmpDest) cmd := exec.Command("git", "clone", url, tmpDest)
@@ -167,7 +167,7 @@ func (g *Git) CloneWithReference(url, dest, reference string) error {
if err != nil { if err != nil {
return fmt.Errorf("creating temp dir: %w", err) return fmt.Errorf("creating temp dir: %w", err)
} }
defer os.RemoveAll(tmpDir) defer func() { _ = os.RemoveAll(tmpDir) }()
tmpDest := filepath.Join(tmpDir, filepath.Base(dest)) tmpDest := filepath.Join(tmpDir, filepath.Base(dest))
cmd := exec.Command("git", "clone", "--reference-if-able", reference, url, tmpDest) cmd := exec.Command("git", "clone", "--reference-if-able", reference, url, tmpDest)
@@ -207,7 +207,7 @@ func (g *Git) CloneBare(url, dest string) error {
if err != nil { if err != nil {
return fmt.Errorf("creating temp dir: %w", err) return fmt.Errorf("creating temp dir: %w", err)
} }
defer os.RemoveAll(tmpDir) defer func() { _ = os.RemoveAll(tmpDir) }()
tmpDest := filepath.Join(tmpDir, filepath.Base(dest)) tmpDest := filepath.Join(tmpDir, filepath.Base(dest))
cmd := exec.Command("git", "clone", "--bare", url, tmpDest) cmd := exec.Command("git", "clone", "--bare", url, tmpDest)
@@ -289,7 +289,7 @@ func (g *Git) CloneBareWithReference(url, dest, reference string) error {
if err != nil { if err != nil {
return fmt.Errorf("creating temp dir: %w", err) return fmt.Errorf("creating temp dir: %w", err)
} }
defer os.RemoveAll(tmpDir) defer func() { _ = os.RemoveAll(tmpDir) }()
tmpDest := filepath.Join(tmpDir, filepath.Base(dest)) tmpDest := filepath.Join(tmpDir, filepath.Base(dest))
cmd := exec.Command("git", "clone", "--bare", "--reference-if-able", reference, url, tmpDest) cmd := exec.Command("git", "clone", "--bare", "--reference-if-able", reference, url, tmpDest)