Files
gastown/internal/doctor/beads_check.go
Ryan Snodgrass e1f2bb8b4b feat(ui): import comprehensive UX system from beads
Import beads' UX design system into gastown:

- Add internal/ui/ package with Ayu theme colors and semantic styling
  - styles.go: AdaptiveColor definitions for light/dark mode
  - terminal.go: TTY detection, NO_COLOR/CLICOLOR support
  - markdown.go: Glamour rendering with agent mode bypass
  - pager.go: Smart paging with GT_PAGER support

- Add colorized help output (internal/cmd/help.go)
  - Group headers in accent color
  - Command names styled for scannability
  - Flag types and defaults muted

- Add gt thanks command (internal/cmd/thanks.go)
  - Contributor display with same logic as bd thanks
  - Styled with Ayu theme colors

- Update gt doctor to match bd doctor UX
  - Category grouping (Core, Infrastructure, Rig, Patrol, etc.)
  - Semantic icons (✓ ⚠ ✖) with Ayu colors
  - Tree connectors for detail lines
  - Summary line with pass/warn/fail counts
  - Warnings section at end with numbered issues

- Migrate existing styles to use ui package
  - internal/style/style.go uses ui.ColorPass etc.
  - internal/tui/feed/styles.go uses ui package colors

Co-Authored-By: SageOx <ox@sageox.ai>
2026-01-09 22:46:06 -08:00

439 lines
12 KiB
Go

package doctor
import (
"bytes"
"encoding/json"
"fmt"
"os"
"os/exec"
"path/filepath"
"strings"
"github.com/steveyegge/gastown/internal/beads"
)
// BeadsDatabaseCheck verifies that the beads database is properly initialized.
// It detects when issues.db is empty or missing critical columns, and can
// auto-fix by triggering a re-import from the JSONL file.
type BeadsDatabaseCheck struct {
FixableCheck
}
// NewBeadsDatabaseCheck creates a new beads database check.
func NewBeadsDatabaseCheck() *BeadsDatabaseCheck {
return &BeadsDatabaseCheck{
FixableCheck: FixableCheck{
BaseCheck: BaseCheck{
CheckName: "beads-database",
CheckDescription: "Verify beads database is properly initialized",
CheckCategory: CategoryConfig,
},
},
}
}
// Run checks if the beads database is properly initialized.
func (c *BeadsDatabaseCheck) Run(ctx *CheckContext) *CheckResult {
// Check town-level beads
beadsDir := filepath.Join(ctx.TownRoot, ".beads")
if _, err := os.Stat(beadsDir); os.IsNotExist(err) {
return &CheckResult{
Name: c.Name(),
Status: StatusWarning,
Message: "No .beads directory found at town root",
FixHint: "Run 'bd init' to initialize beads",
}
}
// Check if issues.db exists and has content
issuesDB := filepath.Join(beadsDir, "issues.db")
issuesJSONL := filepath.Join(beadsDir, "issues.jsonl")
dbInfo, dbErr := os.Stat(issuesDB)
jsonlInfo, jsonlErr := os.Stat(issuesJSONL)
// If no database file, that's OK - beads will create it
if os.IsNotExist(dbErr) {
return &CheckResult{
Name: c.Name(),
Status: StatusOK,
Message: "No issues.db file (will be created on first use)",
}
}
// If database file is empty but JSONL has content, this is the bug
if dbErr == nil && dbInfo.Size() == 0 {
if jsonlErr == nil && jsonlInfo.Size() > 0 {
return &CheckResult{
Name: c.Name(),
Status: StatusError,
Message: "issues.db is empty but issues.jsonl has content",
Details: []string{
"This can cause 'table issues has no column named pinned' errors",
"The database needs to be rebuilt from the JSONL file",
},
FixHint: "Run 'gt doctor --fix' or delete issues.db and run 'bd sync --from-main'",
}
}
}
// Also check rig-level beads if a rig is specified
// Follows redirect if present (rig root may redirect to mayor/rig/.beads)
if ctx.RigName != "" {
rigBeadsDir := beads.ResolveBeadsDir(ctx.RigPath())
if _, err := os.Stat(rigBeadsDir); err == nil {
rigDB := filepath.Join(rigBeadsDir, "issues.db")
rigJSONL := filepath.Join(rigBeadsDir, "issues.jsonl")
rigDBInfo, rigDBErr := os.Stat(rigDB)
rigJSONLInfo, rigJSONLErr := os.Stat(rigJSONL)
if rigDBErr == nil && rigDBInfo.Size() == 0 {
if rigJSONLErr == nil && rigJSONLInfo.Size() > 0 {
return &CheckResult{
Name: c.Name(),
Status: StatusError,
Message: "Rig issues.db is empty but issues.jsonl has content",
Details: []string{
"Rig: " + ctx.RigName,
"This can cause 'table issues has no column named pinned' errors",
},
FixHint: "Run 'gt doctor --fix' or delete the rig's issues.db",
}
}
}
}
}
return &CheckResult{
Name: c.Name(),
Status: StatusOK,
Message: "Beads database is properly initialized",
}
}
// Fix attempts to rebuild the database from JSONL.
func (c *BeadsDatabaseCheck) Fix(ctx *CheckContext) error {
beadsDir := filepath.Join(ctx.TownRoot, ".beads")
issuesDB := filepath.Join(beadsDir, "issues.db")
issuesJSONL := filepath.Join(beadsDir, "issues.jsonl")
// Check if we need to fix town-level database
dbInfo, dbErr := os.Stat(issuesDB)
jsonlInfo, jsonlErr := os.Stat(issuesJSONL)
if dbErr == nil && dbInfo.Size() == 0 && jsonlErr == nil && jsonlInfo.Size() > 0 {
// Delete the empty database file
if err := os.Remove(issuesDB); err != nil {
return err
}
// Run bd sync to rebuild from JSONL
cmd := exec.Command("bd", "sync", "--from-main")
cmd.Dir = ctx.TownRoot
var stderr bytes.Buffer
cmd.Stderr = &stderr
if err := cmd.Run(); err != nil {
return err
}
}
// Also fix rig-level if specified (follows redirect if present)
if ctx.RigName != "" {
rigBeadsDir := beads.ResolveBeadsDir(ctx.RigPath())
rigDB := filepath.Join(rigBeadsDir, "issues.db")
rigJSONL := filepath.Join(rigBeadsDir, "issues.jsonl")
rigDBInfo, rigDBErr := os.Stat(rigDB)
rigJSONLInfo, rigJSONLErr := os.Stat(rigJSONL)
if rigDBErr == nil && rigDBInfo.Size() == 0 && rigJSONLErr == nil && rigJSONLInfo.Size() > 0 {
if err := os.Remove(rigDB); err != nil {
return err
}
cmd := exec.Command("bd", "sync", "--from-main")
cmd.Dir = ctx.RigPath()
var stderr bytes.Buffer
cmd.Stderr = &stderr
if err := cmd.Run(); err != nil {
return err
}
}
}
return nil
}
// PrefixConflictCheck detects duplicate prefixes across rigs in routes.jsonl.
// Duplicate prefixes break prefix-based routing.
type PrefixConflictCheck struct {
BaseCheck
}
// NewPrefixConflictCheck creates a new prefix conflict check.
func NewPrefixConflictCheck() *PrefixConflictCheck {
return &PrefixConflictCheck{
BaseCheck: BaseCheck{
CheckName: "prefix-conflict",
CheckDescription: "Check for duplicate beads prefixes across rigs",
CheckCategory: CategoryConfig,
},
}
}
// Run checks for duplicate prefixes in routes.jsonl.
func (c *PrefixConflictCheck) Run(ctx *CheckContext) *CheckResult {
beadsDir := filepath.Join(ctx.TownRoot, ".beads")
// Check if routes.jsonl exists
routesPath := filepath.Join(beadsDir, beads.RoutesFileName)
if _, err := os.Stat(routesPath); os.IsNotExist(err) {
return &CheckResult{
Name: c.Name(),
Status: StatusOK,
Message: "No routes.jsonl file (prefix routing not configured)",
}
}
// Find conflicts
conflicts, err := beads.FindConflictingPrefixes(beadsDir)
if err != nil {
return &CheckResult{
Name: c.Name(),
Status: StatusWarning,
Message: fmt.Sprintf("Could not check routes.jsonl: %v", err),
}
}
if len(conflicts) == 0 {
return &CheckResult{
Name: c.Name(),
Status: StatusOK,
Message: "No prefix conflicts found",
}
}
// Build details
var details []string
for prefix, paths := range conflicts {
details = append(details, fmt.Sprintf("Prefix %q used by: %s", prefix, strings.Join(paths, ", ")))
}
return &CheckResult{
Name: c.Name(),
Status: StatusError,
Message: fmt.Sprintf("%d prefix conflict(s) found in routes.jsonl", len(conflicts)),
Details: details,
FixHint: "Use 'bd rename-prefix <new-prefix>' in one of the conflicting rigs to resolve",
}
}
// PrefixMismatchCheck detects when rigs.json has a different prefix than what
// routes.jsonl actually uses for a rig. This can happen when:
// - deriveBeadsPrefix() generates a different prefix than what's in the beads DB
// - Someone manually edited rigs.json with the wrong prefix
// - The beads were initialized before auto-derive existed with a different prefix
type PrefixMismatchCheck struct {
FixableCheck
}
// NewPrefixMismatchCheck creates a new prefix mismatch check.
func NewPrefixMismatchCheck() *PrefixMismatchCheck {
return &PrefixMismatchCheck{
FixableCheck: FixableCheck{
BaseCheck: BaseCheck{
CheckName: "prefix-mismatch",
CheckDescription: "Check for prefix mismatches between rigs.json and routes.jsonl",
CheckCategory: CategoryConfig,
},
},
}
}
// Run checks for prefix mismatches between rigs.json and routes.jsonl.
func (c *PrefixMismatchCheck) Run(ctx *CheckContext) *CheckResult {
beadsDir := filepath.Join(ctx.TownRoot, ".beads")
// Load routes.jsonl
routes, err := beads.LoadRoutes(beadsDir)
if err != nil {
return &CheckResult{
Name: c.Name(),
Status: StatusWarning,
Message: fmt.Sprintf("Could not load routes.jsonl: %v", err),
}
}
if len(routes) == 0 {
return &CheckResult{
Name: c.Name(),
Status: StatusOK,
Message: "No routes configured (nothing to check)",
}
}
// Load rigs.json
rigsPath := filepath.Join(ctx.TownRoot, "mayor", "rigs.json")
rigsConfig, err := loadRigsConfig(rigsPath)
if err != nil {
return &CheckResult{
Name: c.Name(),
Status: StatusOK,
Message: "No rigs.json found (nothing to check)",
}
}
// Build map of route path -> prefix from routes.jsonl
routePrefixByPath := make(map[string]string)
for _, r := range routes {
// Normalize: strip trailing hyphen from prefix for comparison
prefix := strings.TrimSuffix(r.Prefix, "-")
routePrefixByPath[r.Path] = prefix
}
// Check each rig in rigs.json against routes.jsonl
var mismatches []string
mismatchData := make(map[string][2]string) // rigName -> [rigsJsonPrefix, routesPrefix]
for rigName, rigEntry := range rigsConfig.Rigs {
// Skip rigs without beads config
if rigEntry.BeadsConfig == nil || rigEntry.BeadsConfig.Prefix == "" {
continue
}
rigsJsonPrefix := rigEntry.BeadsConfig.Prefix
expectedPath := rigName + "/mayor/rig"
// Find the route for this rig
routePrefix, hasRoute := routePrefixByPath[expectedPath]
if !hasRoute {
// No route for this rig - routes-config check handles this
continue
}
// Compare prefixes (both should be without trailing hyphen)
if rigsJsonPrefix != routePrefix {
mismatches = append(mismatches, rigName)
mismatchData[rigName] = [2]string{rigsJsonPrefix, routePrefix}
}
}
if len(mismatches) == 0 {
return &CheckResult{
Name: c.Name(),
Status: StatusOK,
Message: "No prefix mismatches found",
}
}
// Build details
var details []string
for _, rigName := range mismatches {
data := mismatchData[rigName]
details = append(details, fmt.Sprintf("Rig '%s': rigs.json says '%s', routes.jsonl uses '%s'",
rigName, data[0], data[1]))
}
return &CheckResult{
Name: c.Name(),
Status: StatusWarning,
Message: fmt.Sprintf("%d prefix mismatch(es) between rigs.json and routes.jsonl", len(mismatches)),
Details: details,
FixHint: "Run 'gt doctor --fix' to update rigs.json with correct prefixes",
}
}
// Fix updates rigs.json to match the prefixes in routes.jsonl.
func (c *PrefixMismatchCheck) Fix(ctx *CheckContext) error {
beadsDir := filepath.Join(ctx.TownRoot, ".beads")
// Load routes.jsonl
routes, err := beads.LoadRoutes(beadsDir)
if err != nil || len(routes) == 0 {
return nil // Nothing to fix
}
// Load rigs.json
rigsPath := filepath.Join(ctx.TownRoot, "mayor", "rigs.json")
rigsConfig, err := loadRigsConfig(rigsPath)
if err != nil {
return nil // Nothing to fix
}
// Build map of route path -> prefix from routes.jsonl
routePrefixByPath := make(map[string]string)
for _, r := range routes {
prefix := strings.TrimSuffix(r.Prefix, "-")
routePrefixByPath[r.Path] = prefix
}
// Update each rig's prefix to match routes.jsonl
modified := false
for rigName, rigEntry := range rigsConfig.Rigs {
expectedPath := rigName + "/mayor/rig"
routePrefix, hasRoute := routePrefixByPath[expectedPath]
if !hasRoute {
continue
}
// Ensure BeadsConfig exists
if rigEntry.BeadsConfig == nil {
rigEntry.BeadsConfig = &rigsConfigBeadsConfig{}
}
if rigEntry.BeadsConfig.Prefix != routePrefix {
rigEntry.BeadsConfig.Prefix = routePrefix
rigsConfig.Rigs[rigName] = rigEntry
modified = true
}
}
if modified {
return saveRigsConfig(rigsPath, rigsConfig)
}
return nil
}
// rigsConfigEntry is a local type for loading rigs.json without importing config package
// to avoid circular dependencies and keep the check self-contained.
type rigsConfigEntry struct {
GitURL string `json:"git_url"`
LocalRepo string `json:"local_repo,omitempty"`
AddedAt string `json:"added_at"` // Keep as string to preserve format
BeadsConfig *rigsConfigBeadsConfig `json:"beads,omitempty"`
}
type rigsConfigBeadsConfig struct {
Repo string `json:"repo"`
Prefix string `json:"prefix"`
}
type rigsConfigFile struct {
Version int `json:"version"`
Rigs map[string]rigsConfigEntry `json:"rigs"`
}
func loadRigsConfig(path string) (*rigsConfigFile, error) {
data, err := os.ReadFile(path)
if err != nil {
return nil, err
}
var cfg rigsConfigFile
if err := json.Unmarshal(data, &cfg); err != nil {
return nil, err
}
return &cfg, nil
}
func saveRigsConfig(path string, cfg *rigsConfigFile) error {
data, err := json.MarshalIndent(cfg, "", " ")
if err != nil {
return err
}
return os.WriteFile(path, data, 0644)
}