johno/nixos-configs
1
0
Fork 0
Code Issues 3 Pull Requests 8 Actions Packages Projects Releases Wiki Activity

[nixos-configs-fkt] Parameterize hardcoded values in roles #19

Open
johno wants to merge 1 commits from bead/nixos-configs-fkt into main
pull from: bead/nixos-configs-fkt
merge into: johno:main
Conversation 0 Commits 1 Files Changed 3 +42 -7
johno commented 2026-01-10 13:10:00 -08:00
Owner
Copy Link

Summary

Implements bead: nixos-configs-fkt

This PR parameterizes hardcoded values in three system roles to improve configurability:

  • printing role: Add printerName, printerUri, and printerModel options to replace hardcoded Brother printer values
  • nfs-mounts role: Add server, remotePath, and mountPoint options to replace hardcoded NFS server IP (10.0.0.43)
  • virtualisation role: Add dockerUsers option (list type) to replace hardcoded 'johno' docker group membership

All options have sensible defaults matching the original hardcoded values, ensuring backward compatibility while allowing per-host customization.

Changes

  • roles/printing/default.nix: 3 new options for printer configuration
  • roles/nfs-mounts/default.nix: 3 new options for NFS mount configuration
  • roles/virtualisation/default.nix: 1 new option for docker group users

Test plan

  • All modified files pass Nix syntax validation
  • Build a NixOS configuration that uses these roles
  • Verify options can be overridden per-host
## Summary Implements bead: nixos-configs-fkt This PR parameterizes hardcoded values in three system roles to improve configurability: - **printing role**: Add `printerName`, `printerUri`, and `printerModel` options to replace hardcoded Brother printer values - **nfs-mounts role**: Add `server`, `remotePath`, and `mountPoint` options to replace hardcoded NFS server IP (10.0.0.43) - **virtualisation role**: Add `dockerUsers` option (list type) to replace hardcoded 'johno' docker group membership All options have sensible defaults matching the original hardcoded values, ensuring backward compatibility while allowing per-host customization. ## Changes - `roles/printing/default.nix`: 3 new options for printer configuration - `roles/nfs-mounts/default.nix`: 3 new options for NFS mount configuration - `roles/virtualisation/default.nix`: 1 new option for docker group users ## Test plan - [x] All modified files pass Nix syntax validation - [ ] Build a NixOS configuration that uses these roles - [ ] Verify options can be overridden per-host
johno added 1 commit 2026-01-10 13:10:01 -08:00
feat(roles): Parameterize hardcoded values in printing, nfs-mounts, and virtualisation roles 513f6cb8b4 
- printing role: Add configurable printerName, printerUri, and printerModel options
  to replace hardcoded Brother printer values
- nfs-mounts role: Add configurable server, remotePath, and mountPoint options
  to replace hardcoded NFS server IP (10.0.0.43)
- virtualisation role: Add configurable dockerUsers option as list type
  to replace hardcoded 'johno' docker group membership

All options have sensible defaults matching the original hardcoded values,
ensuring backward compatibility while allowing per-host customization.

Implements bead: nixos-configs-fkt
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin bead/nixos-configs-fkt:bead/nixos-configs-fkt
git checkout bead/nixos-configs-fkt
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johno-square johno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: johno/nixos-configs#19
Delete Branch "bead/nixos-configs-fkt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?