johno/nixos-configs
1
0
Fork 0
Code Issues 3 Pull Requests 7 Actions Packages Projects Releases Wiki Activity

[nixos-configs-vru] Add skill for responding to Gitea PR review comments #26

Merged
johno merged 4 commits from bead/nixos-configs-vru into main 2026-01-13 09:08:18 -08:00
Conversation 6 Commits 4 Files Changed 1 +387 -159
johno commented 2026-01-13 07:29:46 -08:00
Owner
Copy Link

Summary

  • Rewrote gitea_pr_review.md as a comprehensive interactive skill
  • Accepts PR number as argument or auto-detects from current branch
  • Reads Gitea config from tea CLI config file
  • Fetches and displays review comments via REST API
  • Interactive comment selection via AskUserQuestion
  • Posts replies via tea comment with file:line context

Bead Reference

Implements bead: nixos-configs-vru

Changes

  • Rewritten home/roles/development/skills/gitea_pr_review.md (+259/-155 lines)

Testing

Please leave a review comment on this PR so we can test the skill!

Limitations

  • Thread replies are posted as top-level comments (Gitea API limitation)
  • Uses first login from tea config
## Summary - Rewrote gitea_pr_review.md as a comprehensive interactive skill - Accepts PR number as argument or auto-detects from current branch - Reads Gitea config from tea CLI config file - Fetches and displays review comments via REST API - Interactive comment selection via AskUserQuestion - Posts replies via `tea comment` with file:line context ## Bead Reference Implements bead: nixos-configs-vru ## Changes - Rewritten `home/roles/development/skills/gitea_pr_review.md` (+259/-155 lines) ## Testing Please leave a review comment on this PR so we can test the skill! ## Limitations - Thread replies are posted as top-level comments (Gitea API limitation) - Uses first login from tea config
johno added 1 commit 2026-01-13 07:29:46 -08:00
feat(skills): Rewrite gitea_pr_review as interactive skill f3af982304 
- Accept PR number as argument or detect from current branch
- Read Gitea config from ~/.config/tea/config.yml
- Fetch and display review comments via REST API
- Interactive comment selection via AskUserQuestion
- Post replies via tea comment with file:line context
- Add comprehensive error handling

Implements bead: nixos-configs-vru
johno reviewed 2026-01-13 07:42:39 -08:00
home/roles/development/skills/gitea_pr_review.md Outdated
@@ -9,3 +9,4 @@
## Prerequisites
- `tea` CLI configured with a Gitea/Forgejo instance
- `yq` installed for parsing tea config
johno commented 2026-01-13 07:42:39 -08:00
Author
Owner
Copy Link

we heavily rely on nix and try to ensure all environments this skill will be running in will have it installed. could we indicate that here in Prerequisites that access to nix+nixpkgs satisfies this?

we heavily rely on nix and try to ensure all environments this skill will be running in will have it installed. could we indicate that here in Prerequisites that access to nix+nixpkgs satisfies this?
johno marked this conversation as resolved
johno reviewed 2026-01-13 07:44:01 -08:00
home/roles/development/skills/gitea_pr_review.md
@@ -18,0 +47,4 @@
If config is missing or invalid:
```
Error: Could not read tea config at ~/.config/tea/config.yml
johno commented 2026-01-13 07:44:01 -08:00
Author
Owner
Copy Link

we eventually want to run this in CI, where the tea token will be passed in as an env var

we eventually want to run this in CI, where the tea token will be passed in as an env var
johno commented 2026-01-13 07:45:26 -08:00
Author
Owner
Copy Link

that will be a separate skill though, so no need to update this now

that will be a separate skill though, so no need to update this now
johno marked this conversation as resolved
johno added 1 commit 2026-01-13 07:55:52 -08:00
refactor(skills): Make gitea_pr_review action-oriented 3a2773dcce 
Transform the skill from a comment-reply tool to a PR-progress driver:

- Categorize comments by actionability (actionable/question/acknowledged/blocked)
- Launch parallel subagents to make code changes for actionable comments
- Commit and push changes before posting summary
- Post single summary comment describing all actions taken
- Add nix prerequisite note as requested in review

Addresses review comments:
- gitea_pr_review.md:12 - Added nix+nixpkgs note to prerequisites
- gitea_pr_review.md:50 - Acknowledged CI variant as separate skill
johno commented 2026-01-13 07:55:58 -08:00
Author
Owner
Copy Link

Review Comments Addressed

Changes made (commit 3a2773d):

  • gitea_pr_review.md:12: Added nix prerequisite note - nix users can get tools via nixpkgs

Also in this commit:

  • Rewrote the skill to be action-oriented rather than conversation-oriented
  • Skill now categorizes comments, launches subagents to make changes, commits/pushes, then posts summary

Acknowledged (no action needed):

  • gitea_pr_review.md:50: CI variant with env var token support will be a separate skill

Automated response via /gitea_pr_review

## Review Comments Addressed **Changes made** (commit 3a2773d): - `gitea_pr_review.md:12`: Added nix prerequisite note - nix users can get tools via nixpkgs **Also in this commit**: - Rewrote the skill to be action-oriented rather than conversation-oriented - Skill now categorizes comments, launches subagents to make changes, commits/pushes, then posts summary **Acknowledged** (no action needed): - `gitea_pr_review.md:50`: CI variant with env var token support will be a separate skill --- *Automated response via /gitea_pr_review*
johno reviewed 2026-01-13 07:57:08 -08:00
home/roles/development/skills/gitea_pr_review.md Outdated
@@ -11,3 +21,4 @@
- `tea` CLI configured with a Gitea/Forgejo instance
- Access token from tea config: `~/.config/tea/config.yml`
- Repository must be a Gitea/Forgejo remote (not GitHub)
- **Nix users**: All tools available via nixpkgs (`nix-shell -p tea`)
johno commented 2026-01-13 07:57:08 -08:00
Author
Owner
Copy Link

let's use nix run nixpkgs#tea instead of a nix-shell

let's use `nix run nixpkgs#tea` instead of a nix-shell
johno marked this conversation as resolved
johno reviewed 2026-01-13 07:57:53 -08:00
home/roles/development/skills/gitea_pr_review.md
@@ -201,0 +284,4 @@
**Comment posted**: {comment_url}
PR URL: {GITEA_URL}/{OWNER}/{REPO}/pulls/{PR_NUMBER}
johno commented 2026-01-13 07:57:53 -08:00
Author
Owner
Copy Link

we should tag any of the commenters in our response as well

we should tag any of the commenters in our response as well
johno added 1 commit 2026-01-13 08:02:10 -08:00
fix(skills): Address PR review comments for gitea_pr_review 2c91cd23be 
- Use `nix run nixpkgs#tea` instead of nix-shell (preferred for ad-hoc)
- Add reviewer tagging in summary comment with cc @mentions
- Filter out dismissed reviews and resolved comments in workflow
- Add note about notifying reviewers of changes
johno commented 2026-01-13 08:05:03 -08:00
Author
Owner
Copy Link

Review Comments Addressed

cc @johno

Changes made (commit 2c91cd2):

  • Prerequisites & error message: Changed nix-shell -p tea to nix run nixpkgs#tea
  • Summary comment template: Added cc @{reviewer} line to tag reviewers
  • Final summary section: Added "Reviewers tagged" field and note about notifications
  • Step 1: Added filtering for dismissed reviews and resolved comments

Acknowledged (no action needed):

  • CI token via env var: Noted as future separate skill (no changes needed now)

Automated response via /gitea_pr_review

## Review Comments Addressed cc @johno **Changes made** (commit 2c91cd2): - Prerequisites & error message: Changed `nix-shell -p tea` to `nix run nixpkgs#tea` - Summary comment template: Added `cc @{reviewer}` line to tag reviewers - Final summary section: Added "Reviewers tagged" field and note about notifications - Step 1: Added filtering for dismissed reviews and resolved comments **Acknowledged** (no action needed): - CI token via env var: Noted as future separate skill (no changes needed now) --- *Automated response via /gitea_pr_review*
johno added 1 commit 2026-01-13 09:02:52 -08:00
docs(skills): Add shell command patterns for Claude Code reliability 214368da4b
johno merged commit 996fb86ed8 into main 2026-01-13 09:08:18 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
johno
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johno-square johno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: johno/nixos-configs#26
Delete Branch "bead/nixos-configs-vru"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?