Merge pull request #70 from markov-kernel/fix/enter-key-retry

fix: Make Mayor/Deacon session names include town name
This commit is contained in:
Steve Yegge
2026-01-03 12:48:19 -08:00
committed by GitHub
46 changed files with 4772 additions and 1615 deletions
+4035 -1314
View File
File diff suppressed because one or more lines are too long
+7 -3
View File
@@ -35,6 +35,7 @@ type AgentSession struct {
Type AgentType
Rig string // For rig-specific agents
AgentName string // e.g., crew name, polecat name
Town string // For mayor/deacon only (town name from session)
}
// AgentTypeColors maps agent types to tmux color codes.
@@ -135,13 +136,16 @@ func categorizeSession(name string) *AgentSession {
session := &AgentSession{Name: name}
suffix := strings.TrimPrefix(name, "gt-")
// Town-level agents
if suffix == "mayor" {
// Town-level agents: gt-{town}-mayor, gt-{town}-deacon
// Check if suffix ends with -mayor or -deacon (new format)
if strings.HasSuffix(suffix, "-mayor") {
session.Type = AgentMayor
session.Town = strings.TrimSuffix(suffix, "-mayor")
return session
}
if suffix == "deacon" {
if strings.HasSuffix(suffix, "-deacon") {
session.Type = AgentDeacon
session.Town = strings.TrimSuffix(suffix, "-deacon")
return session
}
+4 -1
View File
@@ -277,7 +277,10 @@ func runDegradedTriage(b *boot.Boot) (action, target string, err error) {
tm := b.Tmux()
// Check if Deacon session exists
deaconSession := "gt-deacon"
deaconSession, err := getDeaconSessionName()
if err != nil {
return "error", "deacon", fmt.Errorf("getting deacon session name: %w", err)
}
hasDeacon, err := tm.HasSession(deaconSession)
if err != nil {
return "error", "deacon", fmt.Errorf("checking deacon session: %w", err)
+5 -4
View File
@@ -618,12 +618,13 @@ func runCostsRecord(cmd *cobra.Command, args []string) error {
// - Polecats: gt-{rig}-{polecat} (e.g., gt-gastown-toast)
// - Crew: gt-{rig}-crew-{crew} (e.g., gt-gastown-crew-max)
// - Witness/Refinery: gt-{rig}-{role} (e.g., gt-gastown-witness)
// - Mayor/Deacon: gt-{role} (e.g., gt-mayor)
// - Mayor/Deacon: gt-{town}-{role} (e.g., gt-ai-mayor)
func deriveSessionName() string {
role := os.Getenv("GT_ROLE")
rig := os.Getenv("GT_RIG")
polecat := os.Getenv("GT_POLECAT")
crew := os.Getenv("GT_CREW")
town := os.Getenv("GT_TOWN")
// Polecat: gt-{rig}-{polecat}
if polecat != "" && rig != "" {
@@ -635,9 +636,9 @@ func deriveSessionName() string {
return fmt.Sprintf("gt-%s-crew-%s", rig, crew)
}
// Global roles without rig: gt-{role}
if role != "" && rig == "" {
return fmt.Sprintf("gt-%s", role)
// Town-level roles (mayor, deacon): gt-{town}-{role}
if (role == "mayor" || role == "deacon") && town != "" {
return fmt.Sprintf("gt-%s-%s", town, role)
}
// Rig-based roles (witness, refinery): gt-{rig}-{role}
+5 -3
View File
@@ -49,15 +49,17 @@ func TestDeriveSessionName(t *testing.T) {
name: "mayor session",
envVars: map[string]string{
"GT_ROLE": "mayor",
"GT_TOWN": "ai",
},
expected: "gt-mayor",
expected: "gt-ai-mayor",
},
{
name: "deacon session",
envVars: map[string]string{
"GT_ROLE": "deacon",
"GT_TOWN": "ai",
},
expected: "gt-deacon",
expected: "gt-ai-deacon",
},
{
name: "no env vars",
@@ -70,7 +72,7 @@ func TestDeriveSessionName(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
// Save and clear relevant env vars
saved := make(map[string]string)
envKeys := []string{"GT_ROLE", "GT_RIG", "GT_POLECAT", "GT_CREW"}
envKeys := []string{"GT_ROLE", "GT_RIG", "GT_POLECAT", "GT_CREW", "GT_TOWN"}
for _, key := range envKeys {
saved[key] = os.Getenv(key)
os.Unsetenv(key)
+6 -3
View File
@@ -77,9 +77,12 @@ func cycleToSession(direction int, sessionOverride string) error {
}
// Check if it's a town-level session
for _, townSession := range townLevelSessions {
if session == townSession {
return cycleTownSession(direction, session)
townLevelSessions := getTownLevelSessions()
if townLevelSessions != nil {
for _, townSession := range townLevelSessions {
if session == townSession {
return cycleTownSession(direction, session)
}
}
}
+84 -29
View File
@@ -21,8 +21,19 @@ import (
"github.com/steveyegge/gastown/internal/workspace"
)
// DeaconSessionName is the tmux session name for the Deacon.
const DeaconSessionName = "gt-deacon"
// getDeaconSessionName returns the Deacon session name for the current workspace.
// The session name includes the town name to avoid collisions between multiple HQs.
func getDeaconSessionName() (string, error) {
townRoot, err := workspace.FindFromCwdOrError()
if err != nil {
return "", fmt.Errorf("not in a Gas Town workspace: %w", err)
}
townName, err := workspace.GetTownName(townRoot)
if err != nil {
return "", err
}
return session.DeaconSessionName(townName), nil
}
var deaconCmd = &cobra.Command{
Use: "deacon",
@@ -274,8 +285,13 @@ func init() {
func runDeaconStart(cmd *cobra.Command, args []string) error {
t := tmux.NewTmux()
sessionName, err := getDeaconSessionName()
if err != nil {
return err
}
// Check if session already exists
running, err := t.HasSession(DeaconSessionName)
running, err := t.HasSession(sessionName)
if err != nil {
return fmt.Errorf("checking session: %w", err)
}
@@ -283,7 +299,7 @@ func runDeaconStart(cmd *cobra.Command, args []string) error {
return fmt.Errorf("Deacon session already running. Attach with: gt deacon attach")
}
if err := startDeaconSession(t); err != nil {
if err := startDeaconSession(t, sessionName); err != nil {
return err
}
@@ -295,7 +311,7 @@ func runDeaconStart(cmd *cobra.Command, args []string) error {
}
// startDeaconSession creates and initializes the Deacon tmux session.
func startDeaconSession(t *tmux.Tmux) error {
func startDeaconSession(t *tmux.Tmux, sessionName string) error {
// Find workspace root
townRoot, err := workspace.FindFromCwdOrError()
if err != nil {
@@ -317,35 +333,35 @@ func startDeaconSession(t *tmux.Tmux) error {
// Create session in deacon directory
fmt.Println("Starting Deacon session...")
if err := t.NewSession(DeaconSessionName, deaconDir); err != nil {
if err := t.NewSession(sessionName, deaconDir); err != nil {
return fmt.Errorf("creating session: %w", err)
}
// Set environment (non-fatal: session works without these)
_ = t.SetEnvironment(DeaconSessionName, "GT_ROLE", "deacon")
_ = t.SetEnvironment(DeaconSessionName, "BD_ACTOR", "deacon")
_ = t.SetEnvironment(sessionName, "GT_ROLE", "deacon")
_ = t.SetEnvironment(sessionName, "BD_ACTOR", "deacon")
// Apply Deacon theme (non-fatal: theming failure doesn't affect operation)
// Note: ConfigureGasTownSession includes cycle bindings
theme := tmux.DeaconTheme()
_ = t.ConfigureGasTownSession(DeaconSessionName, theme, "", "Deacon", "health-check")
_ = t.ConfigureGasTownSession(sessionName, theme, "", "Deacon", "health-check")
// Launch Claude directly (no shell respawn loop)
// Restarts are handled by daemon via ensureDeaconRunning on each heartbeat
// The startup hook handles context loading automatically
// Export GT_ROLE and BD_ACTOR in the command since tmux SetEnvironment only affects new panes
if err := t.SendKeys(DeaconSessionName, config.BuildAgentStartupCommand("deacon", "deacon", "", "")); err != nil {
if err := t.SendKeys(sessionName, config.BuildAgentStartupCommand("deacon", "deacon", "", "")); err != nil {
return fmt.Errorf("sending command: %w", err)
}
// Wait for Claude to start (non-fatal)
if err := t.WaitForCommand(DeaconSessionName, constants.SupportedShells, constants.ClaudeStartTimeout); err != nil {
if err := t.WaitForCommand(sessionName, constants.SupportedShells, constants.ClaudeStartTimeout); err != nil {
// Non-fatal
}
time.Sleep(constants.ShutdownNotifyDelay)
// Inject startup nudge for predecessor discovery via /resume
_ = session.StartupNudge(t, DeaconSessionName, session.StartupNudgeConfig{
_ = session.StartupNudge(t, sessionName, session.StartupNudgeConfig{
Recipient: "deacon",
Sender: "daemon",
Topic: "patrol",
@@ -355,7 +371,7 @@ func startDeaconSession(t *tmux.Tmux) error {
// Send the propulsion nudge to trigger autonomous patrol execution.
// Wait for beacon to be fully processed (needs to be separate prompt)
time.Sleep(2 * time.Second)
_ = t.NudgeSession(DeaconSessionName, session.PropulsionNudgeForRole("deacon", deaconDir)) // Non-fatal
_ = t.NudgeSession(sessionName, session.PropulsionNudgeForRole("deacon", deaconDir)) // Non-fatal
return nil
}
@@ -363,8 +379,13 @@ func startDeaconSession(t *tmux.Tmux) error {
func runDeaconStop(cmd *cobra.Command, args []string) error {
t := tmux.NewTmux()
sessionName, err := getDeaconSessionName()
if err != nil {
return err
}
// Check if session exists
running, err := t.HasSession(DeaconSessionName)
running, err := t.HasSession(sessionName)
if err != nil {
return fmt.Errorf("checking session: %w", err)
}
@@ -375,11 +396,11 @@ func runDeaconStop(cmd *cobra.Command, args []string) error {
fmt.Println("Stopping Deacon session...")
// Try graceful shutdown first (best-effort interrupt)
_ = t.SendKeysRaw(DeaconSessionName, "C-c")
_ = t.SendKeysRaw(sessionName, "C-c")
time.Sleep(100 * time.Millisecond)
// Kill the session
if err := t.KillSession(DeaconSessionName); err != nil {
if err := t.KillSession(sessionName); err != nil {
return fmt.Errorf("killing session: %w", err)
}
@@ -390,35 +411,45 @@ func runDeaconStop(cmd *cobra.Command, args []string) error {
func runDeaconAttach(cmd *cobra.Command, args []string) error {
t := tmux.NewTmux()
sessionName, err := getDeaconSessionName()
if err != nil {
return err
}
// Check if session exists
running, err := t.HasSession(DeaconSessionName)
running, err := t.HasSession(sessionName)
if err != nil {
return fmt.Errorf("checking session: %w", err)
}
if !running {
// Auto-start if not running
fmt.Println("Deacon session not running, starting...")
if err := startDeaconSession(t); err != nil {
if err := startDeaconSession(t, sessionName); err != nil {
return err
}
}
// Session uses a respawn loop, so Claude restarts automatically if it exits
// Use shared attach helper (smart: links if inside tmux, attaches if outside)
return attachToTmuxSession(DeaconSessionName)
return attachToTmuxSession(sessionName)
}
func runDeaconStatus(cmd *cobra.Command, args []string) error {
t := tmux.NewTmux()
running, err := t.HasSession(DeaconSessionName)
sessionName, err := getDeaconSessionName()
if err != nil {
return err
}
running, err := t.HasSession(sessionName)
if err != nil {
return fmt.Errorf("checking session: %w", err)
}
if running {
// Get session info for more details
info, err := t.GetSessionInfo(DeaconSessionName)
info, err := t.GetSessionInfo(sessionName)
if err == nil {
status := "detached"
if info.Attached {
@@ -448,7 +479,12 @@ func runDeaconStatus(cmd *cobra.Command, args []string) error {
func runDeaconRestart(cmd *cobra.Command, args []string) error {
t := tmux.NewTmux()
running, err := t.HasSession(DeaconSessionName)
sessionName, err := getDeaconSessionName()
if err != nil {
return err
}
running, err := t.HasSession(sessionName)
if err != nil {
return fmt.Errorf("checking session: %w", err)
}
@@ -457,7 +493,7 @@ func runDeaconRestart(cmd *cobra.Command, args []string) error {
if running {
// Kill existing session
if err := t.KillSession(DeaconSessionName); err != nil {
if err := t.KillSession(sessionName); err != nil {
style.PrintWarning("failed to kill session: %v", err)
}
}
@@ -637,8 +673,14 @@ func runDeaconHealthCheck(cmd *cobra.Command, args []string) error {
return nil
}
// Get town name for session name generation
townName, err := workspace.GetTownName(townRoot)
if err != nil {
return fmt.Errorf("getting town name: %w", err)
}
// Get agent bead info before ping (for baseline)
beadID, sessionName, err := agentAddressToIDs(agent)
beadID, sessionName, err := agentAddressToIDs(agent, townName)
if err != nil {
return fmt.Errorf("invalid agent address: %w", err)
}
@@ -745,8 +787,14 @@ func runDeaconForceKill(cmd *cobra.Command, args []string) error {
agent, remaining.Round(time.Second))
}
// Get town name for session name generation
townName, err := workspace.GetTownName(townRoot)
if err != nil {
return fmt.Errorf("getting town name: %w", err)
}
// Get session name
_, sessionName, err := agentAddressToIDs(agent)
_, sessionName, err := agentAddressToIDs(agent, townName)
if err != nil {
return fmt.Errorf("invalid agent address: %w", err)
}
@@ -1106,12 +1154,15 @@ func notifyMayorOfWitnessFailure(townRoot string, zombies []zombieInfo) {
// agentAddressToIDs converts an agent address to bead ID and session name.
// Supports formats: "gastown/polecats/max", "gastown/witness", "deacon", "mayor"
func agentAddressToIDs(address string) (beadID, sessionName string, err error) {
// The townName parameter is required for mayor/deacon to generate correct session names.
func agentAddressToIDs(address, townName string) (beadID, sessionName string, err error) {
switch address {
case "deacon":
return "gt-deacon", DeaconSessionName, nil
sessName := session.DeaconSessionName(townName)
return sessName, sessName, nil
case "mayor":
return "gt-mayor", "gt-mayor", nil
sessName := session.MayorSessionName(townName)
return sessName, sessName, nil
}
parts := strings.Split(address, "/")
@@ -1176,7 +1227,11 @@ func sendMail(townRoot, to, subject, body string) {
// updateAgentBeadState updates an agent bead's state.
func updateAgentBeadState(townRoot, agent, state, reason string) {
beadID, _, err := agentAddressToIDs(agent)
townName, err := workspace.GetTownName(townRoot)
if err != nil {
return
}
beadID, _, err := agentAddressToIDs(agent, townName)
if err != nil {
return
}
+5 -4
View File
@@ -5,12 +5,13 @@ import (
)
func TestAddressToAgentBeadID(t *testing.T) {
townName := "ai"
tests := []struct {
address string
expected string
}{
{"mayor", "gt-mayor"},
{"deacon", "gt-deacon"},
{"mayor", "gt-ai-mayor"},
{"deacon", "gt-ai-deacon"},
{"gastown/witness", "gt-gastown-witness"},
{"gastown/refinery", "gt-gastown-refinery"},
{"gastown/alpha", "gt-gastown-polecat-alpha"},
@@ -24,9 +25,9 @@ func TestAddressToAgentBeadID(t *testing.T) {
for _, tt := range tests {
t.Run(tt.address, func(t *testing.T) {
got := addressToAgentBeadID(tt.address)
got := addressToAgentBeadID(tt.address, townName)
if got != tt.expected {
t.Errorf("addressToAgentBeadID(%q) = %q, want %q", tt.address, got, tt.expected)
t.Errorf("addressToAgentBeadID(%q, %q) = %q, want %q", tt.address, townName, got, tt.expected)
}
})
}
+7 -4
View File
@@ -483,10 +483,13 @@ func showDogStatus(mgr *dog.Manager, name string) error {
// Check for tmux session
townRoot, _ := workspace.FindFromCwd()
if townRoot != "" {
sessionName := fmt.Sprintf("gt-deacon-%s", name)
tm := tmux.NewTmux()
if has, _ := tm.HasSession(sessionName); has {
fmt.Printf("\nSession: %s (running)\n", sessionName)
townName, err := workspace.GetTownName(townRoot)
if err == nil {
sessionName := fmt.Sprintf("gt-%s-deacon-%s", townName, name)
tm := tmux.NewTmux()
if has, _ := tm.HasSession(sessionName); has {
fmt.Printf("\nSession: %s (running)\n", sessionName)
}
}
}
+6 -2
View File
@@ -73,8 +73,12 @@ func runDown(cmd *cobra.Command, args []string) error {
}
}
// Get session names
mayorSession, _ := getMayorSessionName()
deaconSession, _ := getDeaconSessionName()
// 2. Stop Mayor
if err := stopSession(t, MayorSessionName); err != nil {
if err := stopSession(t, mayorSession); err != nil {
printDownStatus("Mayor", false, err.Error())
allOK = false
} else {
@@ -90,7 +94,7 @@ func runDown(cmd *cobra.Command, args []string) error {
}
// 4. Stop Deacon
if err := stopSession(t, DeaconSessionName); err != nil {
if err := stopSession(t, deaconSession); err != nil {
printDownStatus("Deacon", false, err.Error())
allOK = false
} else {
+16 -4
View File
@@ -230,10 +230,18 @@ func resolveRoleToSession(role string) (string, error) {
switch strings.ToLower(role) {
case "mayor", "may":
return "gt-mayor", nil
mayorSession, err := getMayorSessionName()
if err != nil {
return "", fmt.Errorf("cannot determine mayor session name: %w", err)
}
return mayorSession, nil
case "deacon", "dea":
return "gt-deacon", nil
deaconSession, err := getDeaconSessionName()
if err != nil {
return "", fmt.Errorf("cannot determine deacon session name: %w", err)
}
return deaconSession, nil
case "crew":
// Try to get rig and crew name from environment or cwd
@@ -360,11 +368,15 @@ func buildRestartCommand(sessionName string) (string, error) {
// sessionWorkDir returns the correct working directory for a session.
// This is the canonical home for each role type.
func sessionWorkDir(sessionName, townRoot string) (string, error) {
// Get session names for comparison
mayorSession, _ := getMayorSessionName()
deaconSession, _ := getDeaconSessionName()
switch {
case sessionName == "gt-mayor":
case sessionName == mayorSession:
return townRoot, nil
case sessionName == "gt-deacon":
case sessionName == deaconSession:
return townRoot + "/deacon", nil
case strings.Contains(sessionName, "-crew-"):
+10 -3
View File
@@ -12,6 +12,7 @@ import (
"github.com/spf13/cobra"
"github.com/steveyegge/gastown/internal/config"
"github.com/steveyegge/gastown/internal/deps"
"github.com/steveyegge/gastown/internal/session"
"github.com/steveyegge/gastown/internal/style"
"github.com/steveyegge/gastown/internal/templates"
"github.com/steveyegge/gastown/internal/workspace"
@@ -252,10 +253,16 @@ func createMayorCLAUDEmd(hqRoot, townRoot string) error {
return err
}
// Get town name for session names
townName, _ := workspace.GetTownName(townRoot)
data := templates.RoleData{
Role: "mayor",
TownRoot: townRoot,
WorkDir: hqRoot,
Role: "mayor",
TownRoot: townRoot,
TownName: townName,
WorkDir: hqRoot,
MayorSession: session.MayorSessionName(townName),
DeaconSession: session.DeaconSessionName(townName),
}
content, err := tmpl.RenderRole("mayor", data)
+4 -1
View File
@@ -122,7 +122,10 @@ func detectCurrentSession() string {
// Check if we're mayor
if os.Getenv("GT_ROLE") == "mayor" {
return "gt-mayor"
mayorSession, err := getMayorSessionName()
if err == nil {
return mayorSession
}
}
return ""
+60 -24
View File
@@ -14,8 +14,19 @@ import (
"github.com/steveyegge/gastown/internal/workspace"
)
// MayorSessionName is the tmux session name for the Mayor.
const MayorSessionName = "gt-mayor"
// getMayorSessionName returns the Mayor session name for the current workspace.
// The session name includes the town name to avoid collisions between multiple HQs.
func getMayorSessionName() (string, error) {
townRoot, err := workspace.FindFromCwdOrError()
if err != nil {
return "", fmt.Errorf("not in a Gas Town workspace: %w", err)
}
townName, err := workspace.GetTownName(townRoot)
if err != nil {
return "", err
}
return session.MayorSessionName(townName), nil
}
var mayorCmd = &cobra.Command{
Use: "mayor",
@@ -88,8 +99,13 @@ func init() {
func runMayorStart(cmd *cobra.Command, args []string) error {
t := tmux.NewTmux()
sessionName, err := getMayorSessionName()
if err != nil {
return err
}
// Check if session already exists
running, err := t.HasSession(MayorSessionName)
running, err := t.HasSession(sessionName)
if err != nil {
return fmt.Errorf("checking session: %w", err)
}
@@ -97,7 +113,7 @@ func runMayorStart(cmd *cobra.Command, args []string) error {
return fmt.Errorf("Mayor session already running. Attach with: gt mayor attach")
}
if err := startMayorSession(t); err != nil {
if err := startMayorSession(t, sessionName); err != nil {
return err
}
@@ -109,7 +125,7 @@ func runMayorStart(cmd *cobra.Command, args []string) error {
}
// startMayorSession creates and initializes the Mayor tmux session.
func startMayorSession(t *tmux.Tmux) error {
func startMayorSession(t *tmux.Tmux, sessionName string) error {
// Find workspace root
townRoot, err := workspace.FindFromCwdOrError()
if err != nil {
@@ -118,36 +134,36 @@ func startMayorSession(t *tmux.Tmux) error {
// Create session in workspace root
fmt.Println("Starting Mayor session...")
if err := t.NewSession(MayorSessionName, townRoot); err != nil {
if err := t.NewSession(sessionName, townRoot); err != nil {
return fmt.Errorf("creating session: %w", err)
}
// Set environment (non-fatal: session works without these)
_ = t.SetEnvironment(MayorSessionName, "GT_ROLE", "mayor")
_ = t.SetEnvironment(MayorSessionName, "BD_ACTOR", "mayor")
_ = t.SetEnvironment(sessionName, "GT_ROLE", "mayor")
_ = t.SetEnvironment(sessionName, "BD_ACTOR", "mayor")
// Apply Mayor theme (non-fatal: theming failure doesn't affect operation)
// Note: ConfigureGasTownSession includes cycle bindings
theme := tmux.MayorTheme()
_ = t.ConfigureGasTownSession(MayorSessionName, theme, "", "Mayor", "coordinator")
_ = t.ConfigureGasTownSession(sessionName, theme, "", "Mayor", "coordinator")
// Launch Claude - the startup hook handles 'gt prime' automatically
// Use SendKeysDelayed to allow shell initialization after NewSession
// Export GT_ROLE and BD_ACTOR in the command since tmux SetEnvironment only affects new panes
// Mayor uses default runtime config (empty rigPath) since it's not rig-specific
claudeCmd := config.BuildAgentStartupCommand("mayor", "mayor", "", "")
if err := t.SendKeysDelayed(MayorSessionName, claudeCmd, 200); err != nil {
if err := t.SendKeysDelayed(sessionName, claudeCmd, 200); err != nil {
return fmt.Errorf("sending command: %w", err)
}
// Wait for Claude to start (non-fatal)
if err := t.WaitForCommand(MayorSessionName, constants.SupportedShells, constants.ClaudeStartTimeout); err != nil {
if err := t.WaitForCommand(sessionName, constants.SupportedShells, constants.ClaudeStartTimeout); err != nil {
// Non-fatal
}
time.Sleep(constants.ShutdownNotifyDelay)
// Inject startup nudge for predecessor discovery via /resume
_ = session.StartupNudge(t, MayorSessionName, session.StartupNudgeConfig{
_ = session.StartupNudge(t, sessionName, session.StartupNudgeConfig{
Recipient: "mayor",
Sender: "human",
Topic: "cold-start",
@@ -157,7 +173,7 @@ func startMayorSession(t *tmux.Tmux) error {
// Send the propulsion nudge to trigger autonomous coordination.
// Wait for beacon to be fully processed (needs to be separate prompt)
time.Sleep(2 * time.Second)
_ = t.NudgeSession(MayorSessionName, session.PropulsionNudgeForRole("mayor", townRoot)) // Non-fatal
_ = t.NudgeSession(sessionName, session.PropulsionNudgeForRole("mayor", townRoot)) // Non-fatal
return nil
}
@@ -165,8 +181,13 @@ func startMayorSession(t *tmux.Tmux) error {
func runMayorStop(cmd *cobra.Command, args []string) error {
t := tmux.NewTmux()
sessionName, err := getMayorSessionName()
if err != nil {
return err
}
// Check if session exists
running, err := t.HasSession(MayorSessionName)
running, err := t.HasSession(sessionName)
if err != nil {
return fmt.Errorf("checking session: %w", err)
}
@@ -177,11 +198,11 @@ func runMayorStop(cmd *cobra.Command, args []string) error {
fmt.Println("Stopping Mayor session...")
// Try graceful shutdown first (best-effort interrupt)
_ = t.SendKeysRaw(MayorSessionName, "C-c")
_ = t.SendKeysRaw(sessionName, "C-c")
time.Sleep(100 * time.Millisecond)
// Kill the session
if err := t.KillSession(MayorSessionName); err != nil {
if err := t.KillSession(sessionName); err != nil {
return fmt.Errorf("killing session: %w", err)
}
@@ -192,34 +213,44 @@ func runMayorStop(cmd *cobra.Command, args []string) error {
func runMayorAttach(cmd *cobra.Command, args []string) error {
t := tmux.NewTmux()
sessionName, err := getMayorSessionName()
if err != nil {
return err
}
// Check if session exists
running, err := t.HasSession(MayorSessionName)
running, err := t.HasSession(sessionName)
if err != nil {
return fmt.Errorf("checking session: %w", err)
}
if !running {
// Auto-start if not running
fmt.Println("Mayor session not running, starting...")
if err := startMayorSession(t); err != nil {
if err := startMayorSession(t, sessionName); err != nil {
return err
}
}
// Use shared attach helper (smart: links if inside tmux, attaches if outside)
return attachToTmuxSession(MayorSessionName)
return attachToTmuxSession(sessionName)
}
func runMayorStatus(cmd *cobra.Command, args []string) error {
t := tmux.NewTmux()
running, err := t.HasSession(MayorSessionName)
sessionName, err := getMayorSessionName()
if err != nil {
return err
}
running, err := t.HasSession(sessionName)
if err != nil {
return fmt.Errorf("checking session: %w", err)
}
if running {
// Get session info for more details
info, err := t.GetSessionInfo(MayorSessionName)
info, err := t.GetSessionInfo(sessionName)
if err == nil {
status := "detached"
if info.Attached {
@@ -249,7 +280,12 @@ func runMayorStatus(cmd *cobra.Command, args []string) error {
func runMayorRestart(cmd *cobra.Command, args []string) error {
t := tmux.NewTmux()
running, err := t.HasSession(MayorSessionName)
sessionName, err := getMayorSessionName()
if err != nil {
return err
}
running, err := t.HasSession(sessionName)
if err != nil {
return fmt.Errorf("checking session: %w", err)
}
@@ -257,9 +293,9 @@ func runMayorRestart(cmd *cobra.Command, args []string) error {
if running {
// Stop the current session (best-effort interrupt before kill)
fmt.Println("Stopping Mayor session...")
_ = t.SendKeysRaw(MayorSessionName, "C-c")
_ = t.SendKeysRaw(sessionName, "C-c")
time.Sleep(100 * time.Millisecond)
if err := t.KillSession(MayorSessionName); err != nil {
if err := t.KillSession(sessionName); err != nil {
return fmt.Errorf("killing session: %w", err)
}
}
+29 -14
View File
@@ -120,11 +120,17 @@ func runNudge(cmd *cobra.Command, args []string) error {
t := tmux.NewTmux()
// Get session names for this town
townName := ""
if townRoot != "" {
townName, _ = workspace.GetTownName(townRoot)
}
// Expand role shortcuts to session names
// These shortcuts let users type "mayor" instead of "gt-mayor"
// These shortcuts let users type "mayor" instead of "gt-{town}-mayor"
switch target {
case "mayor":
target = session.MayorSessionName()
target = session.MayorSessionName(townName)
case "witness", "refinery":
// These need the current rig
roleInfo, err := GetRole()
@@ -143,8 +149,9 @@ func runNudge(cmd *cobra.Command, args []string) error {
// Special case: "deacon" target maps to the Deacon session
if target == "deacon" {
deaconSession := session.DeaconSessionName(townName)
// Check if Deacon session exists
exists, err := t.HasSession(DeaconSessionName)
exists, err := t.HasSession(deaconSession)
if err != nil {
return fmt.Errorf("checking deacon session: %w", err)
}
@@ -154,7 +161,7 @@ func runNudge(cmd *cobra.Command, args []string) error {
return nil
}
if err := t.NudgeSession(DeaconSessionName, message); err != nil {
if err := t.NudgeSession(deaconSession, message); err != nil {
return fmt.Errorf("nudging deacon: %w", err)
}
@@ -279,6 +286,9 @@ func runNudgeChannel(channelName, message string) error {
// Prefix message with sender
prefixedMessage := fmt.Sprintf("[from %s] %s", sender, message)
// Get town name for session names
townName, _ := workspace.GetTownName(townRoot)
// Get all running sessions for pattern matching
agents, err := getAgentSessions(true)
if err != nil {
@@ -290,7 +300,7 @@ func runNudgeChannel(channelName, message string) error {
seenTargets := make(map[string]bool)
for _, pattern := range patterns {
resolved := resolveNudgePattern(pattern, agents)
resolved := resolveNudgePattern(pattern, agents, townName)
for _, sessionName := range resolved {
if !seenTargets[sessionName] {
seenTargets[sessionName] = true
@@ -350,16 +360,17 @@ func runNudgeChannel(channelName, message string) error {
// - Literal: "gastown/witness" → gt-gastown-witness
// - Wildcard: "gastown/polecats/*" → all polecat sessions in gastown
// - Role: "*/witness" → all witness sessions
// - Special: "mayor", "deacon" → gt-mayor, gt-deacon
func resolveNudgePattern(pattern string, agents []*AgentSession) []string {
// - Special: "mayor", "deacon" → gt-{town}-mayor, gt-{town}-deacon
// townName is used to generate the correct session names for mayor/deacon.
func resolveNudgePattern(pattern string, agents []*AgentSession, townName string) []string {
var results []string
// Handle special cases
switch pattern {
case "mayor":
return []string{session.MayorSessionName()}
return []string{session.MayorSessionName(townName)}
case "deacon":
return []string{DeaconSessionName}
return []string{session.DeaconSessionName(townName)}
}
// Parse pattern
@@ -427,8 +438,11 @@ func shouldNudgeTarget(townRoot, targetAddress string, force bool) (bool, string
return true, "", nil
}
// Get town name for session name generation
townName, _ := workspace.GetTownName(townRoot)
// Try to determine agent bead ID from address
agentBeadID := addressToAgentBeadID(targetAddress)
agentBeadID := addressToAgentBeadID(targetAddress, townName)
if agentBeadID == "" {
// Can't determine agent bead, allow the nudge
return true, "", nil
@@ -447,18 +461,19 @@ func shouldNudgeTarget(townRoot, targetAddress string, force bool) (bool, string
// addressToAgentBeadID converts a target address to an agent bead ID.
// Examples:
// - "mayor" -> "gt-mayor" (or similar)
// - "mayor" -> "gt-{town}-mayor"
// - "deacon" -> "gt-{town}-deacon"
// - "gastown/witness" -> "gt-gastown-witness"
// - "gastown/alpha" -> "gt-gastown-polecat-alpha"
//
// Returns empty string if the address cannot be converted.
func addressToAgentBeadID(address string) string {
func addressToAgentBeadID(address, townName string) string {
// Handle special cases
switch address {
case "mayor":
return "gt-mayor"
return session.MayorSessionName(townName)
case "deacon":
return "gt-deacon"
return session.DeaconSessionName(townName)
}
// Parse rig/role format
+6 -5
View File
@@ -7,8 +7,8 @@ import (
func TestResolveNudgePattern(t *testing.T) {
// Create test agent sessions
agents := []*AgentSession{
{Name: "gt-mayor", Type: AgentMayor},
{Name: "gt-deacon", Type: AgentDeacon},
{Name: "gt-ai-mayor", Type: AgentMayor, Town: "ai"},
{Name: "gt-ai-deacon", Type: AgentDeacon, Town: "ai"},
{Name: "gt-gastown-witness", Type: AgentWitness, Rig: "gastown"},
{Name: "gt-gastown-refinery", Type: AgentRefinery, Rig: "gastown"},
{Name: "gt-gastown-crew-max", Type: AgentCrew, Rig: "gastown", AgentName: "max"},
@@ -27,12 +27,12 @@ func TestResolveNudgePattern(t *testing.T) {
{
name: "mayor special case",
pattern: "mayor",
expected: []string{"gt-mayor"},
expected: []string{"gt-ai-mayor"},
},
{
name: "deacon special case",
pattern: "deacon",
expected: []string{"gt-deacon"},
expected: []string{"gt-ai-deacon"},
},
{
name: "specific witness",
@@ -86,9 +86,10 @@ func TestResolveNudgePattern(t *testing.T) {
},
}
townName := "ai"
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := resolveNudgePattern(tt.pattern, agents)
got := resolveNudgePattern(tt.pattern, agents, townName)
if len(got) != len(tt.expected) {
t.Errorf("resolveNudgePattern(%q) returned %d results, want %d: got %v, want %v",
+10 -2
View File
@@ -88,8 +88,16 @@ func parsePolecatSessionName(sessionName string) (rigName, polecatName string, o
return "", "", false
}
// Exclude town-level sessions
if sessionName == "gt-mayor" || sessionName == "gt-deacon" {
// Exclude town-level sessions by exact match
mayorSession, _ := getMayorSessionName()
deaconSession, _ := getDeaconSessionName()
if sessionName == mayorSession || sessionName == deaconSession {
return "", "", false
}
// Also exclude by suffix pattern (gt-{town}-mayor, gt-{town}-deacon)
// This handles cases where town config isn't available
if strings.HasSuffix(sessionName, "-mayor") || strings.HasSuffix(sessionName, "-deacon") {
return "", "", false
}
+2 -2
View File
@@ -64,14 +64,14 @@ func TestParsePolecatSessionName(t *testing.T) {
},
{
name: "mayor session",
sessionName: "gt-mayor",
sessionName: "gt-ai-mayor",
wantRig: "",
wantPolecat: "",
wantOk: false,
},
{
name: "deacon session",
sessionName: "gt-deacon",
sessionName: "gt-ai-deacon",
wantRig: "",
wantPolecat: "",
wantOk: false,
+12 -5
View File
@@ -19,6 +19,7 @@ import (
"github.com/steveyegge/gastown/internal/constants"
"github.com/steveyegge/gastown/internal/events"
"github.com/steveyegge/gastown/internal/lock"
"github.com/steveyegge/gastown/internal/session"
"github.com/steveyegge/gastown/internal/style"
"github.com/steveyegge/gastown/internal/templates"
"github.com/steveyegge/gastown/internal/workspace"
@@ -304,12 +305,18 @@ func outputPrimeContext(ctx RoleContext) error {
}
// Build template data
// Get town name for session names
townName, _ := workspace.GetTownName(ctx.TownRoot)
data := templates.RoleData{
Role: roleName,
RigName: ctx.Rig,
TownRoot: ctx.TownRoot,
WorkDir: ctx.WorkDir,
Polecat: ctx.Polecat,
Role: roleName,
RigName: ctx.Rig,
TownRoot: ctx.TownRoot,
TownName: townName,
WorkDir: ctx.WorkDir,
Polecat: ctx.Polecat,
MayorSession: session.MayorSessionName(townName),
DeaconSession: session.DeaconSessionName(townName),
}
// Render and output
+3 -1
View File
@@ -1117,7 +1117,9 @@ func DispatchToDog(dogName string, create bool) (*DogDispatchInfo, error) {
agentID := fmt.Sprintf("deacon/dogs/%s", targetDog.Name)
// Try to find tmux session for the dog (dogs may run in tmux like polecats)
sessionName := fmt.Sprintf("gt-deacon-%s", targetDog.Name)
// Dogs use the pattern gt-{town}-deacon-{name}
townName, _ := workspace.GetTownName(townRoot)
sessionName := fmt.Sprintf("gt-%s-deacon-%s", townName, targetDog.Name)
t := tmux.NewTmux()
var pane string
if has, _ := t.HasSession(sessionName); has {
+36 -17
View File
@@ -178,25 +178,35 @@ func runStart(cmd *cobra.Command, args []string) error {
// startCoreAgents starts Mayor and Deacon sessions.
func startCoreAgents(t *tmux.Tmux) error {
// Get session names
mayorSession, err := getMayorSessionName()
if err != nil {
return fmt.Errorf("getting Mayor session name: %w", err)
}
deaconSession, err := getDeaconSessionName()
if err != nil {
return fmt.Errorf("getting Deacon session name: %w", err)
}
// Start Mayor first (so Deacon sees it as up)
mayorRunning, _ := t.HasSession(MayorSessionName)
mayorRunning, _ := t.HasSession(mayorSession)
if mayorRunning {
fmt.Printf(" %s Mayor already running\n", style.Dim.Render("○"))
} else {
fmt.Printf(" %s Starting Mayor...\n", style.Bold.Render("→"))
if err := startMayorSession(t); err != nil {
if err := startMayorSession(t, mayorSession); err != nil {
return fmt.Errorf("starting Mayor: %w", err)
}
fmt.Printf(" %s Mayor started\n", style.Bold.Render("✓"))
}
// Start Deacon (health monitor)
deaconRunning, _ := t.HasSession(DeaconSessionName)
deaconRunning, _ := t.HasSession(deaconSession)
if deaconRunning {
fmt.Printf(" %s Deacon already running\n", style.Dim.Render("○"))
} else {
fmt.Printf(" %s Starting Deacon...\n", style.Bold.Render("→"))
if err := startDeaconSession(t); err != nil {
if err := startDeaconSession(t, deaconSession); err != nil {
return fmt.Errorf("starting Deacon: %w", err)
}
fmt.Printf(" %s Deacon started\n", style.Bold.Render("✓"))
@@ -380,7 +390,10 @@ func runShutdown(cmd *cobra.Command, args []string) error {
return fmt.Errorf("listing sessions: %w", err)
}
toStop, preserved := categorizeSessions(sessions)
// Get session names for categorization
mayorSession, _ := getMayorSessionName()
deaconSession, _ := getDeaconSessionName()
toStop, preserved := categorizeSessions(sessions, mayorSession, deaconSession)
if len(toStop) == 0 {
fmt.Printf("%s Gas Town was not running\n", style.Dim.Render("○"))
@@ -420,7 +433,8 @@ func runShutdown(cmd *cobra.Command, args []string) error {
}
// categorizeSessions splits sessions into those to stop and those to preserve.
func categorizeSessions(sessions []string) (toStop, preserved []string) {
// mayorSession and deaconSession are the dynamic session names for the current town.
func categorizeSessions(sessions []string, mayorSession, deaconSession string) (toStop, preserved []string) {
for _, sess := range sessions {
if !strings.HasPrefix(sess, "gt-") {
continue // Not a Gas Town session
@@ -431,7 +445,7 @@ func categorizeSessions(sessions []string) (toStop, preserved []string) {
// Check if it's a polecat session (pattern: gt-<rig>-<name> where name is not crew/witness/refinery)
isPolecat := false
if !isCrew && sess != MayorSessionName && sess != DeaconSessionName {
if !isCrew && sess != mayorSession && sess != deaconSession {
parts := strings.Split(sess, "-")
if len(parts) >= 3 {
role := parts[2]
@@ -501,7 +515,9 @@ func runGracefulShutdown(t *tmux.Tmux, gtSessions []string, townRoot string) err
// Phase 4: Kill sessions in correct order
fmt.Printf("\nPhase 4: Terminating sessions...\n")
stopped := killSessionsInOrder(t, gtSessions)
mayorSession, _ := getMayorSessionName()
deaconSession, _ := getDeaconSessionName()
stopped := killSessionsInOrder(t, gtSessions, mayorSession, deaconSession)
// Phase 5: Cleanup polecat worktrees and branches
fmt.Printf("\nPhase 5: Cleaning up polecats...\n")
@@ -517,7 +533,9 @@ func runGracefulShutdown(t *tmux.Tmux, gtSessions []string, townRoot string) err
func runImmediateShutdown(t *tmux.Tmux, gtSessions []string, townRoot string) error {
fmt.Println("Shutting down Gas Town...")
stopped := killSessionsInOrder(t, gtSessions)
mayorSession, _ := getMayorSessionName()
deaconSession, _ := getDeaconSessionName()
stopped := killSessionsInOrder(t, gtSessions, mayorSession, deaconSession)
// Cleanup polecat worktrees and branches
if townRoot != "" {
@@ -536,7 +554,8 @@ func runImmediateShutdown(t *tmux.Tmux, gtSessions []string, townRoot string) er
// 1. Deacon first (so it doesn't restart others)
// 2. Everything except Mayor
// 3. Mayor last
func killSessionsInOrder(t *tmux.Tmux, sessions []string) int {
// mayorSession and deaconSession are the dynamic session names for the current town.
func killSessionsInOrder(t *tmux.Tmux, sessions []string, mayorSession, deaconSession string) int {
stopped := 0
// Helper to check if session is in our list
@@ -550,16 +569,16 @@ func killSessionsInOrder(t *tmux.Tmux, sessions []string) int {
}
// 1. Stop Deacon first
if inList(DeaconSessionName) {
if err := t.KillSession(DeaconSessionName); err == nil {
fmt.Printf(" %s %s stopped\n", style.Bold.Render("✓"), DeaconSessionName)
if inList(deaconSession) {
if err := t.KillSession(deaconSession); err == nil {
fmt.Printf(" %s %s stopped\n", style.Bold.Render("✓"), deaconSession)
stopped++
}
}
// 2. Stop others (except Mayor)
for _, sess := range sessions {
if sess == DeaconSessionName || sess == MayorSessionName {
if sess == deaconSession || sess == mayorSession {
continue
}
if err := t.KillSession(sess); err == nil {
@@ -569,9 +588,9 @@ func killSessionsInOrder(t *tmux.Tmux, sessions []string) int {
}
// 3. Stop Mayor last
if inList(MayorSessionName) {
if err := t.KillSession(MayorSessionName); err == nil {
fmt.Printf(" %s %s stopped\n", style.Bold.Render("✓"), MayorSessionName)
if inList(mayorSession) {
if err := t.KillSession(mayorSession); err == nil {
fmt.Printf(" %s %s stopped\n", style.Bold.Render("✓"), mayorSession)
stopped++
}
}
+6 -2
View File
@@ -645,6 +645,10 @@ func discoverRigHooks(r *rig.Rig, crews []string) []AgentHookInfo {
// allAgentBeads is a preloaded map of agent beads for O(1) lookup.
// allHookBeads is a preloaded map of hook beads for O(1) lookup.
func discoverGlobalAgents(allSessions map[string]bool, allAgentBeads map[string]*beads.Issue, allHookBeads map[string]*beads.Issue, mailRouter *mail.Router, skipMail bool) []AgentRuntime {
// Get session names dynamically
mayorSession, _ := getMayorSessionName()
deaconSession, _ := getDeaconSessionName()
// Define agents to discover
agentDefs := []struct {
name string
@@ -653,8 +657,8 @@ func discoverGlobalAgents(allSessions map[string]bool, allAgentBeads map[string]
role string
beadID string
}{
{"mayor", "mayor/", MayorSessionName, "coordinator", "gt-mayor"},
{"deacon", "deacon/", DeaconSessionName, "health-check", "gt-deacon"},
{"mayor", "mayor/", mayorSession, "coordinator", mayorSession},
{"deacon", "deacon/", deaconSession, "health-check", deaconSession},
}
agents := make([]AgentRuntime, len(agentDefs))
+10 -4
View File
@@ -52,13 +52,17 @@ func runStatusLine(cmd *cobra.Command, args []string) error {
role = os.Getenv("GT_ROLE")
}
// Get session names for comparison
mayorSession, _ := getMayorSessionName()
deaconSession, _ := getDeaconSessionName()
// Determine identity and output based on role
if role == "mayor" || statusLineSession == "gt-mayor" {
if role == "mayor" || statusLineSession == mayorSession {
return runMayorStatusLine(t)
}
// Deacon status line
if role == "deacon" || statusLineSession == "gt-deacon" {
if role == "deacon" || statusLineSession == deaconSession {
return runDeaconStatusLine(t)
}
@@ -160,7 +164,8 @@ func runMayorStatusLine(t *tmux.Tmux) error {
// Get town root from mayor pane's working directory
var townRoot string
paneDir, err := t.GetPaneWorkDir("gt-mayor")
mayorSession, _ := getMayorSessionName()
paneDir, err := t.GetPaneWorkDir(mayorSession)
if err == nil && paneDir != "" {
townRoot, _ = workspace.Find(paneDir)
}
@@ -236,7 +241,8 @@ func runDeaconStatusLine(t *tmux.Tmux) error {
// Get town root from deacon pane's working directory
var townRoot string
paneDir, err := t.GetPaneWorkDir("gt-deacon")
deaconSession, _ := getDeaconSessionName()
paneDir, err := t.GetPaneWorkDir(deaconSession)
if err == nil && paneDir != "" {
townRoot, _ = workspace.Find(paneDir)
}
+4 -4
View File
@@ -31,8 +31,8 @@ func TestCategorizeSessionRig(t *testing.T) {
{"gt-a-b", "a"}, // minimum valid
// Town-level agents (no rig)
{"gt-mayor", ""},
{"gt-deacon", ""},
{"gt-ai-mayor", ""},
{"gt-ai-deacon", ""},
}
for _, tt := range tests {
@@ -68,8 +68,8 @@ func TestCategorizeSessionType(t *testing.T) {
{"gt-myrig-crew-user", AgentCrew},
// Town-level agents
{"gt-mayor", AgentMayor},
{"gt-deacon", AgentDeacon},
{"gt-ai-mayor", AgentMayor},
{"gt-ai-deacon", AgentDeacon},
}
for _, tt := range tests {
+25 -14
View File
@@ -8,6 +8,7 @@ import (
"github.com/spf13/cobra"
"github.com/steveyegge/gastown/internal/config"
"github.com/steveyegge/gastown/internal/session"
"github.com/steveyegge/gastown/internal/tmux"
"github.com/steveyegge/gastown/internal/workspace"
)
@@ -116,10 +117,20 @@ func runThemeApply(cmd *cobra.Command, args []string) error {
// Determine current rig
rigName := detectCurrentRig()
// Get town name for session name comparison
var mayorSession, deaconSession string
townRoot, err := workspace.FindFromCwd()
if err == nil && townRoot != "" {
if townName, err := workspace.GetTownName(townRoot); err == nil {
mayorSession = session.MayorSessionName(townName)
deaconSession = session.DeaconSessionName(townName)
}
}
// Apply to matching sessions
applied := 0
for _, session := range sessions {
if !strings.HasPrefix(session, "gt-") {
for _, sess := range sessions {
if !strings.HasPrefix(sess, "gt-") {
continue
}
@@ -127,23 +138,23 @@ func runThemeApply(cmd *cobra.Command, args []string) error {
var theme tmux.Theme
var rig, worker, role string
if session == "gt-mayor" {
if sess == mayorSession {
theme = tmux.MayorTheme()
worker = "Mayor"
role = "coordinator"
} else if session == "gt-deacon" {
} else if sess == deaconSession {
theme = tmux.DeaconTheme()
worker = "Deacon"
role = "health-check"
} else if strings.HasSuffix(session, "-witness") && strings.HasPrefix(session, "gt-") {
} else if strings.HasSuffix(sess, "-witness") && strings.HasPrefix(sess, "gt-") {
// Witness sessions: gt-<rig>-witness
rig = strings.TrimPrefix(strings.TrimSuffix(session, "-witness"), "gt-")
rig = strings.TrimPrefix(strings.TrimSuffix(sess, "-witness"), "gt-")
theme = getThemeForRole(rig, "witness")
worker = "witness"
role = "witness"
} else {
// Parse session name: gt-<rig>-<worker> or gt-<rig>-crew-<name>
parts := strings.SplitN(session, "-", 3)
parts := strings.SplitN(sess, "-", 3)
if len(parts) < 3 {
continue
}
@@ -171,20 +182,20 @@ func runThemeApply(cmd *cobra.Command, args []string) error {
}
// Apply theme and status format
if err := t.ApplyTheme(session, theme); err != nil {
fmt.Printf(" %s: failed (%v)\n", session, err)
if err := t.ApplyTheme(sess, theme); err != nil {
fmt.Printf(" %s: failed (%v)\n", sess, err)
continue
}
if err := t.SetStatusFormat(session, rig, worker, role); err != nil {
fmt.Printf(" %s: failed to set format (%v)\n", session, err)
if err := t.SetStatusFormat(sess, rig, worker, role); err != nil {
fmt.Printf(" %s: failed to set format (%v)\n", sess, err)
continue
}
if err := t.SetDynamicStatus(session); err != nil {
fmt.Printf(" %s: failed to set dynamic status (%v)\n", session, err)
if err := t.SetDynamicStatus(sess); err != nil {
fmt.Printf(" %s: failed to set dynamic status (%v)\n", sess, err)
continue
}
fmt.Printf(" %s: applied %s theme\n", session, theme.Name)
fmt.Printf(" %s: applied %s theme\n", sess, theme.Name)
applied++
}
+34 -12
View File
@@ -6,6 +6,7 @@ import (
"sort"
"github.com/spf13/cobra"
"github.com/steveyegge/gastown/internal/workspace"
)
// townCycleSession is the --session flag for town next/prev commands.
@@ -13,9 +14,32 @@ import (
// correct, so we pass the session name explicitly via #{session_name} expansion.
var townCycleSession string
// Town-level sessions that participate in cycling (mayor, deacon).
// These are the session names without the "gt-" prefix.
var townLevelSessions = []string{"gt-mayor", "gt-deacon"}
// getTownLevelSessions returns the town-level session names for the current workspace.
// Returns empty slice if workspace cannot be determined.
func getTownLevelSessions() []string {
mayorSession, errMayor := getMayorSessionName()
deaconSession, errDeacon := getDeaconSessionName()
if errMayor != nil || errDeacon != nil {
return nil
}
return []string{mayorSession, deaconSession}
}
// isTownLevelSession checks if the given session name is a town-level session.
func isTownLevelSession(sessionName string) bool {
townRoot, err := workspace.FindFromCwd()
if err != nil || townRoot == "" {
return false
}
townName, err := workspace.GetTownName(townRoot)
if err != nil {
return false
}
mayorSession, _ := getMayorSessionName()
deaconSession, _ := getDeaconSessionName()
_ = townName // used for session name generation
return sessionName == mayorSession || sessionName == deaconSession
}
func init() {
rootCmd.AddCommand(townCmd)
@@ -78,15 +102,7 @@ func cycleTownSession(direction int, sessionOverride string) error {
}
// Check if current session is a town-level session
isTownSession := false
for _, s := range townLevelSessions {
if s == currentSession {
isTownSession = true
break
}
}
if !isTownSession {
if !isTownLevelSession(currentSession) {
// Not a town session - no cycling, just stay put
return nil
}
@@ -145,6 +161,12 @@ func findRunningTownSessions() ([]string, error) {
return nil, fmt.Errorf("listing tmux sessions: %w", err)
}
// Get town-level session names
townLevelSessions := getTownLevelSessions()
if townLevelSessions == nil {
return nil, fmt.Errorf("cannot determine town-level sessions")
}
var running []string
for _, line := range splitLines(string(out)) {
if line == "" {
+8 -4
View File
@@ -79,20 +79,24 @@ func runUp(cmd *cobra.Command, args []string) error {
}
}
// Get session names
deaconSession, _ := getDeaconSessionName()
mayorSession, _ := getMayorSessionName()
// 2. Deacon (Claude agent)
if err := ensureSession(t, DeaconSessionName, townRoot, "deacon"); err != nil {
if err := ensureSession(t, deaconSession, townRoot, "deacon"); err != nil {
printStatus("Deacon", false, err.Error())
allOK = false
} else {
printStatus("Deacon", true, "gt-deacon")
printStatus("Deacon", true, deaconSession)
}
// 3. Mayor (Claude agent)
if err := ensureSession(t, MayorSessionName, townRoot, "mayor"); err != nil {
if err := ensureSession(t, mayorSession, townRoot, "mayor"); err != nil {
printStatus("Mayor", false, err.Error())
allOK = false
} else {
printStatus("Mayor", true, "gt-mayor")
printStatus("Mayor", true, mayorSession)
}
// 4. Witnesses (one per rig)
+2 -6
View File
@@ -90,13 +90,9 @@ const (
)
// Tmux session names.
// Note: Mayor and Deacon session names are now dynamic (include town name).
// Use session.MayorSessionName(townName) and session.DeaconSessionName(townName).
const (
// SessionMayor is the tmux session name for the mayor.
SessionMayor = "gt-mayor"
// SessionDeacon is the tmux session name for the deacon.
SessionDeacon = "gt-deacon"
// SessionPrefix is the prefix for all Gas Town tmux sessions.
SessionPrefix = "gt-"
)
+28 -14
View File
@@ -20,7 +20,9 @@ import (
"github.com/steveyegge/gastown/internal/deacon"
"github.com/steveyegge/gastown/internal/feed"
"github.com/steveyegge/gastown/internal/polecat"
"github.com/steveyegge/gastown/internal/session"
"github.com/steveyegge/gastown/internal/tmux"
"github.com/steveyegge/gastown/internal/workspace"
)
// Daemon is the town-level background service.
@@ -188,12 +190,20 @@ func (d *Daemon) heartbeat(state *State) {
d.logger.Printf("Heartbeat complete (#%d)", state.HeartbeatCount)
}
// DeaconSessionName is the tmux session name for the Deacon.
const DeaconSessionName = "gt-deacon"
// DeaconRole is the role name for the Deacon's handoff bead.
const DeaconRole = "deacon"
// getDeaconSessionName returns the Deacon session name for the daemon's town.
func (d *Daemon) getDeaconSessionName() string {
townName, err := workspace.GetTownName(d.config.TownRoot)
if err != nil {
// Fallback to legacy name if town config can't be loaded
d.logger.Printf("Warning: failed to get town name: %v, using fallback", err)
return "gt-deacon"
}
return session.DeaconSessionName(townName)
}
// ensureBootRunning spawns Boot to triage the Deacon.
// Boot is a fresh-each-tick watchdog that decides whether to start/wake/nudge
// the Deacon, centralizing the "when to wake" decision in an agent.
@@ -238,7 +248,7 @@ func (d *Daemon) runDegradedBootTriage(b *boot.Boot) {
}
// Simple check: is Deacon session alive?
hasDeacon, err := d.tmux.HasSession(DeaconSessionName)
hasDeacon, err := d.tmux.HasSession(d.getDeaconSessionName())
if err != nil {
d.logger.Printf("Error checking Deacon session: %v", err)
status.LastAction = "error"
@@ -265,7 +275,7 @@ func (d *Daemon) runDegradedBootTriage(b *boot.Boot) {
// The Deacon is the system's heartbeat - it must always be running.
func (d *Daemon) ensureDeaconRunning() {
// Check agent bead state (ZFC: trust what agent reports)
beadState, beadErr := d.getAgentBeadState("gt-deacon")
beadState, beadErr := d.getAgentBeadState(d.getDeaconSessionName())
if beadErr == nil {
if beadState == "running" || beadState == "working" {
// Agent reports it's running - trust it
@@ -277,9 +287,10 @@ func (d *Daemon) ensureDeaconRunning() {
// Agent bead check failed or state is not running.
// FALLBACK: Check if tmux session is actually healthy before attempting restart.
// This prevents killing healthy sessions when bead state is stale or unreadable.
hasSession, sessionErr := d.tmux.HasSession(DeaconSessionName)
deaconSession := d.getDeaconSessionName()
hasSession, sessionErr := d.tmux.HasSession(deaconSession)
if sessionErr == nil && hasSession {
if d.tmux.IsClaudeRunning(DeaconSessionName) {
if d.tmux.IsClaudeRunning(deaconSession) {
d.logger.Println("Deacon session healthy (Claude running), skipping restart despite stale bead")
return
}
@@ -291,19 +302,20 @@ func (d *Daemon) ensureDeaconRunning() {
// Create session in deacon directory (ensures correct CLAUDE.md is loaded)
// Use EnsureSessionFresh to handle zombie sessions that exist but have dead Claude
deaconDir := filepath.Join(d.config.TownRoot, "deacon")
if err := d.tmux.EnsureSessionFresh(DeaconSessionName, deaconDir); err != nil {
sessionName := d.getDeaconSessionName()
if err := d.tmux.EnsureSessionFresh(sessionName, deaconDir); err != nil {
d.logger.Printf("Error creating Deacon session: %v", err)
return
}
// Set environment (non-fatal: session works without these)
_ = d.tmux.SetEnvironment(DeaconSessionName, "GT_ROLE", "deacon")
_ = d.tmux.SetEnvironment(DeaconSessionName, "BD_ACTOR", "deacon")
_ = d.tmux.SetEnvironment(sessionName, "GT_ROLE", "deacon")
_ = d.tmux.SetEnvironment(sessionName, "BD_ACTOR", "deacon")
// Launch Claude directly (no shell respawn loop)
// The daemon will detect if Claude exits and restart it on next heartbeat
// Export GT_ROLE and BD_ACTOR so Claude inherits them (tmux SetEnvironment doesn't export to processes)
if err := d.tmux.SendKeys(DeaconSessionName, config.BuildAgentStartupCommand("deacon", "deacon", "", "")); err != nil {
if err := d.tmux.SendKeys(sessionName, config.BuildAgentStartupCommand("deacon", "deacon", "", "")); err != nil {
d.logger.Printf("Error launching Claude in Deacon session: %v", err)
return
}
@@ -331,8 +343,10 @@ func (d *Daemon) checkDeaconHeartbeat() {
d.logger.Printf("Deacon heartbeat is stale (%s old), checking session...", age.Round(time.Minute))
sessionName := d.getDeaconSessionName()
// Check if session exists
hasSession, err := d.tmux.HasSession(DeaconSessionName)
hasSession, err := d.tmux.HasSession(sessionName)
if err != nil {
d.logger.Printf("Error checking Deacon session: %v", err)
return
@@ -347,14 +361,14 @@ func (d *Daemon) checkDeaconHeartbeat() {
if age > 30*time.Minute {
// Very stuck - restart the session
d.logger.Printf("Deacon stuck for %s - restarting session", age.Round(time.Minute))
if err := d.tmux.KillSession(DeaconSessionName); err != nil {
if err := d.tmux.KillSession(sessionName); err != nil {
d.logger.Printf("Error killing stuck Deacon: %v", err)
}
// ensureDeaconRunning will be called next heartbeat to restart
} else {
// Stuck but not critically - nudge to wake up
d.logger.Printf("Deacon stuck for %s - nudging session", age.Round(time.Minute))
if err := d.tmux.NudgeSession(DeaconSessionName, "HEALTH_CHECK: heartbeat stale, respond to confirm responsiveness"); err != nil {
if err := d.tmux.NudgeSession(sessionName, "HEALTH_CHECK: heartbeat stale, respond to confirm responsiveness"); err != nil {
d.logger.Printf("Error nudging stuck Deacon: %v", err)
}
}
+12 -2
View File
@@ -12,7 +12,9 @@ import (
"github.com/steveyegge/gastown/internal/beads"
"github.com/steveyegge/gastown/internal/config"
"github.com/steveyegge/gastown/internal/constants"
"github.com/steveyegge/gastown/internal/session"
"github.com/steveyegge/gastown/internal/tmux"
"github.com/steveyegge/gastown/internal/workspace"
)
// BeadsMessage represents a message from gt mail inbox --json.
@@ -310,8 +312,16 @@ func (d *Daemon) identityToSession(identity string) string {
// Fallback: use default patterns based on role type
switch parsed.RoleType {
case "mayor", "deacon":
return "gt-" + parsed.RoleType
case "mayor":
if townName, err := workspace.GetTownName(d.config.TownRoot); err == nil {
return session.MayorSessionName(townName)
}
return ""
case "deacon":
if townName, err := workspace.GetTownName(d.config.TownRoot); err == nil {
return session.DeaconSessionName(townName)
}
return ""
case "witness", "refinery":
return fmt.Sprintf("gt-%s-%s", parsed.RigName, parsed.RoleType)
case "crew":
+33 -3
View File
@@ -3,6 +3,8 @@ package daemon
import (
"io"
"log"
"os"
"path/filepath"
"testing"
)
@@ -14,6 +16,33 @@ func testDaemon() *Daemon {
}
}
// testDaemonWithTown creates a Daemon with a proper town setup for testing.
// Returns the daemon and a cleanup function.
func testDaemonWithTown(t *testing.T, townName string) (*Daemon, func()) {
t.Helper()
townRoot := t.TempDir()
// Create mayor directory and town.json
mayorDir := filepath.Join(townRoot, "mayor")
if err := os.MkdirAll(mayorDir, 0755); err != nil {
t.Fatalf("failed to create mayor dir: %v", err)
}
townJSON := filepath.Join(mayorDir, "town.json")
content := `{"name": "` + townName + `"}`
if err := os.WriteFile(townJSON, []byte(content), 0644); err != nil {
t.Fatalf("failed to write town.json: %v", err)
}
d := &Daemon{
config: &Config{TownRoot: townRoot},
logger: log.New(io.Discard, "", 0),
}
return d, func() {
// Cleanup handled by t.TempDir()
}
}
func TestParseLifecycleRequest_Cycle(t *testing.T) {
d := testDaemon()
@@ -152,11 +181,12 @@ func TestParseLifecycleRequest_AlwaysUsesFromField(t *testing.T) {
}
func TestIdentityToSession_Mayor(t *testing.T) {
d := testDaemon()
d, cleanup := testDaemonWithTown(t, "ai")
defer cleanup()
result := d.identityToSession("mayor")
if result != "gt-mayor" {
t.Errorf("identityToSession('mayor') = %q, expected 'gt-mayor'", result)
if result != "gt-ai-mayor" {
t.Errorf("identityToSession('mayor') = %q, expected 'gt-ai-mayor'", result)
}
}
+13 -5
View File
@@ -7,6 +7,9 @@ import (
"os/exec"
"path/filepath"
"strings"
"github.com/steveyegge/gastown/internal/session"
"github.com/steveyegge/gastown/internal/workspace"
)
// LifecycleHygieneCheck detects and cleans up stale lifecycle state.
@@ -139,7 +142,7 @@ func (c *LifecycleHygieneCheck) checkStateFiles(ctx *CheckContext) int {
if strings.HasPrefix(key, "requesting_") {
if boolVal, ok := val.(bool); ok && boolVal {
// Found a stuck flag - verify session is actually healthy
if c.isSessionHealthy(sf.identity) {
if c.isSessionHealthy(sf.identity, ctx.TownRoot) {
c.stuckStateFiles = append(c.stuckStateFiles, stuckState{
stateFile: sf.path,
identity: sf.identity,
@@ -225,8 +228,8 @@ func (c *LifecycleHygieneCheck) findStateFiles(townRoot string) []stateFileInfo
}
// isSessionHealthy checks if the tmux session for this identity exists and is running.
func (c *LifecycleHygieneCheck) isSessionHealthy(identity string) bool {
sessionName := identityToSessionName(identity)
func (c *LifecycleHygieneCheck) isSessionHealthy(identity, townRoot string) bool {
sessionName := identityToSessionName(identity, townRoot)
if sessionName == "" {
return false
}
@@ -237,10 +240,15 @@ func (c *LifecycleHygieneCheck) isSessionHealthy(identity string) bool {
}
// identityToSessionName converts an identity to its tmux session name.
func identityToSessionName(identity string) string {
func identityToSessionName(identity, townRoot string) string {
switch identity {
case "mayor":
return "gt-mayor"
if townRoot != "" {
if townName, err := workspace.GetTownName(townRoot); err == nil {
return session.MayorSessionName(townName)
}
}
return "" // Cannot generate session name without town root
default:
if strings.HasSuffix(identity, "-witness") ||
strings.HasSuffix(identity, "-refinery") ||
+22 -13
View File
@@ -8,7 +8,9 @@ import (
"regexp"
"strings"
"github.com/steveyegge/gastown/internal/session"
"github.com/steveyegge/gastown/internal/tmux"
"github.com/steveyegge/gastown/internal/workspace"
)
// OrphanSessionCheck detects orphaned tmux sessions that don't match
@@ -55,24 +57,31 @@ func (c *OrphanSessionCheck) Run(ctx *CheckContext) *CheckResult {
// Get list of valid rigs
validRigs := c.getValidRigs(ctx.TownRoot)
// Get dynamic session names for mayor/deacon
var mayorSession, deaconSession string
if townName, err := workspace.GetTownName(ctx.TownRoot); err == nil {
mayorSession = session.MayorSessionName(townName)
deaconSession = session.DeaconSessionName(townName)
}
// Check each session
var orphans []string
var validCount int
for _, session := range sessions {
if session == "" {
for _, sess := range sessions {
if sess == "" {
continue
}
// Only check gt-* sessions (Gas Town sessions)
if !strings.HasPrefix(session, "gt-") {
if !strings.HasPrefix(sess, "gt-") {
continue
}
if c.isValidSession(session, validRigs) {
if c.isValidSession(sess, validRigs, mayorSession, deaconSession) {
validCount++
} else {
orphans = append(orphans, session)
orphans = append(orphans, sess)
}
}
@@ -166,27 +175,27 @@ func (c *OrphanSessionCheck) getValidRigs(townRoot string) []string {
// isValidSession checks if a session name matches expected Gas Town patterns.
// Valid patterns:
// - gt-mayor
// - gt-deacon
// - gt-{town}-mayor (dynamic based on town name)
// - gt-{town}-deacon (dynamic based on town name)
// - gt-<rig>-witness
// - gt-<rig>-refinery
// - gt-<rig>-<polecat> (where polecat is any name)
//
// Note: We can't verify polecat names without reading state, so we're permissive.
func (c *OrphanSessionCheck) isValidSession(session string, validRigs []string) bool {
// gt-mayor is always valid
if session == "gt-mayor" {
func (c *OrphanSessionCheck) isValidSession(sess string, validRigs []string, mayorSession, deaconSession string) bool {
// Mayor session is always valid (dynamic name based on town)
if mayorSession != "" && sess == mayorSession {
return true
}
// gt-deacon is always valid
if session == "gt-deacon" {
// Deacon session is always valid (dynamic name based on town)
if deaconSession != "" && sess == deaconSession {
return true
}
// For rig-specific sessions, extract rig name
// Pattern: gt-<rig>-<role>
parts := strings.SplitN(session, "-", 3)
parts := strings.SplitN(sess, "-", 3)
if len(parts) < 3 {
// Invalid format - must be gt-<rig>-<something>
return false
+13 -5
View File
@@ -5,7 +5,9 @@ import (
"os/exec"
"strings"
"github.com/steveyegge/gastown/internal/session"
"github.com/steveyegge/gastown/internal/tmux"
"github.com/steveyegge/gastown/internal/workspace"
)
// LinkedPaneCheck detects tmux sessions that share panes,
@@ -83,11 +85,17 @@ func (c *LinkedPaneCheck) Run(ctx *CheckContext) *CheckResult {
}
}
// Cache for Fix (exclude gt-mayor since we don't want to kill it)
// Cache for Fix (exclude mayor session since we don't want to kill it)
// Get dynamic mayor session name
var mayorSession string
if townName, err := workspace.GetTownName(ctx.TownRoot); err == nil {
mayorSession = session.MayorSessionName(townName)
}
c.linkedSessions = nil
for session := range linkedSessionSet {
if session != "gt-mayor" {
c.linkedSessions = append(c.linkedSessions, session)
for sess := range linkedSessionSet {
if mayorSession == "" || sess != mayorSession {
c.linkedSessions = append(c.linkedSessions, sess)
}
}
@@ -108,7 +116,7 @@ func (c *LinkedPaneCheck) Run(ctx *CheckContext) *CheckResult {
}
}
// Fix kills sessions with linked panes (except gt-mayor).
// Fix kills sessions with linked panes (except mayor session).
// The daemon will recreate them with independent panes.
func (c *LinkedPaneCheck) Fix(ctx *CheckContext) error {
if len(c.linkedSessions) == 0 {
+22 -3
View File
@@ -11,7 +11,9 @@ import (
"strings"
"github.com/steveyegge/gastown/internal/config"
"github.com/steveyegge/gastown/internal/session"
"github.com/steveyegge/gastown/internal/tmux"
"github.com/steveyegge/gastown/internal/workspace"
)
// ErrUnknownList indicates a mailing list name was not found in configuration.
@@ -934,7 +936,13 @@ func (r *Router) GetMailbox(address string) (*Mailbox, error) {
// Uses send-keys to echo a visible banner to ensure notification is seen.
// Supports mayor/, rig/polecat, and rig/refinery addresses.
func (r *Router) notifyRecipient(msg *Message) error {
sessionID := addressToSessionID(msg.To)
// Get town name for session name generation
var townName string
if r.townRoot != "" {
townName, _ = workspace.GetTownName(r.townRoot)
}
sessionID := addressToSessionID(msg.To, townName)
if sessionID == "" {
return nil // Unable to determine session ID
}
@@ -951,10 +959,21 @@ func (r *Router) notifyRecipient(msg *Message) error {
// addressToSessionID converts a mail address to a tmux session ID.
// Returns empty string if address format is not recognized.
func addressToSessionID(address string) string {
func addressToSessionID(address, townName string) string {
// Mayor address: "mayor/" or "mayor"
if strings.HasPrefix(address, "mayor") {
return "gt-mayor"
if townName != "" {
return session.MayorSessionName(townName)
}
return "" // Cannot generate session name without town name
}
// Deacon address: "deacon/" or "deacon"
if strings.HasPrefix(address, "deacon") {
if townName != "" {
return session.DeaconSessionName(townName)
}
return "" // Cannot generate session name without town name
}
// Rig-based address: "rig/target"
+6 -4
View File
@@ -87,12 +87,14 @@ func TestIsTownLevelAddress(t *testing.T) {
}
func TestAddressToSessionID(t *testing.T) {
townName := "ai"
tests := []struct {
address string
want string
}{
{"mayor", "gt-mayor"},
{"mayor/", "gt-mayor"},
{"mayor", "gt-ai-mayor"},
{"mayor/", "gt-ai-mayor"},
{"deacon", "gt-ai-deacon"},
{"gastown/refinery", "gt-gastown-refinery"},
{"gastown/Toast", "gt-gastown-Toast"},
{"beads/witness", "gt-beads-witness"},
@@ -103,9 +105,9 @@ func TestAddressToSessionID(t *testing.T) {
for _, tt := range tests {
t.Run(tt.address, func(t *testing.T) {
got := addressToSessionID(tt.address)
got := addressToSessionID(tt.address, townName)
if got != tt.want {
t.Errorf("addressToSessionID(%q) = %q, want %q", tt.address, got, tt.want)
t.Errorf("addressToSessionID(%q, %q) = %q, want %q", tt.address, townName, got, tt.want)
}
})
}
+12 -5
View File
@@ -14,6 +14,7 @@ import (
"github.com/steveyegge/gastown/internal/config"
"github.com/steveyegge/gastown/internal/git"
"github.com/steveyegge/gastown/internal/templates"
"github.com/steveyegge/gastown/internal/workspace"
)
// Common errors
@@ -794,12 +795,18 @@ func (m *Manager) createRoleCLAUDEmd(workspacePath string, role string, rigName
return err
}
// Get town name for session names
townName, _ := workspace.GetTownName(m.townRoot)
data := templates.RoleData{
Role: role,
RigName: rigName,
TownRoot: m.townRoot,
WorkDir: workspacePath,
Polecat: workerName, // Used for crew member name as well
Role: role,
RigName: rigName,
TownRoot: m.townRoot,
TownName: townName,
WorkDir: workspacePath,
Polecat: workerName, // Used for crew member name as well
MayorSession: fmt.Sprintf("gt-%s-mayor", townName),
DeaconSession: fmt.Sprintf("gt-%s-deacon", townName),
}
content, err := tmpl.RenderRole(role, data)
+18 -15
View File
@@ -21,15 +21,16 @@ const (
// AgentIdentity represents a parsed Gas Town agent identity.
type AgentIdentity struct {
Role Role // mayor, deacon, witness, refinery, crew, polecat
Rig string // empty for mayor/deacon
Town string // town name (for mayor/deacon only)
Rig string // rig name (empty for mayor/deacon)
Name string // crew/polecat name (empty for mayor/deacon/witness/refinery)
}
// ParseSessionName parses a tmux session name into an AgentIdentity.
//
// Session name formats:
// - gt-mayor → Role: mayor
// - gt-deacon → Role: deacon
// - gt-<town>-mayor → Role: mayor, Town: <town>
// - gt-<town>-deacon → Role: deacon, Town: <town>
// - gt-<rig>-witness → Role: witness, Rig: <rig>
// - gt-<rig>-refinery → Role: refinery, Rig: <rig>
// - gt-<rig>-crew-<name> → Role: crew, Rig: <rig>, Name: <name>
@@ -48,18 +49,20 @@ func ParseSessionName(session string) (*AgentIdentity, error) {
return nil, fmt.Errorf("invalid session name %q: empty after prefix", session)
}
// Check for global roles first (no rig)
switch suffix {
case "mayor":
return &AgentIdentity{Role: RoleMayor}, nil
case "deacon":
return &AgentIdentity{Role: RoleDeacon}, nil
}
// Parse rig-based roles
// Parse into parts
parts := strings.Split(suffix, "-")
if len(parts) < 2 {
return nil, fmt.Errorf("invalid session name %q: expected rig-role format", session)
return nil, fmt.Errorf("invalid session name %q: expected town-role or rig-role format", session)
}
// Check for mayor/deacon (town-level roles with suffix marker)
if parts[len(parts)-1] == "mayor" {
town := strings.Join(parts[:len(parts)-1], "-")
return &AgentIdentity{Role: RoleMayor, Town: town}, nil
}
if parts[len(parts)-1] == "deacon" {
town := strings.Join(parts[:len(parts)-1], "-")
return &AgentIdentity{Role: RoleDeacon, Town: town}, nil
}
// Check for witness/refinery (suffix markers)
@@ -94,9 +97,9 @@ func ParseSessionName(session string) (*AgentIdentity, error) {
func (a *AgentIdentity) SessionName() string {
switch a.Role {
case RoleMayor:
return MayorSessionName()
return MayorSessionName(a.Town)
case RoleDeacon:
return DeaconSessionName()
return DeaconSessionName(a.Town)
case RoleWitness:
return WitnessSessionName(a.Rig)
case RoleRefinery:
+43 -20
View File
@@ -9,20 +9,35 @@ func TestParseSessionName(t *testing.T) {
name string
session string
wantRole Role
wantTown string
wantRig string
wantName string
wantErr bool
}{
// Global roles (no rig)
// Town-level roles (mayor/deacon with town name)
{
name: "mayor",
session: "gt-mayor",
name: "mayor simple town",
session: "gt-ai-mayor",
wantRole: RoleMayor,
wantTown: "ai",
},
{
name: "deacon",
session: "gt-deacon",
name: "mayor hyphenated town",
session: "gt-my-town-mayor",
wantRole: RoleMayor,
wantTown: "my-town",
},
{
name: "deacon simple town",
session: "gt-alpha-deacon",
wantRole: RoleDeacon,
wantTown: "alpha",
},
{
name: "deacon hyphenated town",
session: "gt-my-town-deacon",
wantRole: RoleDeacon,
wantTown: "my-town",
},
// Witness (simple rig)
@@ -104,7 +119,7 @@ func TestParseSessionName(t *testing.T) {
wantErr: true,
},
{
name: "just prefix",
name: "just prefix single segment",
session: "gt-x",
wantErr: true,
},
@@ -123,6 +138,9 @@ func TestParseSessionName(t *testing.T) {
if got.Role != tt.wantRole {
t.Errorf("ParseSessionName(%q).Role = %v, want %v", tt.session, got.Role, tt.wantRole)
}
if got.Town != tt.wantTown {
t.Errorf("ParseSessionName(%q).Town = %v, want %v", tt.session, got.Town, tt.wantTown)
}
if got.Rig != tt.wantRig {
t.Errorf("ParseSessionName(%q).Rig = %v, want %v", tt.session, got.Rig, tt.wantRig)
}
@@ -140,14 +158,19 @@ func TestAgentIdentity_SessionName(t *testing.T) {
want string
}{
{
name: "mayor",
identity: AgentIdentity{Role: RoleMayor},
want: "gt-mayor",
name: "mayor with town",
identity: AgentIdentity{Role: RoleMayor, Town: "ai"},
want: "gt-ai-mayor",
},
{
name: "deacon",
identity: AgentIdentity{Role: RoleDeacon},
want: "gt-deacon",
name: "mayor hyphenated town",
identity: AgentIdentity{Role: RoleMayor, Town: "my-town"},
want: "gt-my-town-mayor",
},
{
name: "deacon with town",
identity: AgentIdentity{Role: RoleDeacon, Town: "alpha"},
want: "gt-alpha-deacon",
},
{
name: "witness",
@@ -230,22 +253,22 @@ func TestAgentIdentity_Address(t *testing.T) {
func TestParseSessionName_RoundTrip(t *testing.T) {
// Test that parsing then reconstructing gives the same result
sessions := []string{
"gt-mayor",
"gt-deacon",
"gt-ai-mayor",
"gt-alpha-deacon",
"gt-gastown-witness",
"gt-foo-bar-refinery",
"gt-gastown-crew-max",
"gt-gastown-morsov",
}
for _, session := range sessions {
t.Run(session, func(t *testing.T) {
identity, err := ParseSessionName(session)
for _, sess := range sessions {
t.Run(sess, func(t *testing.T) {
identity, err := ParseSessionName(sess)
if err != nil {
t.Fatalf("ParseSessionName(%q) error = %v", session, err)
t.Fatalf("ParseSessionName(%q) error = %v", sess, err)
}
if got := identity.SessionName(); got != session {
t.Errorf("Round-trip failed: ParseSessionName(%q).SessionName() = %q", session, got)
if got := identity.SessionName(); got != sess {
t.Errorf("Round-trip failed: ParseSessionName(%q).SessionName() = %q", sess, got)
}
})
}
+8 -4
View File
@@ -12,13 +12,17 @@ import (
const Prefix = "gt-"
// MayorSessionName returns the session name for the Mayor agent.
func MayorSessionName() string {
return Prefix + "mayor"
// The townName parameter allows multiple towns to run concurrently
// without tmux session name collisions.
func MayorSessionName(townName string) string {
return fmt.Sprintf("%s%s-mayor", Prefix, townName)
}
// DeaconSessionName returns the session name for the Deacon agent.
func DeaconSessionName() string {
return Prefix + "deacon"
// The townName parameter allows multiple towns to run concurrently
// without tmux session name collisions.
func DeaconSessionName(townName string) string {
return fmt.Sprintf("%s%s-deacon", Prefix, townName)
}
// WitnessSessionName returns the session name for a rig's Witness agent.
+32 -8
View File
@@ -8,18 +8,42 @@ import (
)
func TestMayorSessionName(t *testing.T) {
want := "gt-mayor"
got := MayorSessionName()
if got != want {
t.Errorf("MayorSessionName() = %q, want %q", got, want)
tests := []struct {
townName string
want string
}{
{"ai", "gt-ai-mayor"},
{"alpha", "gt-alpha-mayor"},
{"gastown", "gt-gastown-mayor"},
{"", "gt--mayor"}, // empty town name
}
for _, tt := range tests {
t.Run(tt.townName, func(t *testing.T) {
got := MayorSessionName(tt.townName)
if got != tt.want {
t.Errorf("MayorSessionName(%q) = %q, want %q", tt.townName, got, tt.want)
}
})
}
}
func TestDeaconSessionName(t *testing.T) {
want := "gt-deacon"
got := DeaconSessionName()
if got != want {
t.Errorf("DeaconSessionName() = %q, want %q", got, want)
tests := []struct {
townName string
want string
}{
{"ai", "gt-ai-deacon"},
{"alpha", "gt-alpha-deacon"},
{"gastown", "gt-gastown-deacon"},
{"", "gt--deacon"}, // empty town name
}
for _, tt := range tests {
t.Run(tt.townName, func(t *testing.T) {
got := DeaconSessionName(tt.townName)
if got != tt.want {
t.Errorf("DeaconSessionName(%q) = %q, want %q", tt.townName, got, tt.want)
}
})
}
}
+1 -1
View File
@@ -57,7 +57,7 @@ Check the current system state:
```bash
# Is Deacon session alive?
tmux has-session -t gt-deacon 2>/dev/null && echo "alive" || echo "dead"
tmux has-session -t {{ .DeaconSession }} 2>/dev/null && echo "alive" || echo "dead"
# If alive, what's the pane showing?
gt peek deacon --lines 20
+3 -3
View File
@@ -244,8 +244,8 @@ This is the opposite of polecat work, which is persistent and auditable.
| Role | Session Name |
|------|-------------|
| Deacon | `gt-deacon` (you) |
| Mayor | `gt-mayor` |
| Deacon | `{{ .DeaconSession }}` (you) |
| Mayor | `{{ .MayorSession }}` |
| Witness | `gt-<rig>-witness` |
| Crew | `gt-<rig>-<name>` |
@@ -376,5 +376,5 @@ But typically just exit and let the daemon respawn you with fresh context.
State directory: {{ .TownRoot }}/deacon/
Mail identity: deacon/
Session: gt-deacon
Session: {{ .DeaconSession }}
Patrol molecule: mol-deacon-patrol (created as wisp)
+11 -8
View File
@@ -24,14 +24,17 @@ type Templates struct {
// RoleData contains information for rendering role contexts.
type RoleData struct {
Role string // mayor, witness, refinery, polecat, crew, deacon
RigName string // e.g., "greenplace"
TownRoot string // e.g., "/Users/steve/ai"
WorkDir string // current working directory
Polecat string // polecat name (for polecat role)
Polecats []string // list of polecats (for witness role)
BeadsDir string // BEADS_DIR path
IssuePrefix string // beads issue prefix
Role string // mayor, witness, refinery, polecat, crew, deacon
RigName string // e.g., "greenplace"
TownRoot string // e.g., "/Users/steve/ai"
TownName string // e.g., "ai" - the town identifier for session names
WorkDir string // current working directory
Polecat string // polecat name (for polecat role)
Polecats []string // list of polecats (for witness role)
BeadsDir string // BEADS_DIR path
IssuePrefix string // beads issue prefix
MayorSession string // e.g., "gt-ai-mayor" - dynamic mayor session name
DeaconSession string // e.g., "gt-ai-deacon" - dynamic deacon session name
}
// SpawnData contains information for spawn assignment messages.
+20 -11
View File
@@ -22,9 +22,12 @@ func TestRenderRole_Mayor(t *testing.T) {
}
data := RoleData{
Role: "mayor",
TownRoot: "/test/town",
WorkDir: "/test/town",
Role: "mayor",
TownRoot: "/test/town",
TownName: "town",
WorkDir: "/test/town",
MayorSession: "gt-town-mayor",
DeaconSession: "gt-town-deacon",
}
output, err := tmpl.RenderRole("mayor", data)
@@ -51,11 +54,14 @@ func TestRenderRole_Polecat(t *testing.T) {
}
data := RoleData{
Role: "polecat",
RigName: "myrig",
TownRoot: "/test/town",
WorkDir: "/test/town/myrig/polecats/TestCat",
Polecat: "TestCat",
Role: "polecat",
RigName: "myrig",
TownRoot: "/test/town",
TownName: "town",
WorkDir: "/test/town/myrig/polecats/TestCat",
Polecat: "TestCat",
MayorSession: "gt-town-mayor",
DeaconSession: "gt-town-deacon",
}
output, err := tmpl.RenderRole("polecat", data)
@@ -82,9 +88,12 @@ func TestRenderRole_Deacon(t *testing.T) {
}
data := RoleData{
Role: "deacon",
TownRoot: "/test/town",
WorkDir: "/test/town",
Role: "deacon",
TownRoot: "/test/town",
TownName: "town",
WorkDir: "/test/town",
MayorSession: "gt-town-mayor",
DeaconSession: "gt-town-deacon",
}
output, err := tmpl.RenderRole("deacon", data)
+34
View File
@@ -6,6 +6,8 @@ import (
"fmt"
"os"
"path/filepath"
"github.com/steveyegge/gastown/internal/config"
)
// ErrNotFound indicates no workspace was found.
@@ -126,3 +128,35 @@ func IsWorkspace(dir string) (bool, error) {
return false, nil
}
// GetTownName loads the town name from the workspace's town.json config.
// This is used for generating unique tmux session names that avoid collisions
// when running multiple Gas Town instances.
func GetTownName(townRoot string) (string, error) {
townConfigPath := filepath.Join(townRoot, PrimaryMarker)
townConfig, err := config.LoadTownConfig(townConfigPath)
if err != nil {
return "", fmt.Errorf("loading town config: %w", err)
}
return townConfig.Name, nil
}
// GetTownNameFromCwd locates the town root from the current working directory
// and returns the town name from its configuration.
func GetTownNameFromCwd() (string, error) {
townRoot, err := FindFromCwdOrError()
if err != nil {
return "", err
}
return GetTownName(townRoot)
}
// MustGetTownName returns the town name or panics if it cannot be loaded.
// Use sparingly - prefer GetTownName with proper error handling.
func MustGetTownName(townRoot string) string {
name, err := GetTownName(townRoot)
if err != nil {
panic(fmt.Sprintf("failed to get town name: %v", err))
}
return name
}